Bug 39468 - EDI message status should be case insensitive
Summary: EDI message status should be case insensitive
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: David Gustafsson
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-27 13:06 UTC by David Gustafsson
Modified: 2025-11-07 17:04 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Fix EDI message status display in acquisitions so matching is case-insensitive by converting edi_order.status to lowercase before comparison.
Version(s) released in:
Circulation function:


Attachments
Bug 39468: EDI message status should be case insensitive (1.16 KB, patch)
2025-03-27 13:08 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 39468: EDI message status should be case insensitive (1.23 KB, patch)
2025-11-07 17:00 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 39468: EDI message status should be case insensitive (1.23 KB, patch)
2025-11-07 17:03 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Gustafsson 2025-03-27 13:06:15 UTC
There already was a bug (Bug 32676) that should have addressed this. The initial commit looks ok, but the final one, which seems be the one that have been pushed is missing the .lower on edi_order.status.
Comment 1 David Gustafsson 2025-03-27 13:08:49 UTC
Created attachment 179792 [details] [review]
Bug 39468: EDI message status should be case insensitive

Make edi_order lowercase so that matching is case insensitive.
Comment 2 David Gustafsson 2025-03-27 13:14:45 UTC
I now saw both patches (that for some reason are absolute) contains the .lower change), but the commit in the Koha repo is missing it.
Comment 3 Laura Escamilla 2025-11-07 17:00:30 UTC
Created attachment 189351 [details] [review]
Bug 39468: EDI message status should be case insensitive

Make edi_order lowercase so that matching is case insensitive.

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Laura Escamilla 2025-11-07 17:03:13 UTC
Created attachment 189352 [details] [review]
Bug 39468: EDI message status should be case insensitive

Make edi_order lowercase so that matching is case insensitive.

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 5 Laura Escamilla 2025-11-07 17:03:59 UTC
Using my QA superpowers to PQA on this trivial patch.