Bug 36698 wants to display the diff nicely. As a stopgap, how about we just make it possible to display them as-is?
Created attachment 180922 [details] [review] Bug 39628: Show diff in log viewer and column settings To test: 1 - apply patch 2 - search the log viewer for item edits or something else that records a diff value 3 - see that diff in the new column 4 - confirm the diff value is present in exports and prints 5 - confirm you can use column config to hide that diff value
Yes, it is good start to show data from diff col. I modified an item and can confirm p. 1-4 test plan, but not p. 5. There is no "Diff" in cols list for "Columns" button. There is no "diff" in configure table (/cgi-bin/koha/admin/columns_settings.pl?module=tools&page=logviewer&table=logst) to hide it by default.
(In reply to Roman Dolny from comment #2) > Yes, it is good start to show data from diff col. > > I modified an item and can confirm p. 1-4 test plan, but not p. 5. > > There is no "Diff" in cols list for "Columns" button. > There is no "diff" in configure table > (/cgi-bin/koha/admin/columns_settings. > pl?module=tools&page=logviewer&table=logst) to hide it by default. Did you restart_all after applying the patch? I forgot to specify that in the test plan, but I do see Diff in the table config after restarting services.
(In reply to Andrew Fuerste-Henry from comment #3) > ... > Did you restart_all after applying the patch? I forgot to specify that in > the test plan, but I do see Diff in the table config after restarting > services. I'm pretty sure I did, but now it works... checked twice, with another browser and incognito. Thanks for suggestion.
Created attachment 180937 [details] [review] Bug 39628: Show diff in log viewer and column settings To test: 1 - apply patch 2 - search the log viewer for item edits or something else that records a diff value 3 - see that diff in the new column 4 - confirm the diff value is present in exports and prints 5 - confirm you can use column config to hide that diff value Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 182190 [details] [review] Bug 39628: Show diff in log viewer and column settings To test: 1 - apply patch 2 - search the log viewer for item edits or something else that records a diff value 3 - see that diff in the new column 4 - confirm the diff value is present in exports and prints 5 - confirm you can use column config to hide that diff value Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
I agree it's worth displaying the raw diff in the meantime. Thanks, Andrew!
This is a bit scary looking. Could we agree to hide the column by default in the table configuration settings? (these are also missing, please follow-up!)
I need to clarify, the "Diff" was not showing up initially in my column configuration settings above the table. After some restarting etc. it does now. It still might be nice to hide it by default, but leaving that for a simple follow-up.
Pushed for 25.05! Well done everyone, thank you!
> It still might be nice to hide it by default, but leaving that for a simple > follow-up. Follow-up filed: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39908