Bug 39837 - Vendor interface object under specified
Summary: Vendor interface object under specified
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P1 - high normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 38010 39838
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-05 17:25 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-05-13 16:47 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39837: Rename (aqbookseller_interfaces) column interface_id to vendor_interface_id (3.07 KB, patch)
2025-05-05 18:18 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 39837: Add definition in swagger (1.89 KB, patch)
2025-05-05 18:18 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 39837: Fix uses of `interface_id` (1.19 KB, patch)
2025-05-05 18:18 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 39837: Rename (aqbookseller_interfaces) column interface_id to vendor_interface_id (3.13 KB, patch)
2025-05-13 06:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39837: Add definition in swagger (1.95 KB, patch)
2025-05-13 06:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39837: Fix uses of `interface_id` (1.25 KB, patch)
2025-05-13 06:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-05-05 17:25:04 UTC
Bug 38010 slipped in the use of the `aqbookseller_interfaces` table by defining `interfaces` to be of type array.

This should be specified in the spec and validated.

Note: the column names are good and don't seem to need mapping.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-05-05 18:18:39 UTC
Created attachment 181938 [details] [review]
Bug 39837: Rename (aqbookseller_interfaces) column interface_id to vendor_interface_id
Comment 2 Tomás Cohen Arazi (tcohen) 2025-05-05 18:18:41 UTC
Created attachment 181939 [details] [review]
Bug 39837: Add  definition in swagger
Comment 3 Tomás Cohen Arazi (tcohen) 2025-05-05 18:18:44 UTC
Created attachment 181940 [details] [review]
Bug 39837: Fix uses of `interface_id`
Comment 4 Martin Renvoize (ashimema) 2025-05-13 06:35:09 UTC
Created attachment 182326 [details] [review]
Bug 39837: Rename (aqbookseller_interfaces) column interface_id to vendor_interface_id

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 5 Martin Renvoize (ashimema) 2025-05-13 06:35:12 UTC
Created attachment 182327 [details] [review]
Bug 39837: Add definition in swagger

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 6 Martin Renvoize (ashimema) 2025-05-13 06:35:15 UTC
Created attachment 182328 [details] [review]
Bug 39837: Fix uses of `interface_id`

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 7 Martin Renvoize (ashimema) 2025-05-13 06:36:43 UTC
I think this is important to go in with all the Vendors work we've recently pushed.

Passing QA
Comment 8 Katrin Fischer 2025-05-13 16:47:59 UTC
Pushed for 25.05!

Well done everyone, thank you!