Bug 38010 slipped in the use of the `aqbookseller_aliases` table by defining `interfaces` to be of type array. This should be specified in the spec and validated. Note: the column names are good and don't seem to need mapping.
I just noted there's a `vendor_alias.yaml` file. Closing as invalid for now.
Created attachment 181932 [details] [review] Bug 39838: Add `vendor_alias` definition in swagger Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I patched it anyway as I found a copy and paste error. As there doesn't exist an endpoint for retrieving the aliases, it is not obvious that we need to include the object definition. But I think we should, and also that we should have such (trivial?) endpoint at some point. Out of the scope of this bug, though.
Created attachment 181933 [details] [review] Bug 39838: Add `vendor_alias` definition in swagger Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 181934 [details] [review] Bug 39838: Rename (aqbookseller_aliases) column alias_id to vendor_alias_id
Created attachment 181935 [details] [review] Bug 39838: Add `vendor_alias` definition in swagger This patch adapts the definition file and also tweaks the attribute names and descriptions to match our guidelines. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 181936 [details] [review] Bug 39838: Fix uses of `alias_id`
(In reply to David Nind from comment #4) > Created attachment 181933 [details] [review] [review] Thanks, but this needs more thinking right now. I reckon the definition was added back in 22.11! And this needs Jonathan and Matt's opinion before moving forward.
Created attachment 182320 [details] [review] Bug 39838: Rename (aqbookseller_aliases) column alias_id to vendor_alias_id Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 182321 [details] [review] Bug 39838: Add `vendor_alias` definition in swagger This patch adapts the definition file and also tweaks the attribute names and descriptions to match our guidelines. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 182322 [details] [review] Bug 39838: Fix uses of `alias_id` Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 182323 [details] [review] Bug 39838: Rename (aqbookseller_aliases) column alias_id to vendor_alias_id Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 182324 [details] [review] Bug 39838: Add `vendor_alias` definition in swagger This patch adapts the definition file and also tweaks the attribute names and descriptions to match our guidelines. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 182325 [details] [review] Bug 39838: Fix uses of `alias_id` Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
I think this is important to go in with all the Vendors work we've recently pushed. Passing QA
Will push, but can you explain why the change from alias_id to vendor_alias_id was important?
Pushed for 25.05! Well done everyone, thank you!