FSF and GNU links should be moved to HTTPS.
Created attachment 183333 [details] [review] Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I've failed QA as for all the release notes in diff, the existing https was changed to http. A couple of other things noted, but outside the scope of the bug: URLs changed, excluding release notes: - http://www.gnu.org/licenses -> https://www.gnu.org/licenses - http://wiki.koha-community.org/wiki/Shibboleth_Configuration -> https://wiki.koha-community.org/wiki/Shibboleth_Configuration - http://koha-community.org/ -> https://koha-community.org/ - http://bugs.koha-community.org/ -> https://bugs.koha-community.org/ - http://fsf.org/ -> https://fsf.org/ - http://www.gnu.org/licenses/gpl.html -> https://www.gnu.org/licenses/gpl.html - http://bugs.koha-community.org/bugzilla3/ -> https://bugs.koha-community.org/bugzilla3/ - http://wiki.koha-community.org/wiki/Bug7284_authority_matching_improvement -> https://wiki.koha-community.org/wiki/Bug7284_authority_matching_improvement - http://wiki.koha-community.org/wiki/Age_restriction -> https://wiki.koha-community.org/wiki/Age_restriction - http://wiki.koha-community.org/wiki/OpacHiddenItems -> https://wiki.koha-community.org/wiki/OpacHiddenItems - http://wiki.koha-community.org/wiki/SQL_Reports_Library -> https://wiki.koha-community.org/wiki/SQL_Reports_Library - http://wiki.koha-community.org/wiki/Opac_browse_feature -> https://wiki.koha-community.org/wiki/Opac_browse_feature - http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2883 -> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2883 - http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 -> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 - http://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format -> https://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format Notes: - https://fsf.org/ redirects to https://www.fsf.org/ - http://www.gnu.org/licenses/gpl.html redirects to https://www.gnu.org/licenses/gpl-3.0.html - http://www.w3.org/2001/XMLSchema-instance redirects to https://www.w3.org/2001/XMLSchema-instance . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_006.xml . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_007.xml . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_008.xml Should https://bugs.koha-community.org/bugzilla3/ be just https://bugs.koha-community.org/ ? - debian/docs/koha-common.xml - debian/docs/koha-create.xml Says licensed under the General Public License, v2 (originally from 2002): - admin/aqbudgetperiods.pl - admin/aqplan.pl - admin/systempreferences.pl - authorities/ysearch.pl - cataloguing/ysearch.pl - tags/review.pl https changed to http for all release notes in the diff: - misc/release_notes/release_notes_17_05_00.html and misc/release_notes/release_notes_17_05_00.md - misc/release_notes/release_notes_18_05_00.html and misc/release_notes/release_notes_18_05_00.md - misc/release_notes/release_notes_20_11_00.html and misc/release_notes/release_notes_20_11_00.md: - misc/release_notes/release_notes_21_05_00.html and misc/release_notes/release_notes_21_05_00.md: - misc/release_notes/release_notes_21_11_00.html and misc/release_notes/release_notes_21_11_00.md - misc/release_notes/release_notes_22_05_00.html and misc/release_notes/release_notes_22_05_00.md - misc/release_notes/release_notes_22_11_00.html and misc/release_notes/release_notes_22_11_00.md - misc/release_notes/release_notes_23_05_00.md - misc/release_notes/release_notes_23_11_00.md - misc/release_notes/release_notes_24_05_00.md - misc/release_notes/release_notes_24_11_00.md - misc/release_notes/release_notes_25_05_00.md
Created attachment 186545 [details] [review] Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 186546 [details] [review] Bug 40163: (follow-up) Fix Bugzilla URL
Created attachment 186547 [details] [review] Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 186548 [details] [review] Bug 40163: (follow-up) Fix Bugzilla URL
I decided not to fix the release notes. It is just too much and probably shouldn't even belong to this repository.
Created attachment 186623 [details] [review] Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 186624 [details] [review] Bug 40163: (follow-up) Fix Bugzilla URL Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
I rebased this when I signed off because /App/Plugin/CGIBinKoha.pm had been deleted.
Created attachment 186762 [details] [review] Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 186763 [details] [review] Bug 40163: (follow-up) Fix Bugzilla URL Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
/kohadevbox/koha/xt/find-license-problems.t is failing now Is the right fix to update the test to allow for both 'http' and 'https' or find all the occurrences of: # <http://www.gnu.org/licenses>
(In reply to Lucas Gass (lukeg) from comment #14) > /kohadevbox/koha/xt/find-license-problems.t is failing now > > Is the right fix to update the test to allow for both 'http' and 'https' or > find all the occurrences of: > > # <http://www.gnu.org/licenses> Following the spirit of this patches, we should enforce https for the GNU licenses. But I found a few places where my search didn't find some wrong cases. I'll attach a follow-up ASAP.
Created attachment 186890 [details] [review] Bug 40163: (follow-up) Fix wrong GNU links and update test Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
follow-up pushed to main. Thanks Tomas!