Bug 40163 - Several http links should be moved to https
Summary: Several http links should be moved to https
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks: 41481 40872
  Show dependency treegraph
 
Reported: 2025-06-18 14:17 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2026-02-05 23:06 UTC (History)
8 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.07
Circulation function:


Attachments
Bug 40163: Fix several http addresses in the code docs (1.55 MB, patch)
2025-06-18 14:44 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40163: Fix several http addresses in the code docs (4.62 MB, patch)
2025-09-17 18:22 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40163: (follow-up) Fix Bugzilla URL (1.49 KB, patch)
2025-09-17 18:30 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40163: Fix several http addresses in the code docs (899.55 KB, patch)
2025-09-17 18:33 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40163: (follow-up) Fix Bugzilla URL (1.49 KB, patch)
2025-09-17 18:33 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40163: Fix several http addresses in the code docs (899.03 KB, patch)
2025-09-19 13:08 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 40163: (follow-up) Fix Bugzilla URL (1.54 KB, patch)
2025-09-19 13:08 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 40163: Fix several http addresses in the code docs (902.23 KB, patch)
2025-09-22 21:04 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40163: (follow-up) Fix Bugzilla URL (1.61 KB, patch)
2025-09-22 21:04 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40163: (follow-up) Fix wrong GNU links and update test (436.95 KB, patch)
2025-09-24 14:53 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-06-18 14:17:42 UTC
FSF and GNU links should be moved to HTTPS.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-06-18 14:44:30 UTC
Created attachment 183333 [details] [review]
Bug 40163: Fix several http addresses in the code docs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2025-06-19 00:12:14 UTC
I've failed QA as for all the release notes in diff, the existing https was changed to http.

A couple of other things noted, but outside the scope of the bug:

URLs changed, excluding release notes:
- http://www.gnu.org/licenses -> https://www.gnu.org/licenses
- http://wiki.koha-community.org/wiki/Shibboleth_Configuration -> https://wiki.koha-community.org/wiki/Shibboleth_Configuration
- http://koha-community.org/ -> https://koha-community.org/
- http://bugs.koha-community.org/ -> https://bugs.koha-community.org/
- http://fsf.org/ -> https://fsf.org/
- http://www.gnu.org/licenses/gpl.html -> https://www.gnu.org/licenses/gpl.html
- http://bugs.koha-community.org/bugzilla3/ -> https://bugs.koha-community.org/bugzilla3/
- http://wiki.koha-community.org/wiki/Bug7284_authority_matching_improvement -> https://wiki.koha-community.org/wiki/Bug7284_authority_matching_improvement
- http://wiki.koha-community.org/wiki/Age_restriction -> https://wiki.koha-community.org/wiki/Age_restriction
- http://wiki.koha-community.org/wiki/OpacHiddenItems -> https://wiki.koha-community.org/wiki/OpacHiddenItems
- http://wiki.koha-community.org/wiki/SQL_Reports_Library -> https://wiki.koha-community.org/wiki/SQL_Reports_Library
- http://wiki.koha-community.org/wiki/Opac_browse_feature -> https://wiki.koha-community.org/wiki/Opac_browse_feature
- http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2883 -> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2883
- http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 -> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078
- http://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format -> https://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format

Notes: 
- https://fsf.org/ redirects to https://www.fsf.org/
- http://www.gnu.org/licenses/gpl.html redirects to https://www.gnu.org/licenses/gpl-3.0.html
- http://www.w3.org/2001/XMLSchema-instance redirects to https://www.w3.org/2001/XMLSchema-instance 
  . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_006.xml
  . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_007.xml
  . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_008.xml

Should https://bugs.koha-community.org/bugzilla3/ be just https://bugs.koha-community.org/ ?
- debian/docs/koha-common.xml
- debian/docs/koha-create.xml

Says licensed under the General Public License, v2 (originally from 2002):
- admin/aqbudgetperiods.pl
- admin/aqplan.pl
- admin/systempreferences.pl
- authorities/ysearch.pl
- cataloguing/ysearch.pl
- tags/review.pl 

https changed to http for all release notes in the diff:
- misc/release_notes/release_notes_17_05_00.html and misc/release_notes/release_notes_17_05_00.md
- misc/release_notes/release_notes_18_05_00.html and misc/release_notes/release_notes_18_05_00.md
- misc/release_notes/release_notes_20_11_00.html and misc/release_notes/release_notes_20_11_00.md: 
- misc/release_notes/release_notes_21_05_00.html and misc/release_notes/release_notes_21_05_00.md:
- misc/release_notes/release_notes_21_11_00.html and misc/release_notes/release_notes_21_11_00.md
- misc/release_notes/release_notes_22_05_00.html and misc/release_notes/release_notes_22_05_00.md
- misc/release_notes/release_notes_22_11_00.html and misc/release_notes/release_notes_22_11_00.md
- misc/release_notes/release_notes_23_05_00.md
- misc/release_notes/release_notes_23_11_00.md
- misc/release_notes/release_notes_24_05_00.md
- misc/release_notes/release_notes_24_11_00.md
- misc/release_notes/release_notes_25_05_00.md
Comment 3 Tomás Cohen Arazi (tcohen) 2025-09-17 18:22:27 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi (tcohen) 2025-09-17 18:30:35 UTC Comment hidden (obsolete)
Comment 5 Tomás Cohen Arazi (tcohen) 2025-09-17 18:33:54 UTC
Created attachment 186547 [details] [review]
Bug 40163: Fix several http addresses in the code docs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi (tcohen) 2025-09-17 18:33:57 UTC
Created attachment 186548 [details] [review]
Bug 40163: (follow-up) Fix Bugzilla URL
Comment 7 Tomás Cohen Arazi (tcohen) 2025-09-17 18:34:36 UTC
I decided not to fix the release notes. It is just too much and probably shouldn't even belong to this repository.
Comment 8 Brendan Lawlor 2025-09-19 13:08:11 UTC
Created attachment 186623 [details] [review]
Bug 40163: Fix several http addresses in the code docs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 9 Brendan Lawlor 2025-09-19 13:08:14 UTC
Created attachment 186624 [details] [review]
Bug 40163: (follow-up) Fix Bugzilla URL

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 10 Brendan Lawlor 2025-09-19 13:09:35 UTC
I rebased this when I signed off because /App/Plugin/CGIBinKoha.pm had been deleted.
Comment 11 Martin Renvoize (ashimema) 2025-09-22 21:04:26 UTC
Created attachment 186762 [details] [review]
Bug 40163: Fix several http addresses in the code docs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 12 Martin Renvoize (ashimema) 2025-09-22 21:04:28 UTC
Created attachment 186763 [details] [review]
Bug 40163: (follow-up) Fix Bugzilla URL

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 13 Lucas Gass (lukeg) 2025-09-23 22:24:10 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 14 Lucas Gass (lukeg) 2025-09-24 03:19:10 UTC
/kohadevbox/koha/xt/find-license-problems.t is failing now 

Is the right fix to update the test to allow for both 'http' and 'https' or find all the occurrences of: 

# <http://www.gnu.org/licenses>
Comment 15 Tomás Cohen Arazi (tcohen) 2025-09-24 14:01:24 UTC
(In reply to Lucas Gass (lukeg) from comment #14)
> /kohadevbox/koha/xt/find-license-problems.t is failing now 
> 
> Is the right fix to update the test to allow for both 'http' and 'https' or
> find all the occurrences of: 
> 
> # <http://www.gnu.org/licenses>

Following the spirit of this patches, we should enforce https for the GNU licenses. But I found a few places where my search didn't find some wrong cases. I'll attach a follow-up ASAP.
Comment 16 Tomás Cohen Arazi (tcohen) 2025-09-24 14:53:45 UTC
Created attachment 186890 [details] [review]
Bug 40163: (follow-up) Fix wrong GNU links and update test

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 17 Lucas Gass (lukeg) 2025-09-24 15:26:53 UTC
follow-up pushed to main. Thanks Tomas!
Comment 18 Andrii Nugged 2026-01-20 08:50:25 UTC
this patch breaks for example:

.../cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_field_008.pl

(when you want to use Tag Editor view one field in Marc editor) with pop-up error: 


Can't validate the xml data from /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/data/marc21_field_008.xml


if I remove the change:

-<Tagfield tag="008" xmlns="https://koha-community.org" ...
+<Tagfield tag="008" xmlns="http://koha-community.org" ...

It becomes to work well.

I assume it fails on all other .xml plugins.

This already came to 25.05-x branch and also in v25.11.00-2 releaseю
Comment 19 Andrii Nugged 2026-01-20 09:49:11 UTC
ah, we have follow-up, Bug 41481. Okay.
Comment 20 Fridolin Somers 2026-01-20 15:02:54 UTC
I see it is in 25.05.x
Comment 21 Fridolin Somers 2026-01-20 15:04:05 UTC
Not backported to 24.11.x
(too hard because of tidy)
Comment 22 David Nind 2026-01-20 18:07:11 UTC
Minimal changes required to the manual (if any). Link checking in December updated any issues I could find - http changed to https.

See Bug 41498 - Documentation maintenance tasks - December 2025 (and merge request https://gitlab.com/koha-community/koha-manual/-/merge_requests/1157 - commit about link checking).