Bug 40872 - opac/unapi type not detected by tidy.pl
Summary: opac/unapi type not detected by tidy.pl
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 40163 39876
Blocks:
  Show dependency treegraph
 
Reported: 2025-09-24 15:00 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-09-24 15:27 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40872: List opac/unapi as a Perl file (1.67 KB, patch)
2025-09-24 15:08 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40872: (follow-up) Tidy opac/unapi (9.44 KB, patch)
2025-09-24 15:08 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-09-24 15:00:01 UTC

    
Comment 1 Tomás Cohen Arazi (tcohen) 2025-09-24 15:08:10 UTC
Created attachment 186893 [details] [review]
Bug 40872: List opac/unapi as a Perl file

This patch makes `tidy.pl` treat the file as a Perl one.

To test:

1. Run:
   $ ktd --shell
  k$ misc/devel/tidy.pl opac/unapi
=> FAIL: You get:

```
Cannot guess filetype for opac/unapi at /kohadevbox/koha/Koha/Devel/Files.pm line 241.
```
2. Apply this patch
3. Repeat 1
=> SUCCESS: The file is now tidy.
4. Sign off :-D
Comment 2 Tomás Cohen Arazi (tcohen) 2025-09-24 15:08:13 UTC
Created attachment 186894 [details] [review]
Bug 40872: (follow-up) Tidy opac/unapi
Comment 3 Lucas Gass (lukeg) 2025-09-24 15:18:53 UTC
This is trivial, I am moving straight to PQA.
Comment 4 Lucas Gass (lukeg) 2025-09-24 15:27:21 UTC
Nice work everyone!

Pushed to main for 25.11