Bug 40281 - Patron circulation history page - type column is not hidden
Summary: Patron circulation history page - type column is not hidden
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: David Nind
QA Contact: Testopia
URL:
Keywords:
: 40299 (view as bug list)
Depends on: 37273 38954
Blocks:
  Show dependency treegraph
 
Reported: 2025-06-30 18:29 UTC by David Nind
Modified: 2025-07-03 08:28 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the patron circulation history page. The 'Type' column should not be shown, and is now hidden.
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40281: Hide the type column on the patron circulation history page (1.93 KB, patch)
2025-06-30 18:38 UTC, David Nind
Details | Diff | Splinter Review
Bug 40281: Hide the type column on the patron circulation history page (2.00 KB, patch)
2025-06-30 21:16 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2025-06-30 18:29:57 UTC
For a patron's circulation history page, the 'Type' column should be hidden, but it isn't.

The type column on a patron's circulation history page was hidden by 
Bug 38954 - Hide checkout type using colvis.

However, the commit for Bug 37273 - Add ID column to Agreements 
table in the ERM, inadvertently reversed hiding the column.

I can't see the change in the diffs on the bug, but the change was made in the actual commit https://git.koha-community.org/Koha-community/Koha/commit/d361c8adb6ffc5b269a4ec869ae31435205fc823?files=admin/columns_settings.yml

To replicate:
1. Check out an item to a patron (for example, 39999000011418 to Mary 
   Burton).
2. Look at the patron's circulation history page (Patrons > Mary Burton
   > Circulation hstory), and note that there is a 'Type' column shown 
   with a value of 'standard_checkout'.
3. Note that you can't hide the column, from either selecting the
   'Columns' or 'Configure' options for the table.
Comment 1 David Nind 2025-06-30 18:38:29 UTC
Created attachment 183650 [details] [review]
Bug 40281: Hide the type column on the patron circulation history page

This fixes the patron circulation history page so that the type column
is hidden.

The type column on a patron's circulation history page was hidden by
Bug 38954 - Hide checkout type using colvis.

However, the commit for Bug 37273 - Add ID column to Agreements
table in the ERM, inadvertently reversed hiding the column.

Test plan:
1. Check out an item to a patron (for example, 39999000011418 to Mary
   Burton).
2. Look at the patron's circulation history page (Patrons > Mary Burton
   > Circulation history), and note there is a 'Type' column shown
   with a value of 'standard_checkout'.
3. Note that you can't hide the column, from either selecting the
   'Columns' or 'Configure' options for the table.
4. Apply the patch, restart everything (restart_all), and clear your
   browser cache.
5. Repeat step 2. Note that there is now no 'Type' column shown and
   it is not configurable, from either selecting the 'Columns' or
   'Configure' options for the table.

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Laura Escamilla 2025-06-30 21:16:55 UTC
Created attachment 183658 [details] [review]
Bug 40281: Hide the type column on the patron circulation history page

This fixes the patron circulation history page so that the type column
is hidden.

The type column on a patron's circulation history page was hidden by
Bug 38954 - Hide checkout type using colvis.

However, the commit for Bug 37273 - Add ID column to Agreements
table in the ERM, inadvertently reversed hiding the column.

Test plan:
1. Check out an item to a patron (for example, 39999000011418 to Mary
   Burton).
2. Look at the patron's circulation history page (Patrons > Mary Burton
   > Circulation history), and note there is a 'Type' column shown
   with a value of 'standard_checkout'.
3. Note that you can't hide the column, from either selecting the
   'Columns' or 'Configure' options for the table.
4. Apply the patch, restart everything (restart_all), and clear your
   browser cache.
5. Repeat step 2. Note that there is now no 'Type' column shown and
   it is not configurable, from either selecting the 'Columns' or
   'Configure' options for the table.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 3 Laura Escamilla 2025-06-30 21:17:42 UTC
Thank you for working on this so quickly! The patch is simple, the qa tool is happy, I'm going to jump this over to passed QA.
Comment 4 Lucas Gass (lukeg) 2025-06-30 22:03:55 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Jonathan Druart 2025-07-03 08:28:00 UTC
Please link to the bugs so those bugfixes can be found easily :)
Comment 6 Jonathan Druart 2025-07-03 08:28:11 UTC
*** Bug 40299 has been marked as a duplicate of this bug. ***