For a patron's circulation history page, the 'Type' column should be hidden, but it isn't. The type column on a patron's circulation history page was hidden by Bug 38954 - Hide checkout type using colvis. However, the commit for Bug 37273 - Add ID column to Agreements table in the ERM, inadvertently reversed hiding the column. I can't see the change in the diffs on the bug, but the change was made in the actual commit https://git.koha-community.org/Koha-community/Koha/commit/d361c8adb6ffc5b269a4ec869ae31435205fc823?files=admin/columns_settings.yml To replicate: 1. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 2. Look at the patron's circulation history page (Patrons > Mary Burton > Circulation hstory), and note that there is a 'Type' column shown with a value of 'standard_checkout'. 3. Note that you can't hide the column, from either selecting the 'Columns' or 'Configure' options for the table.
Created attachment 183650 [details] [review] Bug 40281: Hide the type column on the patron circulation history page This fixes the patron circulation history page so that the type column is hidden. The type column on a patron's circulation history page was hidden by Bug 38954 - Hide checkout type using colvis. However, the commit for Bug 37273 - Add ID column to Agreements table in the ERM, inadvertently reversed hiding the column. Test plan: 1. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 2. Look at the patron's circulation history page (Patrons > Mary Burton > Circulation history), and note there is a 'Type' column shown with a value of 'standard_checkout'. 3. Note that you can't hide the column, from either selecting the 'Columns' or 'Configure' options for the table. 4. Apply the patch, restart everything (restart_all), and clear your browser cache. 5. Repeat step 2. Note that there is now no 'Type' column shown and it is not configurable, from either selecting the 'Columns' or 'Configure' options for the table. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183658 [details] [review] Bug 40281: Hide the type column on the patron circulation history page This fixes the patron circulation history page so that the type column is hidden. The type column on a patron's circulation history page was hidden by Bug 38954 - Hide checkout type using colvis. However, the commit for Bug 37273 - Add ID column to Agreements table in the ERM, inadvertently reversed hiding the column. Test plan: 1. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 2. Look at the patron's circulation history page (Patrons > Mary Burton > Circulation history), and note there is a 'Type' column shown with a value of 'standard_checkout'. 3. Note that you can't hide the column, from either selecting the 'Columns' or 'Configure' options for the table. 4. Apply the patch, restart everything (restart_all), and clear your browser cache. 5. Repeat step 2. Note that there is now no 'Type' column shown and it is not configurable, from either selecting the 'Columns' or 'Configure' options for the table. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Thank you for working on this so quickly! The patch is simple, the qa tool is happy, I'm going to jump this over to passed QA.
Nice work everyone! Pushed to main for 25.11
Please link to the bugs so those bugfixes can be found easily :)
*** Bug 40299 has been marked as a duplicate of this bug. ***