Bug 40366 - Update the label export process to avoid Greybox modal
Summary: Update the label export process to avoid Greybox modal
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 40422
  Show dependency treegraph
 
Reported: 2025-07-14 17:31 UTC by Owen Leonard
Modified: 2025-07-16 18:20 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40366: Update the label export process to avoid Greybox modal (11.22 KB, patch)
2025-07-14 18:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40366: Update the label export process to avoid Greybox modal (11.29 KB, patch)
2025-07-14 18:54 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 40366: (follow-up) Remove inclusion of greybox.inc (2.05 KB, patch)
2025-07-16 17:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40366: (follow-up) Remove inclusion of greybox.inc (2.12 KB, patch)
2025-07-16 18:20 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-07-14 17:31:56 UTC
I propose that we update the label export process in order to avoid using a Greybox modal. We can just as easily move from page to page as the process progresses.
Comment 1 Owen Leonard 2025-07-14 18:16:13 UTC
Created attachment 184060 [details] [review]
Bug 40366: Update the label export process to avoid Greybox modal

This patch updates the label export process to eliminate the use of the
Greybox modal, opting to move from page to page through the process.

Tangentially related: I updated the DataTables table configuration of
the tables on the label batch management page and label batch edit page
in order to remove the DataTables "Export" button because of the
possibility that its presence might be confusing.

To test apply the patch and go to Cataloging -> Label creator.

- Create more than one batch  add multiple items to each.
- From the label batches page, test the process of exporting labels,
  observing at each step the page title and breadcrumbs.
  - Check a box next to a single batch and click the "Export selected"
    button at the bottom.
  - Check multiple boxes and click "Export selected."
  - Click "Edit" on one of the batches
    - In the list of items, check one or more checkboxes, and click
      "Export select items."
    - Click an individual "Export" button from the list of items.
    - Click "Export full batch"
- In each case, you should be forwarded to a new page for choosing label
  options.
  - After submitting the form, you should be forwarded to another page
    where you have options for downloading the batch as a PDF, CSV, or
    XML.
- Test the new "Return to label batches" to confirm that it takes you to
  the label batches page.

Sponsored-by: Athens County Public Libraries
Comment 2 Caroline Cyr La Rose 2025-07-14 18:54:20 UTC
Created attachment 184062 [details] [review]
Bug 40366: Update the label export process to avoid Greybox modal

This patch updates the label export process to eliminate the use of the
Greybox modal, opting to move from page to page through the process.

Tangentially related: I updated the DataTables table configuration of
the tables on the label batch management page and label batch edit page
in order to remove the DataTables "Export" button because of the
possibility that its presence might be confusing.

To test apply the patch and go to Cataloging -> Label creator.

- Create more than one batch  add multiple items to each.
- From the label batches page, test the process of exporting labels,
  observing at each step the page title and breadcrumbs.
  - Check a box next to a single batch and click the "Export selected"
    button at the bottom.
  - Check multiple boxes and click "Export selected."
  - Click "Edit" on one of the batches
    - In the list of items, check one or more checkboxes, and click
      "Export select items."
    - Click an individual "Export" button from the list of items.
    - Click "Export full batch"
- In each case, you should be forwarded to a new page for choosing label
  options.
  - After submitting the form, you should be forwarded to another page
    where you have options for downloading the batch as a PDF, CSV, or
    XML.
- Test the new "Return to label batches" to confirm that it takes you to
  the label batches page.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Owen Leonard 2025-07-16 17:47:42 UTC
Created attachment 184162 [details] [review]
Bug 40366: (follow-up) Remove inclusion of greybox.inc
Comment 4 Caroline Cyr La Rose 2025-07-16 18:20:57 UTC
Created attachment 184169 [details] [review]
Bug 40366: (follow-up) Remove inclusion of greybox.inc

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>