Bug 40412 - Update the patron card export process to avoid Greybox modal
Summary: Update the patron card export process to avoid Greybox modal
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 40422
  Show dependency treegraph
 
Reported: 2025-07-16 12:14 UTC by Owen Leonard
Modified: 2025-07-16 18:27 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40412: Update the patron card export process to avoid Greybox modal (10.31 KB, patch)
2025-07-16 12:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40412: Update the patron card export process to avoid Greybox modal (10.38 KB, patch)
2025-07-16 13:36 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 40412: (follow-up) Remove inclusion of greybox.inc (843 bytes, patch)
2025-07-16 17:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40412: (follow-up) Remove inclusion of greybox.inc (914 bytes, patch)
2025-07-16 18:27 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-07-16 12:14:50 UTC
I propose that we update the patron card export process in order to avoid using a Greybox modal. We can just as easily move from page to page as the process progresses.
Comment 1 Owen Leonard 2025-07-16 12:33:21 UTC
Created attachment 184149 [details] [review]
Bug 40412: Update the patron card export process to avoid Greybox modal

This patch updates the patron card export process to eliminate the use
of the Greybox modal, opting to move from page to page through the
process.

Tangentially related: I updated the DataTables table configuration of
the tables on the patron card batch management page and patron card
batch edit page in order to remove the DataTables "Export" button
because of the possibility that its presence might be confusing.

To test apply the patch and go to Tools -> Patron card creator.

- Create more than one batch add multiple patrons to each.
- From the patron card batches page, test the process of exporting
  patron cards, observing at each step the page title and breadcrumbs.
  - Check a box next to a single batch and click the "Export selected
    batches" button at the bottom.
  - Check multiple boxes and click "Export selected batches."
  - Click "Edit" on one of the batches
    - In the list of patrons, check one or more checkboxes, and click
      "Export selected card(s)."
    - Click an individual "Export" button from the list of patrons.
    - Click "Export card batch".
  - Select a list from the "Patron list" dropdown and click "Export from
    patron list."
- In each case, you should be forwarded to a new page for choosing
  patron card options.
  - After submitting the form, you should be forwarded to another page
    where you can download the batch as a PDF.
- Test the new "Return to patron card batches" to confirm that it takes
  you to the patron card batches page.

Sponsored-by: Athens County Public Libraries
Comment 2 Caroline Cyr La Rose 2025-07-16 13:36:49 UTC
Created attachment 184150 [details] [review]
Bug 40412: Update the patron card export process to avoid Greybox modal

This patch updates the patron card export process to eliminate the use
of the Greybox modal, opting to move from page to page through the
process.

Tangentially related: I updated the DataTables table configuration of
the tables on the patron card batch management page and patron card
batch edit page in order to remove the DataTables "Export" button
because of the possibility that its presence might be confusing.

To test apply the patch and go to Tools -> Patron card creator.

- Create more than one batch add multiple patrons to each.
- From the patron card batches page, test the process of exporting
  patron cards, observing at each step the page title and breadcrumbs.
  - Check a box next to a single batch and click the "Export selected
    batches" button at the bottom.
  - Check multiple boxes and click "Export selected batches."
  - Click "Edit" on one of the batches
    - In the list of patrons, check one or more checkboxes, and click
      "Export selected card(s)."
    - Click an individual "Export" button from the list of patrons.
    - Click "Export card batch".
  - Select a list from the "Patron list" dropdown and click "Export from
    patron list."
- In each case, you should be forwarded to a new page for choosing
  patron card options.
  - After submitting the form, you should be forwarded to another page
    where you can download the batch as a PDF.
- Test the new "Return to patron card batches" to confirm that it takes
  you to the patron card batches page.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Owen Leonard 2025-07-16 17:49:49 UTC
Created attachment 184163 [details] [review]
Bug 40412: (follow-up) Remove inclusion of greybox.inc
Comment 4 Caroline Cyr La Rose 2025-07-16 18:27:39 UTC
Created attachment 184170 [details] [review]
Bug 40412: (follow-up) Remove inclusion of greybox.inc

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>