With Bug 29393 the ability to send emails from patron details page was introduced. This is a great feature, but the subject should be a mandatory field. to reproduce: - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - fill the body / message manually but leave the subject emty - Save - Check the message in the patrons notices cgi-bin/koha/members/notices.pl?borrowernumber=xxxxx
Created attachment 184446 [details] [review] Bug 40431: Make subject required for emails in Add message modal Test Plan: 1. Apply patch 2. Go to patron's detail page 3. Click "Add message" in tools bar 4. Fill the body, but leave the subject empty 5. Notice it requires you to fill out subject before saving
Created attachment 184450 [details] [review] Bug 40431: Make subject required for emails in Add message modal Test Plan: 1. Apply patch 2. Go to patron's detail page 3. Click "Add message" in tools bar 4. Fill the body, but leave the subject empty 5. Notice it requires you to fill out subject before saving Signed-off-by: David Flater <flaterdavid@gmail.com>
Please explain: <li class="form-group form-row" id="subject_form" style="display: none;"> <label for="borrower_subject" class="col-form-label">Subject:</label> - <input type="text" size="60" name="borrower_subject" class="form-control" id="borrower_subject" /> + <input type="text" size="60" name="borrower_subject" class="form-control" id="borrower_subject" required="required" /> The field is not displayed but required ? Changing status for need of feedback.