Bug 40540 - OPAC generates warnings in logs when no results are found
Summary: OPAC generates warnings in logs when no results are found
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Janusz Kaczmarek
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 25790
  Show dependency treegraph
 
Reported: 2025-07-29 09:44 UTC by Janusz Kaczmarek
Modified: 2025-08-22 08:30 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.03
Circulation function:


Attachments
Bug 40540: OPAC generates warnings in logs when no results are found (2.05 KB, patch)
2025-07-29 09:51 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 40540: OPAC generates warnings in logs when no results are found (2.10 KB, patch)
2025-07-29 15:31 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 40540: OPAC generates warnings in logs when no results are found (2.20 KB, patch)
2025-08-01 07:39 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2025-07-29 09:44:19 UTC
When no results are found, a warning:

[WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 76.

is generated in [plack-]opac-error.log
Comment 1 Janusz Kaczmarek 2025-07-29 09:51:03 UTC
Created attachment 184788 [details] [review]
Bug 40540: OPAC generates warnings in logs when no results are found

When no results are found, a warning:

[WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 76.

is generated in [plack-]opac-error.log

Test plan:
==========
1. In OPAC, perform a search for a random string of characters to get no
   results.
2. Check plack-opac-error.log. You should see a warning as above.
3. Apply the patch ; restart_all.
4. Repeat the search. Check the log -- there should be no new warning.

Sponsored-by: Ignatianum University in Cracow
Comment 2 Roman Dolny 2025-07-29 15:31:27 UTC
Created attachment 184824 [details] [review]
Bug 40540: OPAC generates warnings in logs when no results are found

When no results are found, a warning:

[WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 76.

is generated in [plack-]opac-error.log

Test plan:
==========
1. In OPAC, perform a search for a random string of characters to get no
   results.
2. Check plack-opac-error.log. You should see a warning as above.
3. Apply the patch ; restart_all.
4. Repeat the search. Check the log -- there should be no new warning.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Marcel de Rooy 2025-08-01 07:39:03 UTC
Created attachment 184971 [details] [review]
Bug 40540: OPAC generates warnings in logs when no results are found

When no results are found, a warning:

[WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 76.

is generated in [plack-]opac-error.log

Test plan:
==========
1. In OPAC, perform a search for a random string of characters to get no
   results.
2. Check plack-opac-error.log. You should see a warning as above.
3. Apply the patch ; restart_all.
4. Repeat the search. Check the log -- there should be no new warning.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Lucas Gass (lukeg) 2025-08-01 19:25:26 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-08-22 08:30:29 UTC
Nice work everyone!

Pushed to 25.05.x