When you have more that one option in the BOOKING_CANCELLATION authorised value category, the options in the cancellation modal are hidden. You can still scroll, but it looks very weird. I think it may be because it's not a normal dropdown in the sense that you can still type in something and not just select. This differs from the usual Koha behaviour where if there is a list of authorised values, you can't type anything, and if there aren't authorised values, then it's a text field instead of a dropdown menu. This one tries to be both at once and maybe there is no style for that yet?? To recreate: 1. Make an item bookable 1.1. Go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 1.2. Go to the Items tab on the left side of the screen 1.3. Under Bookable, choose Yes and click 'Update' 2. Place a booking 2.1. Click 'Place booking' at the top of the detailed record screen 2.2. Fill out the form 2.3. Click 'Submit' 3. Try to cancel the booking 3.1. Go to the 'Bookings' tab on the left side of the screen 3.2. Click 'Cancel' next to the booking --> A modal appears with a text field for the cancellation reason 3.3. Click 'No, do not cancel' 4. Add one authorised value in BOOKING_CANCELLATION 4.1. Go to Administration > Authorized values 4.2. Search for BOOKING_CANCELLATION 4.3. Click 'Add' 4.4. Fill out the form 4.5. Click 'Save' 5. Redo step 3 --> The option appears over the text field -- OK 6. Add one or two more authorised values 7. Redo step 3 --> The option appear under the text field and are hidden by the modal footer
Hi Caroline, will take a look right away.
Created attachment 186779 [details] [review] Bug 40857: add context parameter for modal overlay - The combobox dropdown in modals scrolled with the modal body instead of overlaying, due to Bootstrap's overflow: hidden on modals clipping extending content. - Added context parameter to combobox config; setting context: 'modal' uses Popper's fixed positioning strategy for proper overlay. - For reference: https://popper.js.org/docs/v2/constructors/#strategy To test: 1. Make an item bookable 1.1. Go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 1.2. Go to the Items tab on the left side of the screen 1.3. Under Bookable, choose Yes and click 'Update' 2. Place a booking 2.1. Click 'Place booking' at the top of the detailed record screen 2.2. Fill out the form 2.3. Click 'Submit' 3. Try to cancel the booking 3.1. Go to the 'Bookings' tab on the left side of the screen 3.2. Click 'Cancel' next to the booking --> A modal appears with a text field for the cancellation reason 3.3. Click 'No, do not cancel' 4. Add one authorised value in BOOKING_CANCELLATION 4.1. Go to Administration > Authorized values 4.2. Search for BOOKING_CANCELLATION 4.3. Click 'Add' 4.4. Fill out the form 4.5. Click 'Save' 5. Redo step 3 --> The option appears as a dropdown below the text field -- OK 6. Add one or two more authorised values 7. Redo step 3 --> The options appear as a dropdown below the text field -- OK
Not sure whether we recently upgraded anything, but using the strategy option in the constructor for the modal context should fix it.
Created attachment 186800 [details] [review] Bug 40857: add context parameter for modal overlay - The combobox dropdown in modals scrolled with the modal body instead of overlaying, due to Bootstrap's overflow: hidden on modals clipping extending content. - Added context parameter to combobox config; setting context: 'modal' uses Popper's fixed positioning strategy for proper overlay. - For reference: https://popper.js.org/docs/v2/constructors/#strategy To test: 1. Make an item bookable 1.1. Go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 1.2. Go to the Items tab on the left side of the screen 1.3. Under Bookable, choose Yes and click 'Update' 2. Place a booking 2.1. Click 'Place booking' at the top of the detailed record screen 2.2. Fill out the form 2.3. Click 'Submit' 3. Try to cancel the booking 3.1. Go to the 'Bookings' tab on the left side of the screen 3.2. Click 'Cancel' next to the booking --> A modal appears with a text field for the cancellation reason 3.3. Click 'No, do not cancel' 4. Add one authorised value in BOOKING_CANCELLATION 4.1. Go to Administration > Authorized values 4.2. Search for BOOKING_CANCELLATION 4.3. Click 'Add' 4.4. Fill out the form 4.5. Click 'Save' 5. Redo step 3 --> The option appears as a dropdown below the text field -- OK 6. Add one or two more authorised values 7. Redo step 3 --> The options appear as a dropdown below the text field -- OK Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Paul!
For release maintainers, the cancellation reason was added in version 24.11. Please backport back to that version, if possible!
Created attachment 186883 [details] [review] Bug 40857: add context parameter for modal overlay - The combobox dropdown in modals scrolled with the modal body instead of overlaying, due to Bootstrap's overflow: hidden on modals clipping extending content. - Added context parameter to combobox config; setting context: 'modal' uses Popper's fixed positioning strategy for proper overlay. - For reference: https://popper.js.org/docs/v2/constructors/#strategy To test: 1. Make an item bookable 1.1. Go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 1.2. Go to the Items tab on the left side of the screen 1.3. Under Bookable, choose Yes and click 'Update' 2. Place a booking 2.1. Click 'Place booking' at the top of the detailed record screen 2.2. Fill out the form 2.3. Click 'Submit' 3. Try to cancel the booking 3.1. Go to the 'Bookings' tab on the left side of the screen 3.2. Click 'Cancel' next to the booking --> A modal appears with a text field for the cancellation reason 3.3. Click 'No, do not cancel' 4. Add one authorised value in BOOKING_CANCELLATION 4.1. Go to Administration > Authorized values 4.2. Search for BOOKING_CANCELLATION 4.3. Click 'Add' 4.4. Fill out the form 4.5. Click 'Save' 5. Redo step 3 --> The option appears as a dropdown below the text field -- OK 6. Add one or two more authorised values 7. Redo step 3 --> The options appear as a dropdown below the text field -- OK Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11