Although bug39011 have solved a lot of things regarding searching the items table on authorised_values, it was missing the items.location mapping. As far as I can tell there are no other missing coded_values.
Created attachment 187076 [details] [review] Bug 40904: Fix item search by shelving location on catalogue/details.pl Test plan : - before patch on ktd, go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=155 - in the holdings table search for "general" like "General Stacks". - see that no items appear - apply patch - repeat the search - all items appear now.
Created attachment 187095 [details] [review] Bug 40904: Fix item search by shelving location on catalogue/details.pl Test plan : - before patch on ktd, go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=155 - in the holdings table search for "general" like "General Stacks". - see that no items appear - apply patch - repeat the search - all items appear now. Signed-off-by: Mathieu <mathsabypro@gmail.com>
BZ 39011 was categorized as a bug fix and not an enhancement. I think the same should apply to this ticket. I tested it on a sandbox, it works, you can search for "general stacks" or "general." "Stacks" doesn't return any results, which may seem surprising, but that's how the filter already works for libraries and statuses following 39011, so that makes sense... But is this the desired behavior for this table or something that should be improved in subsequent bugs?
By the way I discovered an other issue while testing : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40907
Created attachment 187246 [details] [review] Bug 40904: Fix item search by shelving location on catalogue/details.pl Test plan : - before patch on ktd, go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=155 - in the holdings table search for "general" like "General Stacks". - see that no items appear - apply patch - repeat the search - all items appear now. Signed-off-by: Mathieu <mathsabypro@gmail.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Fixes the immediate issue so I passed QA, Bug 40907 still needs attention, though. But I think it's out of scope for this bug.
We should aim to improve on this: > But is this the desired behavior for this table or something that should be improved in subsequent bugs?
Nice work everyone! Pushed to main for 25.11
(In reply to Paul Derscheid from comment #6) > Fixes the immediate issue so I passed QA, Bug 40907 still needs attention, > though. But I think it's out of scope for this bug. Yep, have a look but parenthesis actually works but for regexp! as I told in 40907 I was not able to escape them though.
Nice work everyone! Pushed to 25.05.x
Fix the error of an enhancement (Bug 15461), not backported in 24.11.x.
Bug fix - no changes to the manual required.