We have to explicitly include the TT js-patron-format.inc in all the .tt files we are going to format a patron. It's also hard to use from JS files, which is a bit ridiculous.
Created attachment 187476 [details] [review] Bug 40958: Move patron_to_html to a standalone JS file It will be easier to reuse patron_to_html Test plan: Search for patron and confirm that that patron are formatted correctly. Global patron search and a couple of other places should be enough.
Created attachment 187533 [details] [review] Bug 40958: Move patron_to_html to a standalone JS file It will be easier to reuse patron_to_html Test plan: Search for patron and confirm that that patron are formatted correctly. Global patron search and a couple of other places should be enough. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Created attachment 187646 [details] [review] Bug 40958: Remove remaining occurrence in course_reserves/course.tt From bug 40699
Created attachment 188800 [details] [review] Bug 40958: Move patron_to_html to a standalone JS file It will be easier to reuse patron_to_html Test plan: Search for patron and confirm that that patron are formatted correctly. Global patron search and a couple of other places should be enough. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 188801 [details] [review] Bug 40958: Remove remaining occurrence in course_reserves/course.tt From bug 40699 Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Ignoring this: [FAIL] koha-tmpl/intranet-tmpl/prog/js/patron-format.js FAIL forbidden_patterns forbidden pattern: Use __("") instead of _("") (line 43) forbidden pattern: Use __("") instead of _("") (line 45) Processing additional checks PASS!
Created attachment 188866 [details] [review] Bug 40958: (follow-up) Fix QA complaint about forbidden pattern
Nice work everyone! Pushed to main for 25.11