Bug 41061 - No longer need to validate dates manually
Summary: No longer need to validate dates manually
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33703
Blocks:
  Show dependency treegraph
 
Reported: 2025-10-21 09:23 UTC by Jonathan Druart
Modified: 2025-10-21 09:27 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41061: Remove unused calendar JS functions (6.83 KB, patch)
2025-10-21 09:27 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-10-21 09:23:24 UTC
I've tried to resurrect bug 31149 but finally realised that this code is no longer needed.

I think it's coming from the introduction of Masikto by bug 33703.
Comment 1 Jonathan Druart 2025-10-21 09:27:04 UTC
Created attachment 188204 [details] [review]
Bug 41061: Remove unused calendar JS functions

Since the introduction of Maskito by bug 33703 we do no longer need to
valid dates when the flatpickr widget is closed.

This patch removes the following JS function from staff and OPAC:
* is_valid_date
* validate_date
* get_dateformat_str

Test plan:
0. Do not apply this patch and confirm that the date string received by
   those functions has already been correctly formatted
1. Apply the patch and git grep to make sure no occurrence exists in the
   code
2. Confirm that you are still able to select dates with flatpickr