On bug 39022 some foolhardy developer added a reverse of the previous_patrons array to correct a problem with the ordering on the page. This worked well when 1 previous patron was retained, but has the affect of shuffling the stored list with each addition when multiple are retained. To test: 1 - Write a report to get some patron SELECT cardnumber,surname FROM borrowers WHERE cardnumber <>'' ORDER BY rand() LIMit 6 2 - Enabled 'showLastPatron' and set count to 3 http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=showLastPatron 3 - Copy the barcodes in order from the report and search for them in patron search, you'll want two tabs so you can keep report open 4 - Notice at 4th patron that list order has changed 5 - When 5th patron is loaded, the 4th is removed from the list
Created attachment 188301 [details] [review] Bug 41074: Don't reverse previous_patrons arrary This patch alters the code to append instead of prepend, removing the need to reverse the list To test: 1 - Write a report to get some patron SELECT cardnumber,surname FROM borrowers WHERE cardnumber <>'' ORDER BY rand() LIMit 6 2 - Enabled 'showLastPatron' and set count to 3 http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=showLastPatron 3 - Copy the barcodes in order from the report and search for them in patron search, you'll want two tabs so you can keep report open 4 - Notice at 4th patron that list order has changed 5 - When 5th patron is loaded, the 4th is removed from the list 6 - Apply patch 7 - Clear the list 8 - Repeat the test plan, but note that list order does not change 9 - Confirm the patrons are removed from the list in expected order when adding new 10 - Change the count to 1 and search for several patrons, ensuring the last patron link is always correct
trivial, moving to QA
Created attachment 188402 [details] [review] Bug 41074: Don't reverse previous_patrons arrary This patch alters the code to append instead of prepend, removing the need to reverse the list To test: 1 - Write a report to get some patron SELECT cardnumber,surname FROM borrowers WHERE cardnumber <>'' ORDER BY rand() LIMit 6 2 - Enabled 'showLastPatron' and set count to 3 http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=showLastPatron 3 - Copy the barcodes in order from the report and search for them in patron search, you'll want two tabs so you can keep report open 4 - Notice at 4th patron that list order has changed 5 - When 5th patron is loaded, the 4th is removed from the list 6 - Apply patch 7 - Clear the list 8 - Repeat the test plan, but note that list order does not change 9 - Confirm the patrons are removed from the list in expected order when adding new 10 - Change the count to 1 and search for several patrons, ensuring the last patron link is always correct Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Nick Clemens (kidclamp) from comment #2) > trivial, moving to QA Trivial is a bit strong. Although this feature seems to be recent, its code is not very clear.
Nice work everyone! Pushed to main for 25.11