Bug 41076 - Perltidy config needs to be refined to not cause changes with perltidy 20250105
Summary: Perltidy config needs to be refined to not cause changes with perltidy 20250105
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 41077
  Show dependency treegraph
 
Reported: 2025-10-23 00:06 UTC by Victor Grousset/tuxayo
Modified: 2025-10-23 10:43 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2025-10-23 00:06:36 UTC
1. KOHA_IMAGE=main-bookworm ktd up
2. prove xt/perltidy.t
3. leave running for like a minute, it passes, don't bother with full run
4. KOHA_IMAGE=main-trixie ktd up
5. prove xt/perltidy.t
6. failures quickly pile up

D12:
perltidy --version
This is perltidy, v20230309
dpkg -l | grep tidy
20230309-1~koha3 (ours)

D13:
perltidy --version
This is perltidy, v20250105
dpkg -l | grep tidy
20250105-1

So in KTD, the D13 image doesn't ship our perltidy so it uses Debian's which is more recent. And might use some different default that aren't covered by our current config. I guess it would be better to complete the config so that both version of perltidy output the same code, right? Rather than making the D13 image ship an old version of perltidy which would postpone the root issue.
Comment 1 Victor Grousset/tuxayo 2025-10-23 00:09:34 UTC
Also, it makes the qa script fail if working on Debian 13
Comment 2 Jonathan Druart 2025-10-23 10:43:06 UTC
(In reply to Victor Grousset/tuxayo from comment #0)
> So in KTD, the D13 image doesn't ship our perltidy so it uses Debian's which
> is more recent. And might use some different default that aren't covered by
> our current config. I guess it would be better to complete the config so
> that both version of perltidy output the same code, right?

Yes, that is what needs to be done.