This is a bit of a curious case: When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. To test: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again, verify the items are NOT shown abvoe the item form => nothing would be batch edited.
Created attachment 188321 [details] [review] Bug 41082: Fix batch tools from reports when itemnumber col has been renamed Description from comment 0 When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. Test plan: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again => verify the items are shown above the item form
Heh, I suspect this is a case of a bug that will break some folks' workflows - there are some libraries that use this 'trick' to nix the data links and batch options.
But then they are exploiting a bug, I don't feel like we should account for that. The batch options are still showing, they are just broken. So it's not really nixed. You can just use itemnumber as XXXX if you want to nix.
Created attachment 188419 [details] [review] Bug 41082: Fix batch tools from reports when itemnumber col has been renamed Description from comment 0 When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. Test plan: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again => verify the items are shown above the item form Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Edit the patch to remove the change to yarn.lock which I assumed to be accidental.
(In reply to Owen Leonard from comment #5) > Edit the patch to remove the change to yarn.lock which I assumed to be > accidental. Yes, thank you!
Created attachment 188523 [details] [review] Bug 41082: Fix batch tools from reports when itemnumber col has been renamed Description from comment 0 When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. Test plan: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again => verify the items are shown above the item form Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
This change makes sense because batchMod.pl expects a multi param named itemnumber. Before this patch the batch_item_modification and batch_item_deletion forms' inputs for itemnumbers were being rendered with the renamed column as name attribute instead of just 'itemnumber'. Nice! Passing QA.
Nice work everyone! Pushed to main for 25.11