Bug 41100 - EDI vendor account port numbers no longer editable
Summary: EDI vendor account port numbers no longer editable
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 25.05
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall (khall)
QA Contact: Aleisha Amohia
URL:
Keywords: rel_25_05_candidate
Depends on:
Blocks:
 
Reported: 2025-10-24 18:50 UTC by Kyle M Hall (khall)
Modified: 2025-10-31 17:44 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes editing EDI account port numbers in Koha 25.05.x. When editing the port numbers for an account (Administration > Acquisition parameters > EDI accounts), the changes were not saved.
Version(s) released in:
Circulation function:


Attachments
Bug 41100: EDI vendor account port numbers no longer editable (2.22 KB, patch)
2025-10-24 18:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 41100: EDI vendor account port numbers no longer editable (2.25 KB, patch)
2025-10-25 21:14 UTC, David Nind
Details | Diff | Splinter Review
Bug 41100: EDI vendor account port numbers no longer editable (2.31 KB, patch)
2025-10-28 21:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2025-10-24 18:50:01 UTC
It seems that port numbers are stuck at 21. Editing them does not change the port number in the database.
Comment 1 Kyle M Hall (khall) 2025-10-24 18:52:06 UTC
Created attachment 188433 [details] [review]
Bug 41100: EDI vendor account port numbers no longer editable

It seems that port numbers are stuck at 21. Editing them does not change the port number in the database.

Test Plan:
1) Check out Koha 25.05
2) Try to edit an EDI vendor account port
3) Note the change doesn't save
4) Apply this patch
5) Restart all the things!
6) Note you can edit the port again!
Comment 2 David Nind 2025-10-25 21:14:02 UTC
Created attachment 188446 [details] [review]
Bug 41100: EDI vendor account port numbers no longer editable

It seems that port numbers are stuck at 21. Editing them does not change the port number in the database.

Test Plan:
1) Check out Koha 25.05
2) Try to edit an EDI vendor account port
3) Note the change doesn't save
4) Apply this patch
5) Restart all the things!
6) Note you can edit the port again!

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-10-25 21:17:23 UTC
Testing notes (using KTD):

1. I checked out Koha 25.05.x (git checkout 25.05.x), then in the .env for koha-testing-docker changed IMAGE=25.05, prune current images, then a ktd pull.

2. Enabled the EDIFACT system preference.
Comment 4 Aleisha Amohia 2025-10-28 21:01:48 UTC
Created attachment 188529 [details] [review]
Bug 41100: EDI vendor account port numbers no longer editable

It seems that port numbers are stuck at 21. Editing them does not change the port number in the database.

Test Plan:
1) Check out Koha 25.05
2) Try to edit an EDI vendor account port
3) Note the change doesn't save
4) Apply this patch
5) Restart all the things!
6) Note you can edit the port again!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>
Comment 5 Lucas Gass (lukeg) 2025-10-31 17:42:33 UTC
Can you rebase this on top of Bug 38489 please?
Comment 6 Lucas Gass (lukeg) 2025-10-31 17:44:06 UTC
Oh wait, this is not for main. My bad.