Hello all When a checkout is performed, the NoIssuesChargeGuarantees and NoIssuesChargeGuarantorsWithGuarantees values are checked. This is an ‘if’ statement with check values, but by default, these are empty strings and therefore defined in this way. I therefore believe that the verification is not exactly what we want, particularly when SIP performs the checkout without permission to force it. Furthermore, in kohastructure, the default value would be NULL from what I understand, and it has not been included in the syprefs sql file. Perhaps there are some cases that I am overlooking, but I will suggest a simple fix anyway.
I added Bug 39261 which also deals with the format of these sysprefs
Created attachment 189694 [details] [review] Bug 41265: Checks if NoIssuesChargeGuarantees && NoIssuesChargeGuarantorsWithGuarantees sysprefs limits are not empty Test plan: 1) Create relation between guarantor and guarantees 2) Be sure that one (or both) has outstanding charges 3) Be sure that concerning sysprefs are "empty" / not defined 4) Perform a checkout 5) A warning appears normally, you can fore checkout if you have enough permission 6) Apply this patch 7) Repeat step 4), no warning appears Sponsored-by: BibLibre