Bug 41271 - pod_coverage.t skips over files that fail silently
Summary: pod_coverage.t skips over files that fail silently
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-19 15:47 UTC by Pedro Amorim
Modified: 2025-11-19 16:24 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41271: Make pod_coverage.t die verbosely instead of silently (1.53 KB, patch)
2025-11-19 16:17 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-11-19 15:47:08 UTC

    
Comment 1 Pedro Amorim 2025-11-19 16:17:20 UTC
Created attachment 189713 [details] [review]
Bug 41271: Make pod_coverage.t die verbosely instead of silently

To test, ktd:
1) Rollback to commit before bug 37893:
   git reset --hard 3f59557d2ac
2) Apply this patch
3) Reset:
   reset_all
4) Run the pod_coverage.t test:
   prove -v /kohadevbox/koha/xt/author/pod_coverage.t

You get error:
"Module died while loading 'C4::SIP::SIPServer': Could not find pod_coverage.xml in /kohadevbox/koha/xt/author.
Comment 2 Pedro Amorim 2025-11-19 16:24:43 UTC
Hi all, I don't know what the fix should be here, but SIPServer.pm is seemingly being checked for pod_coverage.t, except it isn't. It's dying and pod_coverage.t skips over it.

Questions:
A) Should we push this patch (or similar)? To ensure that pod_coverage.t actually does its thing or dies verbosely.
B) Do we exclude SIPServer.pm from pod_coverage altogether? 
C) You can skip step 1) of the test plan in the patch (that was just to highlight that issue precedes bug 37893), and you'll still reproduce the issue, for SIPServer.pm (with latest bug 37893 follow-up applied but for the reason that it dies intentionally now) and for misc/translator/TmplTokenizer.pm:
Can't locate VerboseWarnings.pm