The Circulation Rules table is obscenely wide at this point. We've tried a number of approaches to a new UI in this area, and so far all have got stuck. I'm proposing a smaller impact resolution of just having a set of column groups for display to allow limiting the width of the table to only those fields of interest at the moment you're working.
Created attachment 190455 [details] [review] Bug 41439: Add column visibility toggles to circulation rules table The circulation rules table has become excessively wide with 40+ columns, making it difficult to navigate and use. This patch adds column visibility toggle buttons that allow users to focus on specific rule categories. Changes: - Add toggle buttons for: Checkouts, Due dates, Fines, Renewals, Holds, Article requests, Recalls, and Show all - Group columns into logical categories based on their function - Default to showing only Checkout columns on page load for a cleaner initial view - Highlight the active button to indicate current view - Disable search functionality (not appropriate for this table) - Calculate column indices dynamically based on enabled system preferences (UnseenRenewals, ArticleRequests, UseRecalls) Test plan: 1. Navigate to Administration > Circulation and fine rules 2. Observe the table now shows only checkout-related columns by default with the "Checkouts" button highlighted 3. Click different category buttons (Fines, Renewals, Holds, etc.) and verify only relevant columns are shown 4. Verify the active button is highlighted in blue 5. Click "Show all" to display all columns 6. Verify the layout works with different system preference combinations (enable/disable ArticleRequests, UseRecalls, UnseenRenewals)
Created attachment 190456 [details] Proof of concept
This is just a proof of concept for now and will need testing to ensure it fully works with form submission etc.. I've only quickly trials the 'look'. Setting to Needs Signoff to trigger some feedback.. whilst I do want some feedback and any suggestions of other approaches, lets try to stick to simple solutions for now to limit the scope.. I still think longer term we'll want to re-write this page in Vue with a possibly very different overall UI but that's for another bug.
Created attachment 190459 [details] [review] Bug 41439: Add column visibility toggles to circulation rules table The circulation rules table has become excessively wide with 40+ columns, making it difficult to navigate and use. This patch adds column visibility toggle buttons that allow users to focus on specific rule categories. Changes: - Add data-colname attributes to all table headers and footers for robust column identification - Add toggle buttons for: Checkouts, Due dates, Fines, Renewals, Holds, Article requests, Recalls, and Show all - Group columns into logical categories based on their function - Use column name selectors instead of fragile index-based selection for maintainability - Default to showing only Checkout columns on page load for a cleaner initial view - Highlight the active button to indicate current view - Disable search functionality (not appropriate for this table) - Handle dynamic column visibility based on system preferences (UnseenRenewals, ArticleRequests, UseRecalls) Test plan: 1. Navigate to Administration > Circulation and fine rules 2. Observe the table now shows only checkout-related columns by default with the "Checkouts" button highlighted 3. Click different category buttons (Fines, Renewals, Holds, etc.) and verify only relevant columns are shown 4. Verify the active button is highlighted in blue 5. Click "Show all" to display all columns 6. Verify the layout works with different system preference combinations (enable/disable ArticleRequests, UseRecalls, UnseenRenewals) 7. Verify column visibility persists correctly when system preferences are changed