Bug 41446 - xt/find-missing-new-lines-at-the-end-of-file.t - doesn't check .pref files for missing new line at the end of the file
Summary: xt/find-missing-new-lines-at-the-end-of-file.t - doesn't check .pref files fo...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-14 06:13 UTC by David Nind
Modified: 2025-12-14 06:13 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2025-12-14 06:13:12 UTC
Bug 40541 added tests to check for files that are missing a new line at the end of file.

It does not check the .pref files in 
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences

When running the qa check for bug 41427 (before the follow-up patch), it generated a QA warning "Missing new line at the end of file, make sure your editor correctly reads .editorconfig ('insert_final_newline = true'). See bug 40541.".

I think there are also two additional preference files that do not have a new line at the file:
- cataloguing.pref
- interlibrary-loans.pref

The qa script generates a warning if you make changes to the files (and if, for whatever reason, you have an editor that doesn't have insert_final_newline = true set).

Should xt/find-missing-new-lines-at-the-end-of-file.t check .pref files as well?