Bug 41521 - WebService::ILS::OverDrive not passing pl_valid
Summary: WebService::ILS::OverDrive not passing pl_valid
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 40680
Blocks: 41077
  Show dependency treegraph
 
Reported: 2026-01-05 12:56 UTC by Jonathan Druart
Modified: 2026-01-05 22:07 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-01-05 12:56:53 UTC
From bug 40680 comment 23

Those patches fix most of the issues.

Remaining ones:

not ok 455 - Koha/ExternalContent/OverDrive.pm has syntax warnings. 
#   Failed test 'Koha/ExternalContent/OverDrive.pm has syntax warnings.' 
#   at xt/pl_valid.t line 63. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. 
 
 
 
not ok 2266 - opac/external/overdrive/auth.pl has syntax warnings. 
#   Failed test 'opac/external/overdrive/auth.pl has syntax warnings.' 
#   at xt/pl_valid.t line 63. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. 
 
 
not ok 2356 - opac/svc/overdrive has syntax warnings. 
#   Failed test 'opac/svc/overdrive has syntax warnings.' 
#   at xt/pl_valid.t line 63. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. 
# Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. 

Test plan:
Startup ktd using trixie's image
export DB_IMAGE=mariadb:latest;
export KOHA_IMAGE=main-trixie;
ktd pull && ktd down && ktd --selenium --es7 up 
Run prove xt/pl_valid.t
Comment 1 Jonathan Druart 2026-01-05 12:58:59 UTC
Do we embed WebService::ILS::OverDrive in Koha (under lib)?

At least for a quick solution, and maybe improve the situation later.
Comment 2 David Cook 2026-01-05 22:07:53 UTC
(In reply to Jonathan Druart from comment #1)
> Do we embed WebService::ILS::OverDrive in Koha (under lib)?
> 
> At least for a quick solution, and maybe improve the situation later.

Yeah, I think that's probably going to be the only viable option for now.