From bug 40680 comment 23 Those patches fix most of the issues. Remaining ones: not ok 455 - Koha/ExternalContent/OverDrive.pm has syntax warnings. # Failed test 'Koha/ExternalContent/OverDrive.pm has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. not ok 2266 - opac/external/overdrive/auth.pl has syntax warnings. # Failed test 'opac/external/overdrive/auth.pl has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. not ok 2356 - opac/svc/overdrive has syntax warnings. # Failed test 'opac/svc/overdrive has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. Test plan: Startup ktd using trixie's image export DB_IMAGE=mariadb:latest; export KOHA_IMAGE=main-trixie; ktd pull && ktd down && ktd --selenium --es7 up Run prove xt/pl_valid.t
Do we embed WebService::ILS::OverDrive in Koha (under lib)? At least for a quick solution, and maybe improve the situation later.
(In reply to Jonathan Druart from comment #1) > Do we embed WebService::ILS::OverDrive in Koha (under lib)? > > At least for a quick solution, and maybe improve the situation later. Yeah, I think that's probably going to be the only viable option for now.