Same as bug 38190.
Created attachment 191026 [details] [review] Bug 41545: Remove JS warning "redeclaration of let filters_options" On the suggestions page more than one patron search is injected into the page that leads to JS warnings when the JS variable is defined with "let". We should use "var" in this case. Test plan: /cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode=CPL And notice that the warning does no longer appear when this patch is applied.
Created attachment 191038 [details] [review] Bug 41545: Remove JS warning "redeclaration of let filters_options" On the suggestions page more than one patron search is injected into the page that leads to JS warnings when the JS variable is defined with "let". We should use "var" in this case. Test plan: /cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode=CPL And notice that the warning does no longer appear when this patch is applied. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Go to Acquisitions > Suggestions 2. Use your web browser developer tools and have the console visible 3. Create a new suggestion: + New purchase suggestion 4. Note the warning in the console: Uncaught SyntaxError: Identifier 'filters_options' has already been declared 5. Apply the patch 6. Refresh the page 7. Note that there is no longer a warning
Created attachment 191516 [details] [review] Bug 41545: Remove JS warning "redeclaration of let filters_options" On the suggestions page more than one patron search is injected into the page that leads to JS warnings when the JS variable is defined with "let". We should use "var" in this case. Test plan: /cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode=CPL And notice that the warning does no longer appear when this patch is applied. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
This works to fix the error: Uncaught SyntaxError: Identifier 'filters_options' has already been declared. It makes sense to change the declaration to var if patron-search.inc is included in the page. When testing I noticed another odd js error is sometimes logged to the console within the Select manager modal, but it seems to be Chrome specific and only when selecting a value from autofill in the search field. Uncaught ReferenceError: code is not defined But that is a different and very strange bug, so I am passing QA on this.
Nice work everyone! Pushed to main for 26.05
Thanks all, pushed to 25.11.x