There's some incorrect HTML which is causing a lot of whitespace to appear on http://localhost:8080/cgi-bin/koha/sci/sci-main.pl which looks very broken
Created attachment 191541 [details] [review] Bug 41646: Fix HTML display for self-checkin This change moves the wrapper so that the web page display correctly Test plan: 0. Apply the patch 1. Enable the SelfCheckInModule system preference 2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl 3. Note that there isn't a lot of whitespace between the word "koha" and "Self check-in" 4. Celebrate
Created attachment 191543 [details] [review] Bug 41646: Fix HTML display for self-checkin This change moves the wrapper so that the web page display correctly Test plan: 0. Apply the patch 1. Enable the SelfCheckInModule system preference 2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl 3. Note that there isn't a lot of whitespace between the word "koha" and "Self check-in" 4. Celebrate Signed-off-by: David Nind <david@davidnind.com>
I'm sure I signed off a similar bug sometime in the last month or two, but for the life of me I can't find it! 8-)
(In reply to David Nind from comment #3) > I'm sure I signed off a similar bug sometime in the last month or two, but > for the life of me I can't find it! 8-) It might've been bug 41144 but I think it has some errors in it. (This one technically might too but it is a very simple fix for a very obvious problem.)
I think that was it! Thanks for finding it.