Bug 41646 - Self-checkin displaying too much whitespace due to incorrect HTML
Summary: Self-checkin displaying too much whitespace due to incorrect HTML
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low blocker
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 41144 41647
  Show dependency treegraph
 
Reported: 2026-01-16 04:24 UTC by David Cook
Modified: 2026-02-16 15:45 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes a large section of white space between the page header and the actual form on the OPAC self check-in page, which was positioned near the bottom of the page.
Version(s) released in:
26.05.00,25.11.02
Circulation function:


Attachments
Bug 41646: Fix HTML display for self-checkin (30.01 KB, patch)
2026-01-16 04:27 UTC, David Cook
Details | Diff | Splinter Review
Bug 41646: Fix HTML display for self-checkin (30.06 KB, patch)
2026-01-16 04:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 41646: Fix HTML display for self-checkin (30.11 KB, patch)
2026-01-21 15:12 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2026-01-16 04:24:10 UTC
There's some incorrect HTML which is causing a lot of whitespace to appear on http://localhost:8080/cgi-bin/koha/sci/sci-main.pl which looks very broken
Comment 1 David Cook 2026-01-16 04:27:14 UTC
Created attachment 191541 [details] [review]
Bug 41646: Fix HTML display for self-checkin

This change moves the wrapper so that the web page display correctly

Test plan:
0. Apply the patch
1. Enable the SelfCheckInModule system preference
2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl
3. Note that there isn't a lot of whitespace between
the word "koha" and "Self check-in"
4. Celebrate
Comment 2 David Nind 2026-01-16 04:48:01 UTC
Created attachment 191543 [details] [review]
Bug 41646: Fix HTML display for self-checkin

This change moves the wrapper so that the web page display correctly

Test plan:
0. Apply the patch
1. Enable the SelfCheckInModule system preference
2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl
3. Note that there isn't a lot of whitespace between
the word "koha" and "Self check-in"
4. Celebrate

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2026-01-16 04:49:58 UTC
I'm sure I signed off a similar bug sometime in the last month or two, but for the life of me I can't find it! 8-)
Comment 4 David Cook 2026-01-16 04:53:27 UTC
(In reply to David Nind from comment #3)
> I'm sure I signed off a similar bug sometime in the last month or two, but
> for the life of me I can't find it! 8-)

It might've been bug 41144 but I think it has some errors in it. (This one technically might too but it is a very simple fix for a very obvious problem.)
Comment 5 David Nind 2026-01-16 05:16:04 UTC
I think that was it! Thanks for finding it.
Comment 6 Nick Clemens (kidclamp) 2026-01-21 15:12:18 UTC
Created attachment 191790 [details] [review]
Bug 41646: Fix HTML display for self-checkin

This change moves the wrapper so that the web page display correctly

Test plan:
0. Apply the patch
1. Enable the SelfCheckInModule system preference
2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl
3. Note that there isn't a lot of whitespace between
the word "koha" and "Self check-in"
4. Celebrate

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Lucas Gass (lukeg) 2026-01-22 16:28:13 UTC
Nice work everyone!

Pushed to main for 26.05
Comment 8 Jacob O'Mara 2026-02-16 15:45:33 UTC
Thanks all, pushed to 25.11.x