Bug 41144 - Fix markup errors in self checkout and self checkin templates
Summary: Fix markup errors in self checkout and self checkin templates
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 21266 41646
Blocks: 41113
  Show dependency treegraph
 
Reported: 2025-10-30 14:48 UTC by Owen Leonard
Modified: 2026-01-20 23:27 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41144: Fix markup errors in self checkout and self checkin templates (90.31 KB, patch)
2025-10-30 15:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41144: Fix markup errors in self checkout and self checkin templates (90.34 KB, patch)
2025-12-08 23:20 UTC, David Nind
Details | Diff | Splinter Review
Bug 41144: Fix markup errors in self checkout and self checkin templates (90.34 KB, patch)
2025-12-09 00:46 UTC, David Nind
Details | Diff | Splinter Review
Bug 41144: Fix markup errors in self checkout and self checkin templates (18.42 KB, patch)
2026-01-20 17:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41144: (follow-up) Tidy (85.98 KB, patch)
2026-01-20 17:43 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-10-30 14:48:50 UTC
The W3C HTML validator complains of a number of minor issues in the self checkout and self checkin templates which should be addressed.
Comment 1 Owen Leonard 2025-10-30 15:43:52 UTC
Created attachment 188665 [details] [review]
Bug 41144: Fix markup errors in self checkout and self checkin templates

This patch fixes several markup errors in the self checkout and self
checkin templates, for example:

- Missing <fieldset>s (<legend> must be inside one)
- Stray ending </div>
- Missing <tr>

The patch also makes some changes to bring masthead-sci.inc and
masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in
sco-main.tt.

To test, apply the patch and if necessary enable both self checkout
(WebBasedSelfCheck) and self checkin (SelfCheckInModule).

- Go to the self-checkout page and log in
- View source and copy the markup into the validator:
  https://validator.w3.org/#validate-by-input
- The only error you see should be one about a duplicate ID "langmenu"
  which is outside the scope of this patch.
- Perform the same test with the self checkin page.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-12-08 23:20:07 UTC Comment hidden (obsolete)
Comment 3 David Nind 2025-12-08 23:21:58 UTC
Hope I tested this correctly.

Testing notes (using KTD and Firefox Developer EDition):

1. System preferences:
   - WebBasedSelfCheck: enabled by default in KTD
   - SelfCheckInModule: need to enable
2. URL for the self check-out module: 127.0.0.1:8080//cgi-bin/koha/sco/sco-main.pl
   - Only INFO messages after the patch (login page and after login)
3. URL for self check-in module: 127.0.0.1:8080/cgi-bin/koha/sci/sci-main.pl 
   - Only INFO messages after patch
Comment 4 David Nind 2025-12-09 00:46:08 UTC
Created attachment 190320 [details] [review]
Bug 41144: Fix markup errors in self checkout and self checkin templates

This patch fixes several markup errors in the self checkout and self
checkin templates, for example:

- Missing <fieldset>s (<legend> must be inside one)
- Stray ending </div>
- Missing <tr>

The patch also makes some changes to bring masthead-sci.inc and
masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in
sco-main.tt.

To test, apply the patch and if necessary enable both self checkout
(WebBasedSelfCheck) and self checkin (SelfCheckInModule).

- Go to the self-checkout page and log in
- View source and copy the markup into the validator:
  https://validator.w3.org/#validate-by-input
- The only error you see should be one about a duplicate ID "langmenu"
  which is outside the scope of this patch.
- Perform the same test with the self checkin page.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-12-09 00:46:38 UTC
My sign-off line was incorrect, so have updated.
Comment 6 David Cook 2026-01-16 04:19:41 UTC
This is going to have some conflicts with bug 41645 I reckon but it's important to fix these. 

The self-checkin looks so busted right now...
Comment 7 David Cook 2026-01-16 04:22:00 UTC
Hmm I'm pretty sure this is wrong. The <header> is supposed to be within the wrapper div...
Comment 8 David Cook 2026-01-16 04:29:50 UTC
(In reply to David Cook from comment #7)
> Hmm I'm pretty sure this is wrong. The <header> is supposed to be within the
> wrapper div...

Yeah looking at koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc I can see that the wrapper encapsulates the header.
Comment 9 Owen Leonard 2026-01-20 17:43:00 UTC
Created attachment 191715 [details] [review]
Bug 41144: Fix markup errors in self checkout and self checkin templates

This patch fixes several markup errors in the self checkout and self
checkin templates, for example:

- Missing <fieldset>s (<legend> must be inside one)
- Stray ending </div>
- Missing <tr>

The patch also makes some changes to bring masthead-sci.inc and
masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in
sco-main.tt.

Unrelated: Minor markup changes to langmenu.inc in order to fix HTML
validation errors.

To test, apply the patch and if necessary enable both self checkout
(WebBasedSelfCheck) and self checkin (SelfCheckInModule).

- Go to the self-checkout page and log in
- View source and copy the markup into the validator:
  https://validator.w3.org/#validate-by-input
- Perform the same test with the self checkin page.

Sponsored-by: Athens County Public Libraries
Comment 10 Owen Leonard 2026-01-20 17:43:03 UTC
Created attachment 191716 [details] [review]
Bug 41144: (follow-up) Tidy
Comment 11 David Cook 2026-01-20 23:27:20 UTC
I think this latest patch has duplicate wrapper divs?
Comment 12 David Cook 2026-01-20 23:27:32 UTC
Quick question: I thought we weren't doing separate tidy patches these days?