The W3C HTML validator complains of a number of minor issues in the self checkout and self checkin templates which should be addressed.
Created attachment 188665 [details] [review] Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing <fieldset>s (<legend> must be inside one) - Stray ending </div> - Missing <tr> The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - The only error you see should be one about a duplicate ID "langmenu" which is outside the scope of this patch. - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries
Created attachment 190315 [details] [review] Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing <fieldset>s (<legend> must be inside one) - Stray ending </div> - Missing <tr> The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - The only error you see should be one about a duplicate ID "langmenu" which is outside the scope of this patch. - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <you@example.com>
Hope I tested this correctly. Testing notes (using KTD and Firefox Developer EDition): 1. System preferences: - WebBasedSelfCheck: enabled by default in KTD - SelfCheckInModule: need to enable 2. URL for the self check-out module: 127.0.0.1:8080//cgi-bin/koha/sco/sco-main.pl - Only INFO messages after the patch (login page and after login) 3. URL for self check-in module: 127.0.0.1:8080/cgi-bin/koha/sci/sci-main.pl - Only INFO messages after patch
Created attachment 190320 [details] [review] Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing <fieldset>s (<legend> must be inside one) - Stray ending </div> - Missing <tr> The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - The only error you see should be one about a duplicate ID "langmenu" which is outside the scope of this patch. - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
My sign-off line was incorrect, so have updated.