Damaged status on items (952$4) seems to allow items to be selected for reserve. This happens both when the barcode is checked in and when the hold queue report is generated.
Preferred behavior (open for discussion, of course) would be for damaged status to disallow reserves on items marked "Damaged," similar to items with a "Missing" status (though missing clears the status on checkin, we would NOT want that behavior for Damaged. It should be a manual status change).
Created attachment 3579 [details] [review]
Patch for holds queue report generation
This patch changes the holds queue build process in order to require that items not be damaged in order to appear in the holds queue report.
This patch does not prevent damaged items from triggering the hold confirmation prompt upon check-in. I think perhaps we should not disallow damaged items from triggering the hold confirmation prompt, but rather add a warning to the check-in screen that the item is damaged. Then the librarian can choose whether to let the item circulate again (not too damaged) or set the item aside and ignore the hold prompt. If the librarian ignored the prompt, the hold would either go to the next available copy or would remain until the damaged copy was repaired.
I think this should be controlled by AllowHoldsOnDamagedItems sys pref?
This will work as long as Koha applies any hold policies and restrictions when holds are placed, but also when items are checked out and checked in.
Created attachment 3581 [details] [review]
Revision adds a check for the AllowHoldsOnDamagedItems preference to determine whether a damaged item should be included in the holds queue report.
> This will work as long as Koha applies any hold policies and restrictions when
> holds are placed, but also when items are checked out and checked in.
Beverly, can you elaborate?
I just did a test on 3.2 database which has 3 branches. I set up a default hold policy for all branches which specified that the "From home library" policy applies to DVDs. I then placed a hold on a DVD title for a patron registered at branch #1 and a second hold for a patron at branch #2. When I checked in the item belonging to branch #2 at branch #2, Koha wanted to use this item to fill the hold for the patron at branch #1. This means that Koha is not applying the hold policies when items are checked in. The same thing happens if I try to check out the item belonging to branch #2 to a patron registered at branch #1 -- Koha tries to fill the hold for the patron at branch #1.
Those may be valid issues, but they don't seem to be related to this bug. I suggest filing a new bug with these details.
Signed off patch not attached, and not on list
Pushed, please test
This bug is mentioned in:
Partial fix for Bug 4870, Damaged status does not prevent items from being selected for reserves http://lists.koha-community.org/pipermail/koha-patches/2011-March/014404.html
Partial fix for Bug 4870, Damaged status does not prevent items from being selected for reserves http://lists.koha-community.org/pipermail/koha-patches/2011-March/014406.html
Released in 3.4.0