Bug 5240 - next link hidden on edit subfields
Summary: next link hidden on edit subfields
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: cgi-bin/koha/admin/marc_subfields_str...
Keywords:
Depends on:
Blocks: 5658
  Show dependency treegraph
 
Reported: 2010-09-22 17:47 UTC by Nicole C. Engard
Modified: 2012-10-25 23:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
next link (15.18 KB, image/png)
2010-09-22 17:47 UTC, Nicole C. Engard
Details
Proposed fix (3.54 KB, patch)
2010-10-04 15:12 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-09-22 17:47:20 UTC
Created attachment 2642 [details]
next link

When you're on the frameworks editor and you're editing subfields, if there are too many subfields they go on to another page, but the Next link is below the Edit button and gets lost.  Either all subfields should be on the one page or the next button should be clearer
Comment 1 Owen Leonard 2010-10-04 15:12:52 UTC
Created attachment 2663 [details] [review]
Proposed fix

This patch removes the pagination altogether, displaying
everything on one page. It also moves some HTML out of the
script and into the template.
Comment 2 Nicole C. Engard 2010-10-04 15:24:54 UTC
Thanks, I've signed off on this.
Comment 3 MJ Ray (software.coop) 2010-11-19 16:35:37 UTC
This bug is mentioned in:
Fix for Bug 5240 - next link hidden on edit	subfields http://lists.koha-community.org/pipermail/koha-patches/2010-October/012608.html
Fix for Bug 5240 - next link	hidden on edit subfields http://lists.koha-community.org/pipermail/koha-patches/2010-October/012610.html
Comment 4 Chris Cormack 2010-11-22 00:45:22 UTC
Pushed to branch new/bug_5240  please test and report back if looks safe to merge
Comment 5 Chris Cormack 2010-12-13 08:54:03 UTC
new/bug_5240 is still awaiting testing
Comment 6 Chris Cormack 2011-01-09 20:17:13 UTC
Merged, I have done some testing, but I would like someone to test more and mark resolved, or say if it fails
Comment 7 Nicole C. Engard 2011-01-11 15:59:28 UTC
This appears to be working perfectly! It's not something you see often, cause there weren't many fields will too many subfields.
Comment 8 Katrin Fischer 2011-07-07 22:18:50 UTC
Tested on current master and works perfectly. Marking resolved fixed.