Bug 5658 - can't delete subfields in frameworks
Summary: can't delete subfields in frameworks
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) critical (vote)
Assignee: Fridolin Somers
QA Contact: Bugs List
URL:
Keywords:
: 6327 (view as bug list)
Depends on: 5240
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-26 03:56 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.21 KB, patch)
2011-05-23 12:12 UTC, Frédéric Demians
Details | Diff | Splinter Review
Proposed patch (link into TT) (2.04 KB, patch)
2011-05-23 12:45 UTC, Fridolin Somers
Details | Diff | Splinter Review
Signed-off patch with Fridolyn fix (2.24 KB, patch)
2011-05-23 15:00 UTC, Frédéric Demians
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-01-26 03:56:20 UTC
I tried today on two installs of HEAD to delete a subfield from a framework and nothing happened. I didn't get any error messages and I didn't see it get deleted.
Comment 1 Nicole C. Engard 2011-05-18 20:38:36 UTC
This is still an issue and it's critical that we be able to edit our frameworks - I think it's just a TT issue.
Comment 2 Frédéric Demians 2011-05-23 12:12:28 UTC Comment hidden (obsolete)
Comment 3 Fridolin Somers 2011-05-23 12:39:05 UTC
(In reply to comment #2)
> Created attachment 4229 [details] [review]
> Proposed patch

May I suggest another patch ?

This bug depends on bug 5240 which wasn't fully committed (script modification was but not template modification).
I recreated a patch with missing part from bug 5240 (updated to TT).

The difference with Frédéric's patch is that delete link is not in perl script but directly in template (like edit link).

Also : 
The framework code is always empty in edit and delete links.
There is a bug in TT with "frameworkcode" parameter, it is not in loop so the call must be : [% frameworkcode %] instead of [% loo.frameworkcode %]

Regards,
Comment 4 Fridolin Somers 2011-05-23 12:45:40 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2011-05-23 13:09:45 UTC
Thanks for catching the unpushed edits from bug 5240 Fridolyn. I have tested and signed off on your patch (attachment 4230 [details] [review]).
Comment 6 Frédéric Demians 2011-05-23 14:46:36 UTC
> I recreated a patch with missing part from bug 5240 (updated to TT).
> The difference with Frédéric's patch is that delete link is not in
> perl script but directly in template (like edit link).

+1

Thanks.
Comment 7 Frédéric Demians 2011-05-23 15:00:59 UTC
Created attachment 4233 [details] [review]
Signed-off patch with Fridolyn fix
Comment 8 Ian Walls 2011-05-25 20:41:23 UTC
Tested, confirmed, marking as Passed QA.
Comment 9 Chris Cormack 2011-05-25 21:31:49 UTC
Pushed, please test
Comment 10 Katrin Fischer 2011-07-07 22:14:57 UTC
It's possible to delete subfields from frameworks now.
Patch is in master and 3.4.x.
Comment 11 Owen Leonard 2011-08-11 18:36:19 UTC
*** Bug 6327 has been marked as a duplicate of this bug. ***