Bug 6439 - In cataloguing all subfields are displayed, even with hidden=0
Summary: In cataloguing all subfields are displayed, even with hidden=0
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 08:44 UTC by Magnus Enger
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of expanded subfields (38.58 KB, image/png)
2011-06-01 08:44 UTC, Magnus Enger
Details
Form before expanding (66.90 KB, image/png)
2011-09-30 05:11 UTC, Frédéric Demians
Details
Form after expanding (82.05 KB, image/png)
2011-09-30 05:12 UTC, Frédéric Demians
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2011-06-01 08:44:06 UTC
Created attachment 4326 [details]
Screenshot of expanded subfields

When adding a new MARC record, all subfields are expanded/visible by default, even though they have hidden = 0. See attached screenshot and selection from marc_subfield_structure below. 

mysql> select tagfield, tagsubfield, liblibrarian, hidden from marc_subfield_structure where tagfield = 800;
+----------+-------------+------------------------------------------+--------+
| tagfield | tagsubfield | liblibrarian                             | hidden |
+----------+-------------+------------------------------------------+--------+
| 800      | 8           | Andre karakteristika forbundet med navn. |      0 |
| 800      | a           | Navn.                                    |      0 |
| 800      | b           | Nummer.                                  |      0 |
| 800      | c           | Andre tilføyelser.                       |      0 |
| 800      | d           | Årstall forbundet med navn.              |      0 |
| 800      | j           | Nasjonalitet.                            |      0 |
| 800      | l           | Språk                                    |      0 |
| 800      | q           | Mer fullstendig navneform.               |      0 |
| 800      | t           | Tittel for serien.                       |      0 |
| 800      | u           | Sorteringsdelfelt for delfelt $t.        |      0 |
| 800      | v           | Bind, nummer etc.                        |      0 |
| 800      | w           | Sorteringsdelfelt for delfelt $a.        |      0 |
| 800      | x           | ISSN.                                    |      0 |
+----------+-------------+------------------------------------------+--------+

This started happening around the introduction of T:T and/or version 3.4. Others have reported the same behaviour, so it should not be a NORMARC thing. I have seen it both on current master and 3.4.1.
Comment 1 Frédéric Demians 2011-06-27 16:08:29 UTC
See bug 4374:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4374

*** This bug has been marked as a duplicate of bug 4374 ***
Comment 2 Frédéric Demians 2011-06-27 16:09:11 UTC
Take a look at comment 9
Comment 3 Ian Walls 2011-09-29 20:06:06 UTC
This is not resolved, and it's not a duplicate of 4374, it's a consequence of it.  The changed that was pushed for 4374 broke the field hiding for the Frameworks, and this bug report will be used to track how we're going to fix it.
Comment 4 Frédéric Demians 2011-09-30 05:02:50 UTC
(In reply to comment #3)
> This is not resolved, and it's not a duplicate of 4374, it's a
> consequence of it.  The changed that was pushed for 4374 broke the
> field hiding for the Frameworks, and this bug report will be used to
> track how we're going to fix it.

I pointed to bug 4374 to show where this issue comes from. I didn't say
it's a duplicate. And I specifically pointed to this comment included to
the patch for RM:

TO BE INTEGRATED IN RELEASE NOTES:

  Koha sysadmin should have to edit its frameworks to add hidden=1 in
  appropriate subfields.

For libraries who have crafted their own framework, this isn't really an
issue since they already show a subset of MARC fields.  For libraries
who use Default framework, it is. For them, this can speed up the
transition:

  - UPDATE marc_subfield_structure SET hidden=-1
  - Then by hand, in Koha framework editor, show specific subfields,
    for example in MARC21: 008, 020a, 245ab, 260abc, 700a
Comment 5 Frédéric Demians 2011-09-30 05:11:13 UTC
Created attachment 5653 [details]
Form before expanding
Comment 6 Frédéric Demians 2011-09-30 05:12:05 UTC
Created attachment 5654 [details]
Form after expanding
Comment 7 Frédéric Demians 2011-09-30 05:21:02 UTC
I've attached 2 screenshots to recall why a functional hidden feature is
desirable:

- 'Form before expanding' shows a Koha data entry form when adding a new
  biblio record. Fields 600 to 620 are collapsed, except field 606
  which is often filled but just subfields 2 & a.
- 'Form after expanding' shows the same form after clicking on '606' tag
  label. All hidden subfields are shown. 

Of course, when modifying a biblio, all filled subfields are shown even
if they are marked as hidden in framework.
Comment 8 Chris Cormack 2011-09-30 05:43:28 UTC
I suggest you check the activity log Frederic

You did mark it resolved-duplicate
http://bugs.koha-community.org/bugzilla3/show_activity.cgi?id=6439

But that aside, I agree we need the hiding feature back
Comment 9 Frédéric Demians 2011-09-30 05:48:20 UTC
> You did mark it resolved-duplicate

Ok, sorry, I misused bugzilla. Let reword it as 'I didn't want to say
this bug is a duplicate of but that it is related to'...
Comment 10 Owen Leonard 2016-06-23 12:19:26 UTC
Is this bug still valid in master? Under what circumstances are hidden subfields shown when they should not be? When I open a record for editing I see some subfields are hidden which are marked as such, and others -- which have data in them -- are not hidden.
Comment 11 Magnus Enger 2016-06-23 12:49:04 UTC
(In reply to Owen Leonard from comment #10)
> Is this bug still valid in master? Under what circumstances are hidden
> subfields shown when they should not be? When I open a record for editing I
> see some subfields are hidden which are marked as such, and others -- which
> have data in them -- are not hidden.

I would suspect this has been fixed, or more people would complain about it. :-)