Bug 7177 - memoize more function calls to speed up Koha
Summary: memoize more function calls to speed up Koha
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: unspecified
Hardware: All All
: P1 - high enhancement (vote)
Assignee: Dobrica Pavlinusic
QA Contact:
URL:
Keywords:
Depends on: 7872
Blocks: 7119
  Show dependency treegraph
 
Reported: 2011-11-06 04:39 UTC by Dobrica Pavlinusic
Modified: 2017-06-14 22:08 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
run opac search under NYTProf (840 bytes, patch)
2011-11-06 06:58 UTC, Dobrica Pavlinusic
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Dobrica Pavlinusic 2011-11-06 04:39:40 UTC
This series of patches implement improvements in Koha speed based on results from:

sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches'

perl -d:NYTProf -I/usr/share/koha/lib/ /usr/share/koha/opac/cgi-bin/opac/opac-search.pl q=human | wc

nytprofhtml
Comment 1 Paul Poulain 2011-11-06 04:50:25 UTC
Dobrica:
* setting priority to "HIGH", it's a booster !
* don't forget to update the status from NEW to ASSIGN, as you've endorsed this bug ! (I've made it)
* added 7119 dependancy, 7119 is the "code cleaning & improvement omnibus"

thx
Comment 2 Dobrica Pavlinusic 2011-11-06 06:58:20 UTC
Created attachment 6235 [details] [review]
run opac search under NYTProf
Comment 3 Katrin Fischer 2011-11-06 09:26:17 UTC
There are some patches for memcache and perf waiting for sign-off - perhaps someone familiar with how it works can look at them?
Bug 6019 and Bug 6000 might be candidates.
Comment 4 Paul Poulain 2012-01-16 16:11:26 UTC
Dobrica, where are thos patches ? Is http://git.rot13.org/?p=koha.git;a=commitdiff;h=b2155fc483f09b34c4a6ba92256f2732152bb1d5;hp=daadc5bc8f24e1bf2c1e8d958d410408d1cccc47 the only thing you've made  ?
Comment 5 Dobrica Pavlinusic 2012-01-16 17:29:46 UTC
There is a branch at

http://git.rot13.org/?p=koha.git;a=shortlog;h=refs/heads/nytprof-cache

with all experiments I tried. plack stuff is not really useful, and most of changes aren't memoize, but simple our $variable sharing which is only safe in CGI environment.

It's a mixed bag of various approaches, but hopefully some of patches might be useful.
Comment 6 Paul Poulain 2012-02-15 17:05:52 UTC
not sure the bugs available at http://git.rot13.org/?p=koha.git;a=shortlog;h=refs/heads/nytprof-cache are ready to be signed-off if I trust comment 5

However, Dobrika, I think you've definetly won a chair at the "performance boosting/plack" workshop during the hackfest.
That reminds me that you haven't given your dates of arrival & leaving. Do you have booked your hotel ?

(removing needs signoff, Dobrika, feel free to revive it if usefull)
Comment 7 Dobrica Pavlinusic 2012-04-05 13:52:56 UTC
bug 7872 cleans up code in preparation for memoize of C4::Koha
Comment 8 Zeno Tajoli 2015-04-23 07:03:05 UTC
Hi Dobrica,

I think we now use an othere way (Planck?) to do this, correct ?

Can we close it ?
Comment 9 Jonathan Druart 2016-10-04 07:44:16 UTC
This is now invalid, we must use Koha::Cache instead to correctly cache our stuffs.