I'm sorry to not be more specific, I need to gather more data, but I can confirm that reversing fine payments no longer does what it used to do. Here's one scenario: I clicked on a pay fine that was $3 typed in $2 and accidently hit confirm twice. I some how ended up with a -1.70. When I went back and looked at the fines it showed three 2.00 fines had been paid. I tried experimenting and pushing the reverse button and ended up with a -3.70.
Hi, i have the same problem. When I make a partial payment of a fine and then I make the reverse of this payment, the amount is given credit in the account. See the video attached. Regards, Marjorie
Created attachment 37246 [details] partial fine reverse
I am a bit stuck on this one, I don't find an easy way to fix it without breaking something else... Kyle, could you have a look?
Created attachment 39390 [details] [review] Bug 8055 - reversing fines wonky Test Plan: 1) Create a fine 2) Make a payment by "Pay amount" 3) Make a partial payment for the fine ( e.g. "Pay" ) 4) Reverse both payments 5) Note the amount owed is now the same as the original fine
This is the best I can do. Our current accounts system is a bit of a house of cards that we keep adding scotch tape to to keep it from falling. I would really encourage you to start qa'ing bug 6427 to replace it.
Created attachment 39437 [details] [review] [Signed-off] Bug 8055 - reversing fines wonky Test Plan: 1) Create a fine 2) Make a payment by "Pay amount" 3) Make a partial payment for the fine ( e.g. "Pay" ) 4) Reverse both payments 5) Note the amount owed is now the same as the original fine Patch behaves as advertised. Signed-off-by: Marc Véron <veron@veron.ch>
We will need tests to cover C4::Accounts::ReversePayment
Is this bug still valid?
(In reply to Marc Véron from comment #8) > Is this bug still valid? Still valid.
I'm planning a true Void Payment function for the accounts rewrite rewrite. I will not be working on this patch any longer.
No need to keep this open now. Payment voiding has been added by bug 18790 and bug 20629 is a patch to move fine reversal altogether.