Bug 8055 - reversing fines wonky
Summary: reversing fines wonky
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 15:03 UTC by Nicole C. Engard
Modified: 2018-12-03 20:04 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
partial fine reverse (3.20 MB, application/x-shockwave-flash)
2015-03-25 19:28 UTC, Marjorie Barry-Vila
Details
Bug 8055 - reversing fines wonky (2.66 KB, patch)
2015-05-22 11:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
[Signed-off] Bug 8055 - reversing fines wonky (2.84 KB, patch)
2015-05-23 09:27 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-05-07 15:03:35 UTC
I'm sorry to not be more specific, I need to gather more data, but I can confirm that reversing fine payments no longer does what it used to do.

Here's one scenario:

I clicked on a pay fine that was $3 typed in $2 and accidently hit confirm twice. I some how ended up with a -1.70. When I went back and looked at the fines it showed three 2.00 fines had been paid. I tried experimenting and pushing the reverse button and ended up with a -3.70.
Comment 1 Marjorie Barry-Vila 2015-03-25 19:27:53 UTC
Hi, i have the same problem.

When I make a partial payment of a fine and then I make the reverse of this payment, the amount is given credit in the account.

See the video attached.

Regards,

Marjorie
Comment 2 Marjorie Barry-Vila 2015-03-25 19:28:25 UTC
Created attachment 37246 [details]
partial fine reverse
Comment 3 Jonathan Druart 2015-04-07 15:16:54 UTC
I am a bit stuck on this one, I don't find an easy way to fix it without breaking something else...
Kyle, could you have a look?
Comment 4 Kyle M Hall 2015-05-22 11:29:24 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2015-05-22 11:31:30 UTC
This is the best I can do. Our current accounts system is a bit of a house of cards that we keep adding scotch tape to to keep it from falling. I would really encourage you to start qa'ing bug 6427 to replace it.
Comment 6 Marc Véron 2015-05-23 09:27:00 UTC
Created attachment 39437 [details] [review]
[Signed-off] Bug 8055 - reversing fines wonky

Test Plan:
1) Create a fine
2) Make a payment by "Pay amount"
3) Make a partial payment for the fine ( e.g. "Pay" )
4) Reverse both payments
5) Note the amount owed is now the same as the original fine

Patch behaves as advertised.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 7 Jonathan Druart 2015-06-23 10:51:32 UTC
We will need tests to cover C4::Accounts::ReversePayment
Comment 8 Marc Véron 2015-12-24 13:59:04 UTC
Is this bug still valid?
Comment 9 Aleisha Amohia 2016-01-21 01:16:44 UTC
(In reply to Marc Véron from comment #8)
> Is this bug still valid?

Still valid.
Comment 10 Kyle M Hall 2016-08-23 16:42:14 UTC
I'm planning a true Void Payment function for the accounts rewrite rewrite. I will not be working on this patch any longer.
Comment 11 Kyle M Hall 2018-05-18 13:50:44 UTC
No need to keep this open now. Payment voiding has been added by bug 18790 and bug 20629 is a patch to move fine reversal altogether.