I saved the report of withdrawn titles, and when I ran it I got a message saying the list was too long to display individual barcodes, but all titles would be deleted. I did not get the checkbox with the choice of "Delete records if no items remain". I do see this checkbox is I'm loading in a smaller file though.
Created attachment 37408 [details] [review] Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job Verify that the records without items have been deleted also.
Created attachment 37441 [details] [review] Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job 6/ Run koha qa test tools Verify that the records without items have been deleted also. NOTE: My test db only had two biblios with items, so I set MaxItemsForBatch=1. Before patch, checkbox did not display. After patch, checkbox did display. This patch merely moves one line out of the IF/ELSE/END block, and reindents for more readability. Though, there is a missing <p> if you want to get picky. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 37455 [details] [review] [PASSED QA] Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job 6/ Run koha qa test tools Verify that the records without items have been deleted also. NOTE: My test db only had two biblios with items, so I set MaxItemsForBatch=1. Before patch, checkbox did not display. After patch, checkbox did display. This patch merely moves one line out of the IF/ELSE/END block, and reindents for more readability. Though, there is a missing <p> if you want to get picky. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.6