Bug 9336 - Don't let un-holdable records prevent holdable records from being held in Intranet for multi-holds
Summary: Don't let un-holdable records prevent holdable records from being held in Int...
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on: 7703
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-02 12:48 UTC by Kyle M Hall
Modified: 2013-03-14 22:12 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9336 - Don't let un-holdable records prevent holdable records from being held in Intranet for multi-holds (2.64 KB, patch)
2013-01-02 13:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9336 - Don't let un-holdable records block bulk holds (3.03 KB, patch)
2013-01-04 20:54 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-01-02 12:48:10 UTC
It one or more items in a multihold are not-holdable, it prevents a librarian from holding the rest of the items. It would be better to warn the librarian that some of the items won't be held instead, that way, the librarian does not need to go to the trouble of removing the non-holdable items from the multi-hold to complete the process.
Comment 1 Kyle M Hall 2013-01-02 13:03:12 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-01-02 13:32:59 UTC
Test plan:
1) Apply patch
2) Place a multi-hold on two records, where one has hold-able items, and the other does not have any hold-able items.
3) Instead of being unable to submit the hold request, you should now be able to.
Comment 3 Owen Leonard 2013-01-04 20:54:08 UTC
Created attachment 14436 [details] [review]
[SIGNED-OFF] Bug 9336 - Don't let un-holdable records block bulk holds

If one or more records selected for a multi-hold have no items,
the multi-holds process will prevent the librarian from completing
the multi-hold. This forces the librarian to go back and remove the
records with no items from the multi-hold.

It would be better to warn the librarian that some of the records
won't be held instead, that way, the librarian does not need to go
to the trouble of removing the non-holdable records from the
multi-hold to complete the process.

Fixed by not disabling the submit button in the event that one
of the records has no holdable items. Updated text of submit
buttons.

Test plan:
1) Apply patch for Bug 7703
2) Apply this patch
3) Place a multi-hold on two records, where one has hold-able items, and
   the other does not have any hold-able items.
4) Instead of being unable to submit the hold request, you should now be
   able to.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Copied test plan from bug report in order to fulfill commit message
requirements.
Comment 4 Katrin Fischer 2013-03-14 22:12:10 UTC
This patch depends on 7703 that is failed QA right now.