Bug 15461

Summary: Add staff equivalent for OpacLocationOnDetail
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: andrew, angela.berrett, caroline.cyr-la-rose, Chip.Halvorsen, danielle.elder, gmcharlt, hebah, kdembek, koha, lisette, lucas, marjorie.barry-vila, martin.renvoize, noemie.labine, patrick.robitaille, sbrown
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35059
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 15461: Add StaffLocationOnDetail system preference
Bug 15461: Implement StaffLocationOnDetail
Bug 15461: perltidy DB update
Bug 15461: Fix typo in system prefererence description
Bug 15461: Add StaffLocationOnDetail system preference
Bug 15461: Implement StaffLocationOnDetail
Bug 15461: perltidy DB update
Bug 15461: Fix typo in system prefererence description
Bug 15461: Add StaffLocationOnDetail
Bug 15461: Add StaffLocationOnDetail system preference
Bug 15461: Perl tidy
Bug 15461: (follow-up) Make filtering work right when using seperate column
Bug 15461: Add StaffLocationOnDetail system preference
Bug 15461: Perl tidy
Bug 15461: (follow-up) Make filtering work right when using seperate column
Bug 15461: Add StaffLocationOnDetail system preference
Bug 15461: Perl tidy
Bug 15461: (follow-up) Make filtering work right when using seperate column

Description Katrin Fischer 2016-01-04 14:46:10 UTC
It would be nice if there was an equivalent setting to OpacLocationBranchToDisplayShelving for the staff interface to determine where the location information is shown.
Comment 1 Katrin Fischer 2017-12-28 16:29:06 UTC
Could also be solved with colvis column configuration maybe.
Comment 2 Andrew Fuerste-Henry 2020-07-08 21:30:14 UTC
+1
Comment 3 Caroline Cyr La Rose 2021-07-08 15:36:38 UTC
I was just looking for this!
Comment 4 NoƩmie Labine 2022-04-25 17:19:56 UTC
+1
Comment 5 Katrin Fischer 2023-06-17 20:03:07 UTC
*** Bug 30412 has been marked as a duplicate of this bug. ***
Comment 6 Andrew Fuerste-Henry 2024-01-05 20:57:37 UTC
Giving this a bump after confirming I don't have the skills to write it myself. We've got a floating collection and would love to hide Home Library in the intranet, but cannot do so without also hiding the shelving location.
Comment 7 Keith Dembek 2024-02-28 18:05:47 UTC
We are also a floating library who chose to hide Home Library, but this was problematic as staff can now not quickly see the Shelving Location. Having the ability to move this display to Current Library instead would be really helpful.
Comment 8 Lucas Gass (lukeg) 2024-03-08 21:11:57 UTC
Created attachment 162980 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference
Comment 9 Lucas Gass (lukeg) 2024-03-08 21:11:59 UTC
Created attachment 162981 [details] [review]
Bug 15461: Implement StaffLocationOnDetail

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.
Comment 10 Lucas Gass (lukeg) 2024-03-08 21:12:02 UTC
Created attachment 162982 [details] [review]
Bug 15461: perltidy DB update
Comment 11 Lucas Gass (lukeg) 2024-03-08 21:43:18 UTC
Created attachment 162987 [details] [review]
Bug 15461: Fix typo in system prefererence description
Comment 12 ByWater Sandboxes 2024-03-08 21:57:40 UTC
Created attachment 162990 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 13 ByWater Sandboxes 2024-03-08 21:57:43 UTC
Created attachment 162991 [details] [review]
Bug 15461: Implement StaffLocationOnDetail

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 14 ByWater Sandboxes 2024-03-08 21:57:46 UTC
Created attachment 162992 [details] [review]
Bug 15461: perltidy DB update

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 15 ByWater Sandboxes 2024-03-08 21:57:48 UTC
Created attachment 162993 [details] [review]
Bug 15461: Fix typo in system prefererence description

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 16 Martin Renvoize (ashimema) 2024-04-25 11:17:45 UTC
Sorry guys, this needs a rebase as things have moved around in the templates and includes.
Comment 17 Lucas Gass (lukeg) 2024-04-29 20:17:10 UTC
Created attachment 165804 [details] [review]
Bug 15461: Add StaffLocationOnDetail
Comment 18 Lucas Gass (lukeg) 2024-04-29 20:18:42 UTC
Created attachment 165805 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 19 Lucas Gass (lukeg) 2024-04-29 20:18:45 UTC
Created attachment 165806 [details] [review]
Bug 15461: Perl tidy
Comment 20 Lucas Gass (lukeg) 2024-04-29 20:20:04 UTC
rebased for current main, returning status to NQA.
Comment 21 Lucas Gass (lukeg) 2024-06-17 19:06:52 UTC
Still applies cleanly, just saying. :p
Comment 22 Dani Elder 2024-07-15 19:45:10 UTC
With the new sorting filters and inability to filter on location by inputting the text of the location, we would really like a way to sort/filter on shelving location in the holdings details. Having a separate column for shelving location seems really helpful here. I am willing to test and sign off as needed.
Comment 23 Lucas Gass (lukeg) 2024-07-16 16:32:49 UTC
This breaks column filtering when StaffLocationOnDetail  is set to 'on a separate column'.
Comment 24 Dani Elder 2024-07-23 20:15:48 UTC
Oh, this is painful.  We can't filter or sort on shelving location at all now. As an academic with many titles in open or closed stacks it hurts.
Comment 25 Lucas Gass (lukeg) 2024-08-12 19:47:58 UTC
Created attachment 170238 [details] [review]
Bug 15461: (follow-up) Make filtering work right when using seperate column
Comment 26 Lucas Gass (lukeg) 2024-08-12 19:48:39 UTC
Back to 'Needs sign-off' here.
Comment 27 ByWater Sandboxes 2024-08-13 16:12:30 UTC
Created attachment 170268 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 28 ByWater Sandboxes 2024-08-13 16:12:33 UTC
Created attachment 170269 [details] [review]
Bug 15461: Perl tidy

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 29 ByWater Sandboxes 2024-08-13 16:12:36 UTC
Created attachment 170270 [details] [review]
Bug 15461: (follow-up) Make filtering work right when using seperate column

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 30 Lucas Gass (lukeg) 2024-11-05 17:03:30 UTC
Doesn't apply cleanly anymore.
Comment 31 Lucas Gass (lukeg) 2024-11-05 17:07:34 UTC
Created attachment 174011 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 32 Lucas Gass (lukeg) 2024-11-05 17:07:38 UTC
Created attachment 174012 [details] [review]
Bug 15461: Perl tidy

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 33 Lucas Gass (lukeg) 2024-11-05 17:07:41 UTC
Created attachment 174013 [details] [review]
Bug 15461: (follow-up) Make filtering work right when using seperate column

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 34 Lucas Gass (lukeg) 2024-11-05 17:08:39 UTC
Rebased.