Bug 25790

Summary: [OMNIBUS] warnings removal
Product: Koha Reporter: Andrii Nugged <nugged>
Component: Architecture, internals, and plumbingAssignee: Andrii Nugged <nugged>
Status: ASSIGNED --- QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: jonathan.druart, m.de.rooy, martin.renvoize, slavashishkin, stalkernoid
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28880
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 8871, 13344, 25533, 27010, 29008, 29410, 29898, 29908, 30601, 30815, 30816, 31125, 32462, 33188, 34850, 35405, 35833, 14740, 25440, 25491, 25506, 25695, 25993, 26590, 27011, 27161, 27539, 27548, 27549, 27745, 27746, 27861, 28228, 28545, 28776, 29040, 29452, 29669, 29684, 29687, 29771, 29883, 30115, 30196, 30366, 30638, 30702, 30703, 30781, 30788, 30997, 31000, 31001    
Bug Blocks:    

Description Andrii Nugged 2020-06-17 21:09:02 UTC
This is an omnibus report to group tickets/tasks related to cleaning up of warnings, mostly now emitted in logs in various cases after "use warnings" added and also where something suspicious going on. Let's clean up our beautiful Universe from noise and potential bugs! <3 :P
Comment 1 Martin Renvoize 2020-06-25 13:51:22 UTC
Awesome to see such an effort being undertaken :)
Comment 2 Jonathan Druart 2020-12-01 14:13:13 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2022-02-10 15:22:02 UTC
Line number may vary:

Use of uninitialized value in string ne at /usr/share/koha/Koha/Item.pm line 169

         if (    exists $updated_columns{location}
-            and $self->location ne 'CART'
-            and $self->location ne 'PROC'
-            and $self->location ne 'MOVE' # RMA
+            and ( !defined($self->location) or $self->location !~ /^(CART|PROC)$/ )
             and not exists $updated_columns{permanent_location} )