Bug 30702 - Remove Context L785 warning
Summary: Remove Context L785 warning
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 25790
  Show dependency treegraph
 
Reported: 2022-05-06 07:06 UTC by Marcel de Rooy
Modified: 2022-05-17 11:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 30702: Fix Context.pm L785 warning on sessionID (1004 bytes, patch)
2022-05-06 07:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 30702: Fix Context.pm L785 warning on sessionID (1.00 KB, patch)
2022-05-06 08:52 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-05-06 07:06:53 UTC
Adding a trivial fix here before working on bug 29954
Comment 1 Marcel de Rooy 2022-05-06 07:07:26 UTC
Use of uninitialized value $sessionID in string eq at /usr/share/koha/C4/Context.pm line 785.
Comment 2 Marcel de Rooy 2022-05-06 07:17:34 UTC
Created attachment 134673 [details] [review]
Bug 30702: Fix Context.pm L785 warning on sessionID

Trivial fix. Before working on bug 29954.

Test plan:
Run a few tests like t/Context.t, t/db_dependent/Auth.t and
t/db_dependent/Circulation.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2022-05-06 07:18:15 UTC
Trivial: self SO
Comment 4 Martin Renvoize 2022-05-06 08:52:40 UTC
Created attachment 134712 [details] [review]
Bug 30702: Fix Context.pm L785 warning on sessionID

Trivial fix. Before working on bug 29954.

Test plan:
Run a few tests like t/Context.t, t/db_dependent/Auth.t and
t/db_dependent/Circulation.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2022-05-06 08:53:20 UTC
Always nice to squash warnings.

All works as expected, no regressions.

PQA
Comment 6 Fridolin Somers 2022-05-06 20:35:21 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄