Bug 35267

Summary: Clarify CSS options for Notices
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: NoticesAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: andrew, aspencatteam, aude.charillon, blawlor, caroline.cyr-la-rose, david, dcook, janet.mcgowan, katrin.fischer, kebliss, lucas, nick, oleonard, r.delahunty, sally.healey
Version: MainKeywords: roadmap_25_05
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32344
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32345
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32346
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 30287, 33478    
Bug Blocks: 33260, 38078, 38090, 39203    
Attachments: Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Remove printslip css from printnotice
Bug 35267: Expose style preferences in template editor
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Migrate notice printing to members/print_notice
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Migrate notice printing to members/print_notice
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Migrate notice printing to members/print_notice
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Update unit tests
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Update unit tests
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Update unit tests
Bug 35267: Add and Update Notice CSS system preferences
Bug 35267: Add preferences to UI
Bug 35267: Expose style preferences in template editor
Bug 35267: Apply preferences to preview and mailing
Bug 35267: Move JS to bottom in printslip
Bug 35267: Migrate accounts_summary to printslip
Bug 35267: Update unit tests
Bug 35267: (follow-up) Add explanatory note to CSS displays
Bug 35267: (follow-up) Remove 'apply to all' from format

Description Martin Renvoize (ashimema) 2023-11-06 14:28:58 UTC
During review of bug 33487 I made the suggestion that we should have more CSS options for our notices at the system preference level.  I've also hit this when looking into bug 30287.

So.. recording this here and hopefully we'll find some time to work on it.

Personally.. I'd have 

* EmailNoticeCSS - CSS stored in the DB for email notice CSS
* EmailNoticeCSSHosted - Location of CSS file for email notice CSS (to retain the old NoticeCSS option)
* PrintNoticeCSS - CSS stored in the DB for print notice CSS
* PrintNoticeCSSHosted - Location of the CSS file for the print notice CSS (to reatin the old SlipCSS option)

SMS doesn't support HTML/CSS so no need for that transport type to have these CSS options.
Comment 1 Martin Renvoize (ashimema) 2023-11-13 11:40:59 UTC
Correction, it was bug 33478
Comment 2 Martin Renvoize (ashimema) 2023-11-13 15:47:39 UTC
This would be easier to implement if we had continued down the path from bug 31714.. we'd have fewer places to change :(
Comment 3 Martin Renvoize (ashimema) 2024-10-04 06:43:16 UTC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478#c78 is the original comment regarding this.
Comment 4 Martin Renvoize (ashimema) 2024-10-04 16:02:53 UTC Comment hidden (obsolete)
Comment 5 Martin Renvoize (ashimema) 2024-10-04 16:02:55 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize (ashimema) 2024-10-04 16:02:58 UTC Comment hidden (obsolete)
Comment 7 Martin Renvoize (ashimema) 2024-10-04 16:03:00 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize (ashimema) 2024-10-04 16:03:03 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize (ashimema) 2024-10-04 16:04:11 UTC
There's still more work to do here to make sure we catch all the different printing cases.. but I think this is a solid start.

I'd love some help/thoughts on the notice editing UI changes and the relocation of preferences to one place under the 'Tools' section for system preferences.
Comment 10 Martin Renvoize (ashimema) 2024-10-07 13:58:02 UTC Comment hidden (obsolete)
Comment 11 Martin Renvoize (ashimema) 2024-10-07 13:58:05 UTC Comment hidden (obsolete)
Comment 12 Martin Renvoize (ashimema) 2024-10-07 13:58:08 UTC Comment hidden (obsolete)
Comment 13 Martin Renvoize (ashimema) 2024-10-07 13:58:11 UTC Comment hidden (obsolete)
Comment 14 Martin Renvoize (ashimema) 2024-10-07 13:58:14 UTC Comment hidden (obsolete)
Comment 15 Martin Renvoize (ashimema) 2024-10-07 13:58:16 UTC Comment hidden (obsolete)
Comment 16 Martin Renvoize (ashimema) 2024-10-07 13:58:19 UTC Comment hidden (obsolete)
Comment 17 Martin Renvoize (ashimema) 2024-10-07 14:45:47 UTC Comment hidden (obsolete)
Comment 18 Martin Renvoize (ashimema) 2024-10-07 14:45:50 UTC Comment hidden (obsolete)
Comment 19 Martin Renvoize (ashimema) 2024-10-07 14:45:53 UTC Comment hidden (obsolete)
Comment 20 Martin Renvoize (ashimema) 2024-10-07 14:45:56 UTC Comment hidden (obsolete)
Comment 21 Martin Renvoize (ashimema) 2024-10-07 14:45:58 UTC Comment hidden (obsolete)
Comment 22 Martin Renvoize (ashimema) 2024-10-07 14:46:01 UTC Comment hidden (obsolete)
Comment 23 Martin Renvoize (ashimema) 2024-10-07 14:46:05 UTC Comment hidden (obsolete)
Comment 24 Martin Renvoize (ashimema) 2024-10-07 15:45:14 UTC
# Test plan
This is going to be a fun road to travel.

## UI
1) Apply patches and run database updates
2) Note that 'NoticeCSS' and 'SlipCSS' have been renamed to 'EmailNoticeStylesheet' and 'PrintSlipStylesheet' to better reflect their content and both have been migrated into 'Admin > System preferences > Tools > Notices and slips'
3) Note in the same location in system preferences, we now also have 'EmailNoticeCSS', 'PrintNoticeCSS' and 'PrintSlipCSS' preferences that allow direct entry of CSS rules for their respective notice message transports.
4) Under 'Tools > Notices and Slips', edit a notice and note we have a new accordion near the top of the page that displays the content of 'AllNoticeCSS', 'EmailNoticeCSS', 'PrintNoticeCSS' and 'PrintSlipCSS' preferences for the end users reference
4a) If the user has administrative permissions, they should also see an 'Edit' button that's a shortcut the the relevant preference in the system preferences

## Adding styles
1) Add a simple style for testing to 'AllNoticeCSS'
   `.alltest { color: red }`
2) Add a simple style for testing to 'EmailNoticeCSS'
   `.emailtest { color: green }`
3) Add a simple style for testing to 'PrintNoticeCSS'
   `.printtest { color: organge }`
4) Let use the WELCOME notice for testing.. add a simple html template as follows.
```
<p>
    This is a notice for testing</br>
    <span class="alltest">All message transport types should display this red</span><br>
    <span class="emailtest">Only email notices should display this green</span></br>
    <span class="printtest">Only print notices should display this orange</span><br>
    All done
</p>
```
5) Lets use 'Henry A' to test the notice
5a) Do NOT set an email address for Henry
5b) Queue a 'Welcome' print notice using 'More > Send welcome'
5c) Add a primary email address for Henry
5d) Queue a 'Welcome' email notice using 'More > Send welcome'
6) Navigate to the 'Notices' tab for Henry
7) Click the title of the print notice to display a preview and note the correct colors are displayed
8) Click the title of the email notice to display a preview and note the correct colors are displayed

## Testing the functionality
1) Run 'gather_print_notices.pl' with options to output to html file
2) Confirm that the generated notice contains the correct classes and styles
3) Enable 'ManageNotices' preference from the dependency bug
4) Navigate to 'Tools > Mange notices'
5) Select both notices and print using the bottom button
6) Confirm that the two notices display the different colors and are on two separate pages in the print preview.
Comment 25 Martin Renvoize (ashimema) 2024-10-07 16:00:26 UTC Comment hidden (obsolete)
Comment 26 Martin Renvoize (ashimema) 2024-10-07 16:00:29 UTC Comment hidden (obsolete)
Comment 27 Martin Renvoize (ashimema) 2024-10-07 16:00:32 UTC Comment hidden (obsolete)
Comment 28 Martin Renvoize (ashimema) 2024-10-07 16:00:35 UTC Comment hidden (obsolete)
Comment 29 Martin Renvoize (ashimema) 2024-10-07 16:00:38 UTC Comment hidden (obsolete)
Comment 30 Martin Renvoize (ashimema) 2024-10-07 16:00:42 UTC Comment hidden (obsolete)
Comment 31 Martin Renvoize (ashimema) 2024-10-07 16:00:45 UTC Comment hidden (obsolete)
Comment 32 Martin Renvoize (ashimema) 2024-10-07 16:07:16 UTC
This clarifies the original Notice and Slip CSS options expanding from just supporting linked stylesheets to using local style input fields too.

We do not yet handle clarifying how the per notice per transport type level CSS can be defined.  This needs some thought and I've got that as a follow-up bug 38090
Comment 33 Martin Renvoize (ashimema) 2024-10-07 16:08:55 UTC
This also, does not fully implement the stylesheet link options for the multi-print handling code.. that was already failing in bug 33260 and will also need some thought.. I think this should also be a follow-up bug as I'm really not sure if anyone is actually using that functionality in real life.
Comment 34 Martin Renvoize (ashimema) 2024-12-16 18:22:42 UTC Comment hidden (obsolete)
Comment 35 Martin Renvoize (ashimema) 2024-12-16 18:22:46 UTC Comment hidden (obsolete)
Comment 36 Martin Renvoize (ashimema) 2024-12-16 18:22:49 UTC Comment hidden (obsolete)
Comment 37 Martin Renvoize (ashimema) 2024-12-16 18:22:51 UTC Comment hidden (obsolete)
Comment 38 Martin Renvoize (ashimema) 2024-12-16 18:22:55 UTC Comment hidden (obsolete)
Comment 39 Martin Renvoize (ashimema) 2024-12-16 18:22:58 UTC Comment hidden (obsolete)
Comment 40 Martin Renvoize (ashimema) 2024-12-16 18:34:54 UTC
Bugs reordered and rebased so we don't hold up this important fix/enhancement behind the more contentious notices management page and print options bug.
Comment 41 Martin Renvoize (ashimema) 2024-12-16 18:37:25 UTC
With the reorder the following parts of the above test plan should be ignored.. or rather only tested when the relevant bug is applied atop this one:

3) Enable 'ManageNotices' preference from the dependency bug
4) Navigate to 'Tools > Mange notices'
5) Select both notices and print using the bottom button
6) Confirm that the two notices display the different colors and are on two separate pages in the print preview.
Comment 42 David Nind 2024-12-16 23:13:47 UTC
After applying the patches, there was an error with the databae update

 updatedatabase
String found where operator expected at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35267.pl line 20, near "$out "Added new system preference 'AllNoticeCSS'""
	(Missing operator before "Added new system preference 'AllNoticeCSS'"?)
DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35267.pl  [23:07:10]
	ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 741. at /kohadevbox/koha/C4/Installer.pm line 743
Comment 43 Martin Renvoize (ashimema) 2024-12-19 12:21:30 UTC Comment hidden (obsolete)
Comment 44 Martin Renvoize (ashimema) 2024-12-19 12:21:33 UTC Comment hidden (obsolete)
Comment 45 Martin Renvoize (ashimema) 2024-12-19 12:21:37 UTC Comment hidden (obsolete)
Comment 46 Martin Renvoize (ashimema) 2024-12-19 12:21:40 UTC Comment hidden (obsolete)
Comment 47 Martin Renvoize (ashimema) 2024-12-19 12:21:44 UTC Comment hidden (obsolete)
Comment 48 Martin Renvoize (ashimema) 2024-12-19 12:21:48 UTC Comment hidden (obsolete)
Comment 49 Martin Renvoize (ashimema) 2024-12-19 12:25:36 UTC Comment hidden (obsolete)
Comment 50 Martin Renvoize (ashimema) 2024-12-19 12:25:39 UTC Comment hidden (obsolete)
Comment 51 Martin Renvoize (ashimema) 2024-12-19 12:25:42 UTC Comment hidden (obsolete)
Comment 52 Martin Renvoize (ashimema) 2024-12-19 12:25:46 UTC Comment hidden (obsolete)
Comment 53 Martin Renvoize (ashimema) 2024-12-19 12:25:49 UTC Comment hidden (obsolete)
Comment 54 Martin Renvoize (ashimema) 2024-12-19 12:25:52 UTC Comment hidden (obsolete)
Comment 55 Martin Renvoize (ashimema) 2024-12-19 12:51:20 UTC Comment hidden (obsolete)
Comment 56 Martin Renvoize (ashimema) 2024-12-19 12:51:24 UTC Comment hidden (obsolete)
Comment 57 Martin Renvoize (ashimema) 2024-12-19 12:51:28 UTC Comment hidden (obsolete)
Comment 58 Martin Renvoize (ashimema) 2024-12-19 12:51:32 UTC Comment hidden (obsolete)
Comment 59 Martin Renvoize (ashimema) 2024-12-19 12:51:36 UTC Comment hidden (obsolete)
Comment 60 Martin Renvoize (ashimema) 2024-12-19 12:51:39 UTC Comment hidden (obsolete)
Comment 61 Martin Renvoize (ashimema) 2024-12-19 12:51:43 UTC Comment hidden (obsolete)
Comment 62 Martin Renvoize (ashimema) 2024-12-19 12:58:38 UTC
Looks like I lost a colon during the patch re-arrangement, thanks for spotting it David :)
Comment 63 David Nind 2025-02-01 00:24:31 UTC
Hi martin.

Apologies for taking so long to re-test.

The patches no longer apply 8-(...

git bz apply 35267

Bug 35267 - Clarify CSS options for Notices

175723 - Bug 35267: Add and Update Notice CSS system preferences
175724 - Bug 35267: Add preferences to UI
175725 - Bug 35267: Expose style preferences in template editor
175726 - Bug 35267: Apply preferences to preview and mailing
175727 - Bug 35267: Move JS to bottom in printslip
175728 - Bug 35267: Migrate accounts_summary to printslip
175729 - Bug 35267: Update unit tests

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 35267: Add and Update Notice CSS system preferences
Applying: Bug 35267: Add preferences to UI
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
M	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
M	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
error: Failed to merge in the changes.
Patch failed at 0001 Bug 35267: Add preferences to UI
Comment 64 Martin Renvoize (ashimema) 2025-02-21 14:01:16 UTC Comment hidden (obsolete)
Comment 65 Martin Renvoize (ashimema) 2025-02-21 14:01:19 UTC Comment hidden (obsolete)
Comment 66 Martin Renvoize (ashimema) 2025-02-21 14:01:22 UTC Comment hidden (obsolete)
Comment 67 Martin Renvoize (ashimema) 2025-02-21 14:01:26 UTC Comment hidden (obsolete)
Comment 68 Martin Renvoize (ashimema) 2025-02-21 14:01:30 UTC Comment hidden (obsolete)
Comment 69 Martin Renvoize (ashimema) 2025-02-21 14:01:33 UTC Comment hidden (obsolete)
Comment 70 Martin Renvoize (ashimema) 2025-02-21 14:01:37 UTC Comment hidden (obsolete)
Comment 71 Martin Renvoize (ashimema) 2025-02-21 14:06:06 UTC
(In reply to David Nind from comment #63)
> Hi martin.
> 
> Apologies for taking so long to re-test.
> 
> The patches no longer apply 8-(...
> 

We should be applying again now.. do feel free to reach out on mattermost if you need rebases.. I try to stay on top of things but as you can probably tell from my dashboard I'm trying to track a few hundred outstanding bug submissions in my name so I don't always notice there's been a comment all that quickly.

Thanks for your interest.
Comment 72 Lucas Gass (lukeg) 2025-02-25 21:11:18 UTC
Everything seems to working as described. 

The difference between PrintSlipCSS and what can be done under the 'Format' tab is that PrintSlipCSS applies to ALL print notices. With the 'Format' tab you can apply CSS  to specific notices OR "Apply format settings to all notices:". It all feels a bit overwhelming to me in there now. Maybe we at least need some clearer instructions on what CSS will apply and where?

Can something be done with the display? Having accordions for each to only display an 'Edit' button feels off, to me. Maybe combing 'All notice CSS', 'Email Notice CSS', 'Print Notice CSS', and 'Format' in one place with some hints/tips about each would make it easier to understand what does what? 

With this will we even need to keep the "Apply format settings to all notices:" functionality? Seems like using PrintNoticeCSS will be better.

Sorry for being a curmudgeon here.
Comment 73 Martin Renvoize (ashimema) 2025-02-26 08:35:00 UTC
(In reply to Lucas Gass (lukeg) from comment #72)
> Everything seems to working as described. 
> 
> The difference between PrintSlipCSS and what can be done under the 'Format'
> tab is that PrintSlipCSS applies to ALL print notices. With the 'Format' tab
> you can apply CSS  to specific notices OR "Apply format settings to all
> notices:". It all feels a bit overwhelming to me in there now. Maybe we at
> least need some clearer instructions on what CSS will apply and where?
> 
> Can something be done with the display? Having accordions for each to only
> display an 'Edit' button feels off, to me. Maybe combing 'All notice CSS',
> 'Email Notice CSS', 'Print Notice CSS', and 'Format' in one place with some
> hints/tips about each would make it easier to understand what does what? 
> 
> With this will we even need to keep the "Apply format settings to all
> notices:" functionality? Seems like using PrintNoticeCSS will be better.
> 
> Sorry for being a curmudgeon here.

Just being picky....

In the 'Format' tab, the CSS will be applied to ALL NOTICE (no matter the transport type) but only when PRINTING them. I find this incredibly confusing personally and it's one of the things I highlight as a bug in bug 38090, bug 33260 and the original bug 33478.

I have no idea why the 'Apply format setting to all notices' was ever added to the format tab.. I brought this up on the original bug I believe (as did Marcel)
Comment 74 Martin Renvoize (ashimema) 2025-02-26 09:07:50 UTC
Also.. given bug 33478 comment 198 the Format stuff actually in all reality only applies to SLIPS right now ;)
Comment 75 Martin Renvoize (ashimema) 2025-04-03 14:37:15 UTC Comment hidden (obsolete)
Comment 76 Martin Renvoize (ashimema) 2025-04-03 14:37:20 UTC Comment hidden (obsolete)
Comment 77 Martin Renvoize (ashimema) 2025-04-03 14:37:26 UTC Comment hidden (obsolete)
Comment 78 Martin Renvoize (ashimema) 2025-04-03 14:37:31 UTC Comment hidden (obsolete)
Comment 79 Martin Renvoize (ashimema) 2025-04-03 14:37:37 UTC Comment hidden (obsolete)
Comment 80 Martin Renvoize (ashimema) 2025-04-03 14:37:42 UTC Comment hidden (obsolete)
Comment 81 Martin Renvoize (ashimema) 2025-04-03 14:37:48 UTC Comment hidden (obsolete)
Comment 82 David Nind 2025-04-03 16:09:31 UTC
You might want to change the Sponsored-by line :)
Comment 83 Martin Renvoize (ashimema) 2025-04-15 14:02:24 UTC Comment hidden (obsolete)
Comment 84 Martin Renvoize (ashimema) 2025-04-15 14:02:28 UTC Comment hidden (obsolete)
Comment 85 Martin Renvoize (ashimema) 2025-04-15 14:02:32 UTC Comment hidden (obsolete)
Comment 86 Martin Renvoize (ashimema) 2025-04-15 14:02:37 UTC Comment hidden (obsolete)
Comment 87 Martin Renvoize (ashimema) 2025-04-15 14:02:41 UTC Comment hidden (obsolete)
Comment 88 Martin Renvoize (ashimema) 2025-04-15 14:02:45 UTC Comment hidden (obsolete)
Comment 89 Martin Renvoize (ashimema) 2025-04-15 14:02:49 UTC Comment hidden (obsolete)
Comment 90 Martin Renvoize (ashimema) 2025-04-15 14:02:53 UTC Comment hidden (obsolete)
Comment 91 Martin Renvoize (ashimema) 2025-04-15 14:02:58 UTC Comment hidden (obsolete)
Comment 92 Martin Renvoize (ashimema) 2025-04-15 14:16:30 UTC
*** Bug 39203 has been marked as a duplicate of this bug. ***
Comment 93 Martin Renvoize (ashimema) 2025-04-15 14:25:11 UTC
I think this is as far as this particular bug should go.. we should regroup for improving the 'Format'/'Local HTML Styling' tab for per notice styling options in follow-up bug 38090.

What we introduce here is a clearer way of applying CSS styles globally to HTML Notices.. be that Email, Print or Both.

What we do need to remember however, is that whilst this allows one to format HTML notices with much more options, many email clients will not fully respect your HTML emails.. HTML email generally only support an older subset of the HTML standard.
Comment 94 Martin Renvoize (ashimema) 2025-04-15 14:48:06 UTC
We should also consider the thoughts on bug 39410 here... I'm starting to doubt my approach.. whilst I feel this is clearer already, it also confuses end users given the restrictions placed on valid HTML inside an email.
Comment 95 Lucas Gass (lukeg) 2025-04-29 14:54:17 UTC
Everything here is looking good but once I add some CSS to AllNoticeCSS t/db_dependent/Koha/Notice/Message.t fails.

There is also a few complaints from the QA script about files needing to be tidy.