| Summary: | Toolbar_spec.ts is failing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 40067, 40345, 40433 | ||
| Bug Blocks: | 40318 | ||
| Attachments: |
Bug 40430: Fix Toolbar_spec.ts
Bug 40430: Fix Toolbar_spec.ts Bug 40430: Fix Toolbar_spec.ts Bug 40430: Fix Toolbar_spec.ts Bug 40430: Fix Toolbar_spec.ts |
||
|
Description
Jonathan Druart
2025-07-17 09:23:29 UTC
So, here we are. Jenkins is failing on a Cypress test (Toolbar_spec.ts) because it relies on data that is not in the DB: vendor #1 is injected by misc4dev and is not part of the sample data. Which means the test passes locally but fails on Jenkins. To fix this, I need the work I have been working on for the last weeks. Now it's either we have it and I can fix the tests correctly (creating the vendor in DB), or we drop the test. Created attachment 184196 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Acquisitions/Vendors_spec.ts pass, even if you do not have any vendors in DB. Created attachment 184197 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Acquisitions/Vendors_spec.ts pass, even if you do not have any vendors in DB. Created attachment 184198 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB. Created attachment 184238 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 184350 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Dependencies not in 24.11.x Test suite related, no changes to the manual required. |