Bug 40433 - Missing maxLength in item, patron and library
Summary: Missing maxLength in item, patron and library
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 40176 40177 40178
Blocks: 40430 40434
  Show dependency treegraph
 
Reported: 2025-07-17 12:30 UTC by Jonathan Druart
Modified: 2025-08-22 08:29 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.03
Circulation function:


Attachments
Bug 40433: Add missing maxLength to item, library and patron (3.95 KB, patch)
2025-07-17 12:32 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40433: Add missing maxLength to item, library and patron (4.00 KB, patch)
2025-07-17 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40433: Add missing maxLength to item, library and patron (4.06 KB, patch)
2025-07-18 11:29 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-17 12:30:56 UTC
The test added in xt/api.t was not fully accurate, we skipped the columns that have the same name as the api attribute (ie. the ones not part of to_api_mapping
Comment 1 Jonathan Druart 2025-07-17 12:32:04 UTC
Created attachment 184192 [details] [review]
Bug 40433: Add missing maxLength to item, library and patron

The test added in xt/api.t was not fully accurate, we skipped the columns that have the same name as the api attribute (ie. the ones not part of to_api_mapping)

Test plan:
prove xt/api.t should pass
Comment 2 Owen Leonard 2025-07-17 16:48:35 UTC
Created attachment 184236 [details] [review]
Bug 40433: Add missing maxLength to item, library and patron

The test added in xt/api.t was not fully accurate, we skipped the
columns that have the same name as the api attribute (ie. the ones not
part of to_api_mapping)

Test plan:
prove xt/api.t should pass

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2025-07-18 11:29:03 UTC
Created attachment 184349 [details] [review]
Bug 40433: Add missing maxLength to item, library and patron

The test added in xt/api.t was not fully accurate, we skipped the
columns that have the same name as the api attribute (ie. the ones not
part of to_api_mapping)

Test plan:
prove xt/api.t should pass

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Lucas Gass (lukeg) 2025-07-21 20:04:03 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-08-22 08:29:57 UTC
Nice work everyone!

Pushed to 25.05.x