Bug 6473

Summary: Test bug for Git-bz ✔ ❤ ★
Product: Koha Reporter: Liz Rea <wizzyrea>
Component: Test SuiteAssignee: Mason James <mtj>
Status: In Discussion --- QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: enhancement    
Priority: P5 - low CC: chris, dcook, domm, jonathan.druart, martin.renvoize, perldomm, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20136
GIT URL: Initiative type: ---
Sponsorship status: Seeking cosponsors Comma delimited list of Sponsors: Athens County Public Libraries
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39320, 41089    
Bug Blocks:    
Attachments: [SIGNED OFF] Bug 6467: Add shelving location to checkin screen
Bug 6473 - testing obsoleting of attachments from gitbz
Bug 6473 - testing obsoleting of attachments from gitbz
Bug 6473 - an edit to the file
Bug 6473 - an edit to the file
Bug 6473 - an edit to the file
Bug 6473 - an edit to the file
Bug 6473 - an edit to the file
Test patch. Ignore
Bug 1633 - Interface revisions for the staff client
this patch does not apply, it's just to do some testing for a new script that automatically detects all patches that does not apply
bug 5503 follow-up DBrev number + added "upgrade to $DBversion" string
Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox
Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox
bug 5503 follow-up DBrev number + added "upgrade to $DBversion" string
[Signed Off] Bug 7633 - Move display of patron image in self checkout
Bug 6473 testing git bz
Bug 6473 testing git bz
Bug 6473 testing git bz
Bug 6473 testing git bz
Bug 6473 testing git bz
Bug 6473 testing git bz
Bug 4330 : Adding copyright headers and fixing FSF addresses
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
Bug 8353 follow-up adding a tiny sh in misc/maintenance
adding file b
adding file a
adding file b
modified: git-bz
git bz test
git bz test
git bz test
git bz test
git bz test
git bz test
git bz test
Bug 9066: VirtualShelves db access not Plack+MariaDB compatible
test
9105: Followup for closing Zoom connections
9088: Default values for fund and item type on neworderempty form (dbrev)
9088: Default values for fund and item type on neworderempty form (dbrev)
9088: Default values for fund and item type on neworderempty form (dbrev)
test
Bug 9755: Refactor record merge functionality
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755: Refactor record merge functionality
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755: Refactor record merge functionality
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 9755: Refactor record merge functionality
Bug 9755 QA follow-up: move MARC-specific functionality to utility class
Bug 7143: Updating history and about page
Bug 10496 - CCSR theme OPAC tabs to not show correct active state
Bug xxxxx: Modern::Perl should be used
Bug xxxxx: replace tmpl with tt
Bug 10403: add ability to change fund on receipt
Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch
Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch
Signed off 0001-Bug-10402-Use-an-object-for-contacts.patch
Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch
Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch
Bug 9223: Multiple values of AdvancedSearchTypes in suggestions
Bug 9223: Add SupportsAuthorizedValues syspref (followup 1)
Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions
git-bz testing patch
git-bz testing patch
git-bz testing patch
git-bz testing patch
git-bz testing patch
git-bz testing patch
Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead
Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation
Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation
Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation
Bug 9011 - Add the ability to store the last patron to return an item
Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory
Bug 9011 [QA Followup]
Bug 9011 [QA Followup 2] - Add message to OPAC
Bug 9011 [QA Followup 3] - Update database schema files
Bug 9011 [QA Followup 4] - Add issue_id to issues tables
Bug 6473: this is a test
Bug 6473: this is a test
3.16.x test push
Bug 8992: Add the greybox include file for the bootstrap theme
Updated pod for AddMember
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 6473: Test UTF8 in commit message
Bug 6473 - Test bug for Git-bz
Bug 6473 - Test bug for Git-bz
Bug 12929: (followup) fix license
DBRev 3.23.00.000: 2016 Year of the Monkey
Testing unicode stuff
Bug 7143: Add link to www.openhub.net profile for Marc Véron
Bug 6473: Add link to www.openhub.net profile for Marc Véron
Bug 6473: Add link to www.openhub.net profile for Marc Véron
BUG 6473 test
HAHAHA
Bug 6473 Testing https
Bug 6473 Testing https
HAHAHA
just a test
Bug 15240: Do not process issues with a date due later than today
Bug 6473: just a test
[SIGNED-OFF] Bug 6473: just a test
Bug 6473: just a test
Bug 6473: just a test
Bug 6473: just a test
Bug 6473: just a test
Bug 12310: (QA follow-up) Add prefs to test too
Bug 6473: test strange char in summary → + emoji in file name
Bug 6473: just a test
Updated LICENSE file to the latest version.
Bug 6473: Test bug for Git-bz
Bug 6473: Test bug for Git-bz
Bug 6473: Test bug for Git-bz
Bug 6473: Update LICENSE version and date
Test
Bug 18736: Calculate tax depending on rounding
Bug 18736: Calculate tax depending on rounding
Bug 18308 - Added step to onboarding tool to set minPasswordLength
Bug 18308 - Added step to onboarding tool to set minPasswordLength
Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system prefere
Add 'Test' to README.md
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds"
Bug 17510: enable use of subfield 0 in MMT actions
Bug 17510: update MMT-related unit tests
Bug 6473: Test bug for Git-bz
Bug 6473: Test bug for Git-bz
Bug 6473: Test bug for Git-bz
Bug 6473: Test bug for Git-bz
Bug 6473: Test bug for Git-bz
buildbot 20.12.00-0 for stretch: update debian/control
Bug 27030: Add missing perldoc for Processing hold status to C4::Reserves
buildbot 20.12.00-0 for stretch: update debian/control
Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control
Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control
testing
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà
HOla
Bug 6473 - Test bug for Git-bz ✔ ❤ ★
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★
Bug 6473: Test patch
Bug 20424: Add new zebra indexes for the last IFLA updates
Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates
Bug 20424: remove zebra index for field 901
Bug 20424: provides biblio-zebra-indexdefs.xsl
Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★
Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★
Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★
Bug 20424: Add new zebra indexes for the last IFLA updates
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 6473: Test git-bz after bugzilla update
Bug 38201: Fix Dataproviders_spec.ts
Bug 38201: Remove DT warnings from Cypress tests
Bug 38201: Remove discarded params error from DataProviders
Bug 38201: Avoid parseFloat when value is an empty string
Bug 38201: Improve Agreements/Edit tests
Bug 38201: Add missing newlines at end of file
Bug 38201: Remove cy.wait(500)
Bug 38201: Fix Dataproviders_spec.ts
Bug 38201: Remove DT warnings from Cypress tests
Bug 38201: Remove discarded params error from DataProviders
Bug 38201: Avoid parseFloat when value is an empty string
Bug 38201: Fix Dataproviders_spec.ts
Bug 38201: Remove DT warnings from Cypress tests
Bug 38201: Remove discarded params error from DataProviders
Bug 38201: Avoid parseFloat when value is an empty string
Bug 38201: Fix Dataproviders_spec.ts
Bug 38201: Remove DT warnings from Cypress tests
Bug 38201: Remove discarded params error from DataProviders
Use GET for the login endpoint
Bug 38201: Fix Dataproviders_spec.ts
Bug 38201: Remove DT warnings from Cypress tests
Bug 38201: Remove discarded params error from DataProviders
Bug 38201: Fix Dataproviders_spec.ts
Bug 38201: Remove DT warnings from Cypress tests
Bug 38201: Remove discarded params error from DataProviders
Bug 38201: Fix Dataproviders_spec.ts
Bug 38201: Remove DT warnings from Cypress tests
Bug 38201: Remove discarded params error from DataProviders
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Fix case when range is HEAD
Improve feature coverage
Fix case when range is HEAD
Improve feature coverage
Fix case when range is HEAD
GitBz::Bug introduced
Fix case when range is HEAD
GitBz::Bug introduced
Fix case when range is HEAD
GitBz::Bug introduced
Fix case when range is HEAD
[#1] Fix attachment upload order
Latest Perl is 5.42
Bug 41136: Allow advanced editor to search SRU servers
Bug 41136: Allow advanced editor to search SRU servers
Bug 41136: Allow advanced editor to search SRU servers
Bug 41136: Allow advanced editor to search SRU servers
Bug 41136: Allow advanced editor to search SRU servers
Bug 41136: Allow advanced editor to search SRU servers
Bug 41136: Allow advanced editor to search SRU servers
Bug 40841: Add limits configuration UI
Bug 40841: Implement library limits on Z39.50 searches
Bug 40841: Add limits configuration UI
Bug 40841: Implement library limits on Z39.50 searches
Bug 40841: Add limits configuration UI
Bug 40841: Implement library limits on Z39.50 searches
Bug 40841: Add limits configuration UI
Bug 40841: Implement library limits on Z39.50 searches
Bug 40841: Implement library limits on Z39.50 searches
Bug 40841: Implement library limits on Z39.50 searches
Bug 40841: Implement library limits on Z39.50 searches
Bug 6473: test ✔ ❤ ★
Bug 39320: Fix ERM breadcrumb causing page reload
Bug 39320: Fix ERM breadcrumb causing page reload
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40446: Allow overriding Cypress DB settings
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+
Bug 40524: Update print format to use built-in formatter
Bug 40041: (follow-up) Fix periods and add Robert Fox
Bug 40524: Update print format to use built-in formatter
Bug 40041: (follow-up) Fix periods and add Robert Fox
Bug 40524: Update print format to use built-in formatter
Bug 40041: (follow-up) Fix periods and add Robert Fox
Bug 40524: Update print format to use built-in formatter
Bug 40041: (follow-up) Fix periods and add Robert Fox
Bug 40524: Update print format to use built-in formatter
Bug 40041: (follow-up) Fix periods and add Robert Fox
Bug 40524: Update print format to use built-in formatter
Bug 40041: (follow-up) Fix periods and add Robert Fox
Bug 40524: Update print format to use built-in formatter
Bug 40041: (follow-up) Fix periods and add Robert Fox
Bug 41364: Fix error in preservation module breadcrumb
Bug 41142: Update jQuery-validate plugin to 1.21.0
[#36] Add iterative error handling for invalid QA contacts
Bug 41432: Prefetch items and borrowers for holds

Description Liz Rea 2011-06-06 21:00:34 UTC
Use this bug when testing your git-bz. :)

DO YOUR WORST!!

(yes, that's a challenge)
Comment 1 Liz Rea 2011-06-06 21:06:35 UTC
Created attachment 4386 [details] [review]
[SIGNED OFF] Bug 6467: Add shelving location to checkin screen
Comment 2 Liz Rea 2011-06-06 21:11:28 UTC
Comment on attachment 4386 [details] [review]
[SIGNED OFF] Bug 6467: Add shelving location to checkin screen

Testing
Comment 3 Liz Rea 2011-12-16 16:34:27 UTC Comment hidden (obsolete)
Comment 4 Liz Rea 2011-12-16 16:41:39 UTC Comment hidden (obsolete)
Comment 5 Liz Rea 2011-12-16 16:42:30 UTC Comment hidden (obsolete)
Comment 6 Liz Rea 2011-12-16 16:43:16 UTC Comment hidden (obsolete)
Comment 7 Liz Rea 2011-12-16 20:38:25 UTC Comment hidden (obsolete)
Comment 8 Liz Rea 2011-12-16 20:39:06 UTC Comment hidden (obsolete)
Comment 9 Liz Rea 2011-12-16 20:42:25 UTC Comment hidden (obsolete)
Comment 10 Jared Camins-Esakov 2012-01-14 13:27:02 UTC Comment hidden (obsolete)
Comment 11 Jared Camins-Esakov 2012-01-14 13:28:05 UTC Comment hidden (obsolete)
Comment 12 Paul Poulain 2012-02-10 15:31:48 UTC Comment hidden (obsolete)
Comment 13 Chris Cormack 2012-03-02 20:44:47 UTC Comment hidden (obsolete)
Comment 14 Liz Rea 2012-03-02 20:47:24 UTC Comment hidden (obsolete)
Comment 15 Liz Rea 2012-03-02 20:51:59 UTC Comment hidden (obsolete)
Comment 16 Chris Cormack 2012-03-02 21:27:05 UTC Comment hidden (obsolete)
Comment 17 Chris Cormack 2012-03-04 20:15:22 UTC
testing emails
Comment 18 Liz Rea 2012-03-05 17:29:54 UTC Comment hidden (obsolete)
Comment 19 Paul Poulain 2012-05-29 03:55:00 UTC Comment hidden (obsolete)
Comment 20 Paul Poulain 2012-05-29 03:59:47 UTC Comment hidden (obsolete)
Comment 21 Paul Poulain 2012-05-29 10:20:32 UTC
Patch tested with a sandbox, by Paul Poulain that has not this mail
 <paul.poulain@free.fr>
Comment 22 Paul Poulain 2012-05-29 10:20:52 UTC Comment hidden (obsolete)
Comment 23 Paul Poulain 2012-05-29 13:01:12 UTC
Patch tested with a sandbox, by Paul Poulain testing sandboxes <paul.poulain@free.fr>
Comment 24 Paul Poulain 2012-05-29 13:01:32 UTC Comment hidden (obsolete)
Comment 25 Paul Poulain 2012-05-29 13:21:12 UTC
Patch tested with a sandbox, by Paul Poulain testing sandboxes <paul.poulain@free.fr>
Comment 26 Paul Poulain 2012-05-29 13:21:32 UTC Comment hidden (obsolete)
Comment 27 Paul Poulain 2012-05-29 15:13:11 UTC
Patch tested with a sandbox, by `id` <test@test>
Comment 28 Paul Poulain 2012-05-29 15:13:32 UTC Comment hidden (obsolete)
Comment 29 Paul Poulain 2012-05-31 08:30:13 UTC
Patch tested with a sandbox, by Paul Poulain testing a new patch <paul.poulain@biblibre.com>
Comment 30 Paul Poulain 2012-05-31 08:30:41 UTC Comment hidden (obsolete)
Comment 31 Paul Poulain 2012-05-31 09:49:47 UTC
Patch tested with a sandbox, by Paul Poulain that has not this mail id
 <id>
Comment 32 Jared Camins-Esakov 2012-07-14 12:34:01 UTC Comment hidden (obsolete)
Comment 33 Jared Camins-Esakov 2012-07-14 12:37:25 UTC
Status: Needs Signoff
Comment 34 Jared Camins-Esakov 2012-07-14 13:09:40 UTC Comment hidden (obsolete)
Comment 35 Jared Camins-Esakov 2012-07-14 13:11:59 UTC Comment hidden (obsolete)
Comment 36 Jared Camins-Esakov 2012-07-14 13:15:06 UTC Comment hidden (obsolete)
Comment 37 Jared Camins-Esakov 2012-07-14 13:16:13 UTC Comment hidden (obsolete)
Comment 38 Jared Camins-Esakov 2012-07-14 13:17:03 UTC Comment hidden (obsolete)
Comment 39 Jared Camins-Esakov 2012-07-14 13:17:46 UTC Comment hidden (obsolete)
Comment 40 Jared Camins-Esakov 2012-07-14 13:20:15 UTC Comment hidden (obsolete)
Comment 41 Jared Camins-Esakov 2012-07-14 13:20:54 UTC Comment hidden (obsolete)
Comment 42 Jared Camins-Esakov 2012-07-14 13:21:44 UTC Comment hidden (obsolete)
Comment 43 Jared Camins-Esakov 2012-07-14 13:26:47 UTC Comment hidden (obsolete)
Comment 44 Jared Camins-Esakov 2012-07-14 13:28:11 UTC Comment hidden (obsolete)
Comment 45 Jared Camins-Esakov 2012-07-14 13:29:11 UTC Comment hidden (obsolete)
Comment 46 Jared Camins-Esakov 2012-07-14 13:41:19 UTC Comment hidden (obsolete)
Comment 47 Jared Camins-Esakov 2012-07-14 13:42:05 UTC Comment hidden (obsolete)
Comment 48 Jared Camins-Esakov 2012-07-14 13:43:09 UTC Comment hidden (obsolete)
Comment 49 Jared Camins-Esakov 2012-07-14 13:44:12 UTC Comment hidden (obsolete)
Comment 50 Jonathan Druart 2012-08-10 15:16:47 UTC Comment hidden (obsolete)
Comment 51 Jonathan Druart 2012-08-10 15:22:12 UTC Comment hidden (obsolete)
Comment 52 Jonathan Druart 2012-08-10 15:22:15 UTC Comment hidden (obsolete)
Comment 53 Mason James 2012-09-25 12:34:04 UTC Comment hidden (obsolete)
Comment 54 Mason James 2012-09-26 07:42:31 UTC Comment hidden (obsolete)
Comment 55 Mason James 2012-09-26 07:46:24 UTC Comment hidden (obsolete)
Comment 56 Mason James 2012-09-26 07:50:54 UTC Comment hidden (obsolete)
Comment 57 Mason James 2012-09-26 07:51:21 UTC Comment hidden (obsolete)
Comment 58 Mason James 2012-09-26 07:52:37 UTC Comment hidden (obsolete)
Comment 59 Mason James 2012-09-26 07:53:01 UTC Comment hidden (obsolete)
Comment 60 Mason James 2012-09-26 07:54:24 UTC Comment hidden (obsolete)
Comment 61 Chris Cormack 2012-11-06 09:31:17 UTC
test
Comment 62 Mason James 2012-11-16 05:09:42 UTC Comment hidden (obsolete)
Comment 63 Magnus Enger 2012-11-16 08:38:59 UTC
(In reply to comment #62)
> Created attachment 13473 [details] [review]
> Bug 9066: VirtualShelves db access not Plack+MariaDB compatible

Is this patch on the right bug, Mason?
Comment 64 Paul Poulain 2012-11-26 09:44:40 UTC
(testing patch complexity custom field)
Comment 65 Paul Poulain 2012-11-26 10:06:23 UTC Comment hidden (obsolete)
Comment 66 Marcel de Rooy 2013-01-30 15:22:37 UTC Comment hidden (obsolete)
Comment 67 Marcel de Rooy 2013-01-31 06:51:36 UTC Comment hidden (obsolete)
Comment 68 Marcel de Rooy 2013-01-31 06:52:47 UTC Comment hidden (obsolete)
Comment 69 Marcel de Rooy 2013-01-31 11:40:55 UTC Comment hidden (obsolete)
Comment 70 Chris Cormack 2013-02-09 04:18:55 UTC Comment hidden (obsolete)
Comment 71 Chris Cormack 2013-02-09 04:23:05 UTC
Comment on attachment 15201 [details] [review]
test

Review of attachment 15201 [details] [review]:
-----------------------------------------------------------------

This change looks ok to me, blah blah test test
Comment 72 Chris Cormack 2013-02-09 04:24:33 UTC
Comment on attachment 15201 [details] [review]
test

Review of attachment 15201 [details] [review]:
-----------------------------------------------------------------

This change looks ok to me, blah blah test test
Comment 73 Chris Cormack 2013-02-09 04:26:28 UTC
Comment on attachment 15201 [details] [review]
test

Review of attachment 15201 [details] [review]:
-----------------------------------------------------------------

Marked as verified
Comment 74 Jared Camins-Esakov 2013-06-13 20:12:53 UTC Comment hidden (obsolete)
Comment 75 Jared Camins-Esakov 2013-06-13 20:30:05 UTC Comment hidden (obsolete)
Comment 76 Jared Camins-Esakov 2013-06-13 20:34:01 UTC Comment hidden (obsolete)
Comment 77 Jared Camins-Esakov 2013-06-13 20:38:07 UTC Comment hidden (obsolete)
Comment 78 Jared Camins-Esakov 2013-06-13 20:40:00 UTC Comment hidden (obsolete)
Comment 79 Jared Camins-Esakov 2013-06-13 20:42:56 UTC Comment hidden (obsolete)
Comment 80 Jared Camins-Esakov 2013-06-13 20:44:00 UTC Comment hidden (obsolete)
Comment 81 Jared Camins-Esakov 2013-06-13 20:45:23 UTC Comment hidden (obsolete)
Comment 82 Jared Camins-Esakov 2013-06-13 20:47:20 UTC Comment hidden (obsolete)
Comment 83 Jared Camins-Esakov 2013-06-13 20:57:10 UTC Comment hidden (obsolete)
Comment 84 Jared Camins-Esakov 2013-06-13 21:01:42 UTC Comment hidden (obsolete)
Comment 85 Jared Camins-Esakov 2013-06-13 21:02:20 UTC Comment hidden (obsolete)
Comment 86 Jared Camins-Esakov 2013-06-13 21:04:06 UTC Comment hidden (obsolete)
Comment 87 Jared Camins-Esakov 2013-06-13 21:04:16 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 88 Jared Camins-Esakov 2013-06-13 21:04:59 UTC Comment hidden (obsolete)
Comment 89 Jared Camins-Esakov 2013-06-13 21:09:55 UTC Comment hidden (obsolete)
Comment 90 Jared Camins-Esakov 2013-06-13 21:10:06 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 91 Jared Camins-Esakov 2013-06-13 22:57:49 UTC Comment hidden (obsolete)
Comment 92 Jared Camins-Esakov 2013-06-13 23:02:40 UTC Comment hidden (obsolete)
Comment 93 Katrin Fischer 2013-06-16 19:59:06 UTC
Just getting this out of the signed off list.
Comment 94 Liz Rea 2013-07-03 21:31:02 UTC
Don't close this bug, it's very useful for testing git BZ please and thank you
Comment 95 Biblibre Sandboxes 2013-07-10 12:23:41 UTC
Patch tested with a sandbox, by sandbox8 <sandboxes@biblibre.com>
Comment 96 Biblibre Sandboxes 2013-07-10 12:35:34 UTC
Patch tested with a sandbox, by sandbox8 <sandboxes@biblibre.com>
Comment 97 Biblibre Sandboxes 2013-07-10 12:37:52 UTC
Patch tested with a sandbox, by sandbox8 <sandboxes@biblibre.com>
Comment 98 Paul Poulain 2013-07-10 12:38:28 UTC Comment hidden (obsolete)
Comment 99 Paul Poulain 2013-07-10 12:38:32 UTC Comment hidden (obsolete)
Comment 100 Biblibre Sandboxes 2013-07-12 12:18:17 UTC
Patch tested with a sandbox, by sandboxes <sandboxes@biblibre.com>
Comment 101 Biblibre Sandboxes 2013-07-12 12:19:05 UTC Comment hidden (obsolete)
Comment 102 Biblibre Sandboxes 2013-07-12 12:19:11 UTC Comment hidden (obsolete)
Comment 103 Jared Camins-Esakov 2013-07-23 13:46:10 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 104 Jared Camins-Esakov 2013-07-23 13:57:49 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
 Testing upload again.
Comment 105 Jared Camins-Esakov 2013-07-23 13:59:48 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
 Testing uploading again, this time with git-bz actually installed.
Comment 106 Jared Camins-Esakov 2013-07-23 14:02:25 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
 Let's try this once more.
Comment 107 Jared Camins-Esakov 2013-07-23 14:05:21 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
 Argh! Why does it hate me?!?
Comment 108 Jared Camins-Esakov 2013-07-23 14:08:04 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
The problem was git-bz wasn't fully configured, I think.
Comment 109 Jared Camins-Esakov 2013-07-23 14:09:58 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
Unfortunately, configuring git-bz is harder than it looks. Maybe.
Comment 110 Jared Camins-Esakov 2013-07-23 14:10:34 UTC Comment hidden (obsolete)
Comment 111 Jared Camins-Esakov 2013-07-23 14:16:03 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
 Ah-ha! When using koha-gitify, git-bz has to work for *TWO* users.
Comment 112 Jared Camins-Esakov 2013-07-23 14:22:34 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
Actually, it looks like Apache just massacres the environment.
Comment 113 Jared Camins-Esakov 2013-07-23 17:40:20 UTC Comment hidden (obsolete)
Comment 114 Jared Camins-Esakov 2013-07-23 17:50:05 UTC Comment hidden (obsolete)
Comment 115 Jared Camins-Esakov 2013-07-23 17:56:04 UTC Comment hidden (obsolete)
Comment 116 Jared Camins-Esakov 2013-07-23 17:58:40 UTC Comment hidden (obsolete)
Comment 117 Jared Camins-Esakov 2013-07-23 17:58:48 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
And now we've lost my snarky comments? Oh no!
Comment 118 Jared Camins-Esakov 2013-07-31 15:50:42 UTC Comment hidden (obsolete)
Comment 119 Jared Camins-Esakov 2013-07-31 15:50:53 UTC
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
Clever commentary on the patch!
Comment 120 Owen Leonard 2013-07-31 16:49:14 UTC Comment hidden (obsolete)
Comment 121 Owen Leonard 2013-07-31 16:49:24 UTC Comment hidden (obsolete)
Comment 122 Owen Leonard 2013-07-31 16:49:34 UTC Comment hidden (obsolete)
Comment 123 Galen Charlton 2013-10-28 18:50:14 UTC Comment hidden (obsolete)
Comment 124 Galen Charlton 2013-10-28 19:00:26 UTC Comment hidden (obsolete)
Comment 125 Galen Charlton 2013-10-28 20:51:45 UTC Comment hidden (obsolete)
Comment 126 Galen Charlton 2013-10-28 21:34:20 UTC Comment hidden (obsolete)
Comment 127 Galen Charlton 2013-10-28 21:43:32 UTC Comment hidden (obsolete)
Comment 128 Galen Charlton 2013-10-28 21:45:43 UTC Comment hidden (obsolete)
Comment 129 Magnus Enger 2014-09-30 18:24:27 UTC Comment hidden (obsolete)
Comment 130 Magnus Enger 2014-09-30 18:25:21 UTC
Comment on attachment 31958 [details] [review]
Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead

just testing...
Comment 131 Kyle M Hall (khall) 2014-10-16 16:41:00 UTC Comment hidden (obsolete)
Comment 132 Kyle M Hall (khall) 2014-10-16 16:41:53 UTC Comment hidden (obsolete)
Comment 133 Kyle M Hall (khall) 2014-10-16 16:42:25 UTC Comment hidden (obsolete)
Comment 134 Kyle M Hall (khall) 2014-10-16 16:42:41 UTC Comment hidden (obsolete)
Comment 135 Kyle M Hall (khall) 2014-10-16 16:42:45 UTC Comment hidden (obsolete)
Comment 136 Kyle M Hall (khall) 2014-10-16 16:42:49 UTC Comment hidden (obsolete)
Comment 137 Kyle M Hall (khall) 2014-10-16 16:42:53 UTC Comment hidden (obsolete)
Comment 138 Kyle M Hall (khall) 2014-10-16 16:42:58 UTC Comment hidden (obsolete)
Comment 139 Kyle M Hall (khall) 2014-10-16 16:43:02 UTC Comment hidden (obsolete)
Comment 140 Jonathan Druart 2014-12-09 11:51:09 UTC Comment hidden (obsolete)
Comment 141 Biblibre Sandboxes 2014-12-09 12:08:15 UTC
Patch tested with a sandbox, by sonia <sonia.bouis@univ-lyon3.fr>
Comment 142 Biblibre Sandboxes 2014-12-09 12:08:44 UTC Comment hidden (obsolete)
Comment 143 Marcel de Rooy 2014-12-11 12:39:49 UTC
Changing status..
Comment 144 Mason James 2014-12-22 09:23:07 UTC Comment hidden (obsolete)
Comment 145 Marcel de Rooy 2015-01-07 13:16:11 UTC Comment hidden (obsolete)
Comment 146 the.invinnysible.one 2015-01-13 02:04:58 UTC Comment hidden (obsolete)
Comment 147 Justin Vos 2015-01-15 01:58:10 UTC Comment hidden (obsolete)
Comment 148 Justin Vos 2015-01-15 02:54:57 UTC Comment hidden (obsolete)
Comment 149 Justin Vos 2015-01-15 03:04:45 UTC Comment hidden (obsolete)
Comment 150 Justin Vos 2015-01-15 03:17:42 UTC Comment hidden (obsolete)
Comment 151 Justin Vos 2015-01-15 03:22:14 UTC Comment hidden (obsolete)
Comment 152 Justin Vos 2015-01-15 03:25:34 UTC Comment hidden (obsolete)
Comment 153 Justin Vos 2015-01-15 03:27:38 UTC Comment hidden (obsolete)
Comment 154 Justin Vos 2015-01-15 03:28:44 UTC Comment hidden (obsolete)
Comment 155 Marcel de Rooy 2015-01-15 13:12:12 UTC Comment hidden (obsolete)
Comment 156 Marcel de Rooy 2015-01-15 13:14:31 UTC
Test UTF8 in commit message
Seems still not to work:
fatal: cannot convert from utf-8utf-8 to utf-8

Patch file contains:
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=utf-8
Comment 157 Marcel de Rooy 2015-01-15 13:16:38 UTC
Justin:
What do you have in the i18n section of your .gitconfig ?
Comment 158 Chris Cormack 2015-07-10 02:01:39 UTC
testing upgraded bugzilla
Comment 159 Chris Cormack 2015-07-10 02:05:09 UTC
test 2
Comment 160 Chris Cormack 2015-07-10 02:06:39 UTC
test 2
Comment 161 Chris Cormack 2015-07-10 02:09:57 UTC
test 2
Comment 162 Chris Cormack 2015-07-10 02:17:01 UTC
test 2
Comment 163 Chris Cormack 2015-07-10 02:18:52 UTC
test 2
Comment 164 Chris Cormack 2015-07-10 02:19:58 UTC
test 2
Comment 165 Chris Cormack 2015-07-12 20:56:55 UTC Comment hidden (obsolete)
Comment 166 Chris Cormack 2015-07-13 04:35:55 UTC Comment hidden (obsolete)
Comment 167 Liz Rea 2015-12-03 01:46:39 UTC Comment hidden (obsolete)
Comment 168 Liz Rea 2015-12-03 03:28:26 UTC Comment hidden (obsolete)
Comment 169 Chris Cormack 2015-12-03 22:05:13 UTC
test
Comment 170 Mark Tompsett 2015-12-16 16:32:14 UTC Comment hidden (obsolete)
Comment 171 Mark Tompsett 2015-12-16 16:33:57 UTC Comment hidden (obsolete)
Comment 172 Mark Tompsett 2015-12-16 16:49:48 UTC Comment hidden (obsolete)
Comment 173 Mark Tompsett 2015-12-16 16:51:05 UTC Comment hidden (obsolete)
Comment 174 Jonathan Druart 2015-12-18 12:26:28 UTC
*** Bug 15390 has been marked as a duplicate of this bug. ***
Comment 175 Galen Charlton 2015-12-18 13:40:45 UTC
This is the most important comment ever.
Comment 176 Mirko Tietgen 2016-01-25 22:24:40 UTC Comment hidden (obsolete)
Comment 177 Mirko Tietgen 2016-01-25 22:26:13 UTC Comment hidden (obsolete)
Comment 178 Chris Cormack 2016-01-26 08:30:10 UTC Comment hidden (obsolete)
Comment 179 Chris Cormack 2016-01-26 08:35:37 UTC Comment hidden (obsolete)
Comment 180 Mirko Tietgen 2016-01-26 09:03:12 UTC Comment hidden (obsolete)
Comment 181 Jonathan Druart 2016-01-27 12:40:02 UTC Comment hidden (obsolete)
Comment 182 Marcel de Rooy 2016-01-27 12:41:12 UTC Comment hidden (obsolete)
Comment 183 Biblibre Sandboxes 2016-03-14 07:31:28 UTC
Patch tested with a sandbox, by Julian Maurice <julian.maurice@biblibre.com>
Comment 184 Biblibre Sandboxes 2016-03-14 07:31:57 UTC
Created attachment 49083 [details] [review]
Bug 6473: just a test

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 185 Mark Tompsett 2016-10-29 05:34:00 UTC
Created attachment 56974 [details] [review]
[SIGNED-OFF] Bug 6473: just a test

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

NOTE: Using KohaDevBox for the first time.
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 186 Biblibre Sandboxes 2017-03-14 12:53:01 UTC
Created attachment 61059 [details] [review]
Bug 6473: just a test

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 187 Biblibre Sandboxes 2017-03-14 13:03:43 UTC
Patch tested with a sandbox, by Julian Maurice <julian.maurice@biblibre.com>
Comment 188 Biblibre Sandboxes 2017-03-14 13:08:46 UTC
Patch tested with a sandbox, by Julian Maurice <julian.maurice@biblibre.com>
Comment 189 Biblibre Sandboxes 2017-03-14 15:06:13 UTC
Patch tested with a sandbox, by Julian Maurice <julian.maurice@biblibre.com>
Comment 190 Biblibre Sandboxes 2017-03-14 15:06:43 UTC
Created attachment 61069 [details] [review]
Bug 6473: just a test

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 191 Paul Poulain 2017-04-11 10:21:09 UTC
Created attachment 62038 [details] [review]
Bug 6473: just a test

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Paul POULAIN <paul.poulain@biblibre.com>
Comment 192 Chris Cormack 2017-06-15 17:06:24 UTC
test email
Comment 193 Chris Cormack 2017-06-15 17:07:22 UTC
test email
Comment 194 Chris Cormack 2017-06-15 17:11:05 UTC
test email
Comment 195 Chris Cormack 2017-06-15 17:12:57 UTC
test email
Comment 196 ByWaterSandboxes 2017-07-28 11:33:58 UTC
Patch tested with a sandbox, by Kyle M Hall <kyle@gmail.com>
Comment 197 ByWaterSandboxes 2017-07-28 12:21:45 UTC
Patch tested with a sandbox, by Kyle M Hall <kyle@gmail.com>
Comment 198 ByWaterSandboxes 2017-07-28 12:23:16 UTC
Patch tested with a sandbox, by Kyle M Hall <kyle@gmail.com>
Comment 199 ByWaterSandboxes 2017-07-28 12:23:38 UTC
Created attachment 65313 [details] [review]
Bug 6473: just a test

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Paul POULAIN <paul.poulain@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@gmail.com>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>
Comment 200 Julian Maurice 2018-01-16 14:31:15 UTC
test git bz edit
Comment 201 Julian Maurice 2018-01-16 14:31:50 UTC
test git bz edit
Comment 202 Julian Maurice 2018-01-16 15:08:16 UTC
test git bz edit
Comment 203 Julian Maurice 2018-01-18 07:55:07 UTC
test git bz edit
Comment 204 Julian Maurice 2018-04-04 08:11:30 UTC
test
Comment 205 Marcel de Rooy 2018-07-27 10:19:51 UTC
Created attachment 77301 [details] [review]
Bug 12310: (QA follow-up) Add prefs to test too

Test plan:
Run t/db_dependent/UsageStats.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 206 Victor Grousset/tuxayo 2018-08-20 12:46:50 UTC
Created attachment 78016 [details] [review]
Bug 6473: test strange char in summary → + emoji in file name
Comment 207 Victor Grousset/tuxayo 2018-08-20 12:51:10 UTC
(In reply to Liz Rea from comment #0)
> Use this bug when testing your git-bz. :)
> 
> DO YOUR WORST!!
> 
> (yes, that's a challenge)

^_^

With an old git-bz version (or wrong branch), the above should cause an issue when attaching to this bug:

Traceback (most recent call last):
  File "/usr/local/bin/git-bz", line 2632, in <module>
    do_attach(*args)
  File "/usr/local/bin/git-bz", line 1998, in do_attach
    attach_commits(bug, commits, edit_comments=global_options.edit)
  File "/usr/local/bin/git-bz", line 1913, in attach_commits
    description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body)
  File "/usr/local/bin/git-bz", line 1866, in edit_attachment_comment
    lines = edit_template(template.getvalue())
  File "/usr/local/bin/git-bz", line 811, in edit_template
    f.write(template)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2192' in position 600: ordinal not in range(128)
Comment 208 Victor Grousset/tuxayo 2018-08-20 12:59:13 UTC
(could be an issue even when attaching *another* patch in this bug, quite tricky then ^_^ )
Comment 209 Julian Maurice 2018-08-25 11:34:24 UTC
test
Comment 210 Julian Maurice 2018-08-27 12:00:16 UTC
test
Comment 211 Jonathan Druart 2018-09-21 20:11:55 UTC
qa comment test
Comment 212 Margaret Hade 2018-10-04 17:58:19 UTC Comment hidden (obsolete)
Comment 213 Andreas Roussos 2018-10-08 00:24:03 UTC Comment hidden (obsolete)
Comment 214 Andreas Roussos 2018-10-08 02:01:19 UTC Comment hidden (obsolete)
Comment 215 Andreas Roussos 2018-10-08 02:34:02 UTC Comment hidden (obsolete)
Comment 216 Andreas Roussos 2018-10-08 02:55:45 UTC Comment hidden (obsolete)
Comment 217 Andreas Roussos 2018-10-08 03:26:06 UTC Comment hidden (obsolete)
Comment 218 Chris Cormack 2018-12-17 21:10:30 UTC
Testing kanban
Comment 219 Chris Cormack 2018-12-17 21:13:32 UTC
moving back
Comment 220 Marcel de Rooy 2019-01-25 10:22:53 UTC Comment hidden (obsolete)
Comment 221 Marcel de Rooy 2019-03-15 10:01:46 UTC Comment hidden (obsolete)
Comment 222 Marcel de Rooy 2019-03-15 10:03:53 UTC Comment hidden (obsolete)
Comment 223 Owen Leonard 2019-03-27 11:52:14 UTC
*** Bug 22587 has been marked as a duplicate of this bug. ***
Comment 224 Hayley Pelham 2019-03-28 22:26:57 UTC
Created attachment 87152 [details] [review]
Bug 18308 - Added step to onboarding tool to set minPasswordLength

This patch increases the default minPasswordLength syspref value to 8
characters, for new installations.

The final (6th step) of the onboarding tool is now a password length
page where the default value of 8 can be altered. There is a security warning in red recommending to the user they
keep the minimum length of the password at 8 characters or more.

This patch also removes the atomicupdate .sql file to be run in an update to alter the default
minPasswordLength value for existing Koha installations, based on tester
feedback.

Test plan:
1. Create a patron with a password less than 3 characters in length and
notice that a red message is displayed by the input telling you that the
password must be 3 characters minimum length

2. Query the database "select value from systempreferences where
variable="minPasswordLength"; and notice the value is 3

3. Drop and recreate your database and restart memcached

4. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to create a circulation rule

5. Apply patch

6. Repeat step 3

7. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to set the minimum password length, the
numerical input element has a default value of 8 and notice that it will
go below 3

8. Repeat step 2 and notice the value is 8

9. In the onboarding tool change the minimum password length value to 7
and submit the form

10. Notice the completed page of the onboarding tool is displayed with
the message that the minimum password length has been set.

11. Repeat step 2 and notice the value is now 7.

12. Try to create a patron in Intranet and OPAC with a password less
than 7 characters and notice that a red message is displayed by the
input telling you that the password must be 7 characters minimum length

Sponsored-By: Catalyst IT

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 225 Hayley Pelham 2019-04-17 03:50:34 UTC
Created attachment 88128 [details] [review]
Bug 18308 - Added step to onboarding tool to set minPasswordLength

This patch increases the default minPasswordLength syspref value to 8
characters, for new installations.

The final (6th step) of the onboarding tool is now a password length
page where the default value of 8 can be altered. There is a security warning in red recommending to the user they
keep the minimum length of the password at 8 characters or more.

This patch also removes the atomicupdate .sql file to be run in an update to alter the default
minPasswordLength value for existing Koha installations, based on tester
feedback.

Test plan:
1. Create a patron with a password less than 3 characters in length and
notice that a red message is displayed by the input telling you that the
password must be 3 characters minimum length

2. Query the database "select value from systempreferences where
variable="minPasswordLength"; and notice the value is 3

3. Drop and recreate your database and restart memcached

4. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to create a circulation rule

5. Apply patch

6. Repeat step 3

7. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to set the minimum password length, the
numerical input element has a default value of 8 and notice that it will
go below 3

8. Repeat step 2 and notice the value is 8

9. In the onboarding tool change the minimum password length value to 7
and submit the form

10. Notice the completed page of the onboarding tool is displayed with
the message that the minimum password length has been set.

11. Repeat step 2 and notice the value is now 7.

12. Try to create a patron in Intranet and OPAC with a password less
than 7 characters and notice that a red message is displayed by the
input telling you that the password must be 7 characters minimum length

Sponsored-By: Catalyst IT

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 226 Lisette Scheer 2019-11-19 18:34:47 UTC
Created attachment 95586 [details] [review]
Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system prefere
Comment 227 Julian Maurice 2019-11-22 10:54:46 UTC
Created attachment 95716 [details] [review]
Add 'Test' to README.md
Comment 228 ByWater Sandboxes 2020-01-15 14:00:21 UTC Comment hidden (obsolete)
Comment 229 Andreas Roussos 2020-02-14 20:18:15 UTC Comment hidden (obsolete)
Comment 230 Andreas Roussos 2020-02-14 20:18:20 UTC Comment hidden (obsolete)
Comment 231 Victor Grousset/tuxayo 2020-04-18 07:35:35 UTC
There to link to a comment:

just write: "bug 6473 comment 227"

or: "comment 227"
Comment 232 Victor Grousset/tuxayo 2020-04-18 07:36:02 UTC
*there => test
Comment 233 Victor Grousset/tuxayo 2020-07-23 19:56:54 UTC
Formatting test

> Amet voluptatibus hic facere quia enim alias. Exercitationem deserunt iusto totam. Eum quos ducimus magnam aut. Assumenda impedit recusandae commodi eos placeat consectetur ut. Impedit id id quam eveniet rerum. Sed ab officia provident non cupiditate.
Comment 234 Mason James 2020-12-06 05:37:27 UTC
Created attachment 114217 [details] [review]
Bug 6473: Test bug for Git-bz

add test for debian/control
Comment 235 Mason James 2020-12-06 05:37:56 UTC
Created attachment 114218 [details] [review]
Bug 6473: Test bug for Git-bz

add test for debian/control
Comment 236 Mason James 2020-12-06 05:38:54 UTC
Created attachment 114219 [details] [review]
Bug 6473: Test bug for Git-bz

add test for debian/control
Comment 237 Mason James 2020-12-06 05:49:00 UTC
Created attachment 114220 [details] [review]
Bug 6473: Test bug for Git-bz

add test for debian/control
Comment 238 Mason James 2020-12-06 05:49:16 UTC
Created attachment 114221 [details] [review]
Bug 6473: Test bug for Git-bz

add test for debian/control
Comment 239 Mason James 2020-12-06 06:45:42 UTC
Created attachment 114222 [details] [review]
buildbot 20.12.00-0 for stretch: update debian/control

modified:   debian/control
Comment 240 Mason James 2020-12-06 06:51:40 UTC
Created attachment 114223 [details] [review]
Bug 27030: Add missing perldoc for Processing hold status to C4::Reserves

Test plan:

Look into diff and confirm the comment does make sense

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 241 Mason James 2020-12-06 06:52:17 UTC
Created attachment 114224 [details] [review]
buildbot 20.12.00-0 for stretch: update debian/control

	modified:   debian/control
Comment 242 Mason James 2020-12-07 04:32:25 UTC
Created attachment 114225 [details] [review]
Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control

Content-Type: text/plain; charset="utf-8"

	modified:   debian/control xxx
Comment 243 Mason James 2020-12-07 04:33:34 UTC
Created attachment 114226 [details] [review]
Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control

Content-Type: text/plain; charset="utf-8"

	modified:   debian/control xxx
Comment 244 Chris Cormack 2020-12-16 17:45:57 UTC
Test
Comment 245 Chris Cormack 2021-04-06 04:29:42 UTC
test 2
Comment 246 David Cook 2021-04-06 04:32:39 UTC
Test impersonating
Comment 247 David Cook 2021-04-06 05:17:45 UTC Comment hidden (obsolete)
Comment 248 Chris Cormack 2021-04-07 08:45:21 UTC
test
Comment 249 Chris Cormack 2021-04-07 08:45:50 UTC
Created attachment 119255 [details]
testing
Comment 250 Chris Cormack 2021-04-07 08:50:07 UTC
The content of attachment 119255 [details] has been deleted
Comment 251 Victor Grousset/tuxayo 2021-05-17 23:48:41 UTC
tested dependency following
Comment 252 Victor Grousset/tuxayo 2021-05-19 13:43:25 UTC
test formatting

|8 |657 |13:39:09|NULL    | CPL| NULL|13:39:09 | CPL| NULL| TransferCancellation | Manual
|9 |657 |13:39:09|13:39:09| CPL| NULL|NULL     | FFL| NULL| Manual               | NULL
Comment 253 Victor Grousset/tuxayo 2021-05-19 13:44:34 UTC
|8|657|39:09|NULL |CPL|NUL|39:09|CPL|NUL|TransferCancellation|Manual
|9|657|39:09|39:09|CPL|NUL|NUL  |FFL|NUL|Manual              |NULL
Comment 254 Jonathan Druart 2021-05-19 15:41:39 UTC
Created attachment 121181 [details] [review]
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà

And in the body
✔❤★ aÄÄÄ Äãà éèà
Comment 255 Jonathan Druart 2022-03-18 12:15:14 UTC
Created attachment 131891 [details] [review]
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà

And in the body
✔❤★ aÄÄÄ Äãà éèà
Comment 256 Jonathan Druart 2022-03-18 12:23:41 UTC
Created attachment 131893 [details] [review]
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà

And in the body
✔❤★ aÄÄÄ Äãà éèà
Comment 257 Jonathan Druart 2022-03-18 12:26:21 UTC
Created attachment 131894 [details] [review]
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà

And in the body
✔❤★ aÄÄÄ Äãà éèà
Comment 258 Owen Leonard 2022-04-22 11:57:42 UTC
*** Bug 30558 has been marked as a duplicate of this bug. ***
Comment 259 Tomás Cohen Arazi (tcohen) 2022-05-11 11:05:47 UTC
Created attachment 134862 [details] [review]
HOla

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 260 Jonathan Druart 2022-11-21 10:13:48 UTC
Created attachment 144109 [details] [review]
Bug 6473 - Test bug for Git-bz ✔ ❤ ★

Bug 6473 - Test bug for Git-bz ✔ ❤ ★
Bug 6473 - Test bug for Git-bz ✔ ❤ ★
Comment 261 Slava Shishkin 2022-11-22 09:20:34 UTC
Created attachment 144144 [details] [review]
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★
Comment 262 OpenFifth Sandboxes 2022-12-16 12:10:29 UTC
Created attachment 144671 [details] [review]
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★

Signed-off-by: Bob Smith <bob.smith@test-email.com>
Comment 263 OpenFifth Sandboxes 2022-12-16 12:11:42 UTC
Created attachment 144672 [details] [review]
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★

Signed-off-by: Bob Smith <bob.smith@test-email.com>

Signed-off-by: Bob Smith <bob.smith@test-email.com>
Comment 264 OpenFifth Sandboxes 2022-12-16 12:19:34 UTC
Created attachment 144673 [details] [review]
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★

Signed-off-by: Bob Smith <bob.smith@test-email.com>

Signed-off-by: Bob Smith <bob.smith@test-email.com>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 265 Fabricio Molina 2023-02-22 19:53:42 UTC
Created attachment 147183 [details] [review]
Bug 6473: Test patch

This is a test patch
Comment 266 Thibault Keromnès 2023-03-31 11:58:05 UTC
Created attachment 149030 [details] [review]
Bug 20424: Add new zebra indexes for the last IFLA updates

Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>
Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Comment 267 Thibault Keromnès 2023-03-31 11:58:14 UTC
Created attachment 149031 [details] [review]
Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates

Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>
Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Comment 268 Thibault Keromnès 2023-03-31 11:58:28 UTC
Created attachment 149032 [details] [review]
Bug 20424: remove zebra index for field 901

Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Comment 269 Thibault Keromnès 2023-03-31 11:58:51 UTC
Created attachment 149033 [details] [review]
Bug 20424: provides biblio-zebra-indexdefs.xsl

Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Comment 270 Victor Grousset/tuxayo 2023-08-19 09:05:52 UTC
Oh lol the above don't look like a test, I'm emailing them.
Comment 271 Slava Shishkin 2024-01-05 11:04:49 UTC Comment hidden (obsolete)
Comment 272 Slava Shishkin 2024-01-05 11:14:04 UTC Comment hidden (obsolete)
Comment 273 Slava Shishkin 2024-01-05 11:18:00 UTC
Created attachment 160568 [details] [review]
Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★

- test line for the commit message
- and one more test line for message
Comment 274 Victor Grousset/tuxayo 2024-11-06 03:42:55 UTC
Testing of formatting of comments to see if it's the same between preview and a posted comment:


        - module: bookings
          code: BOOKING_CANCELLATION
          branchcode: ""
          name: "Booking cancellation notice"
          is_html: 1
          title: "A library booking was cancelled"
          message_transport_type: email
          lang: default
          content:
            - "[%- PROCESS 'html_helpers.inc' -%]"
            - "[%- USE KohaDates -%]"
            - "Dear [%- INCLUDE 'patron-title.inc' patron => booking.patron -%],<br>"
            - "<br>"
            - "We regret to inform you, that the following booking has been cancelled.<br>"
            - "<br>"
            - "Title: [%- INCLUDE 'biblio-title.inc' biblio=booking.biblio link = 0 -%]<br>"
            - "<br>"
            - "Dates: [% booking.start_date | $KohaDates %] to [% booking.end_date | $KohaDates %]<br>"
            - "<br>"
            - "Reason: [% booking.cancellation_reason | html %]<br>"
            - "<br>"
            - "Kind regards<br>"
            - "<br>"
            - "[% booking.pickup_library.branchname %]"
Comment 275 Thomas Klausner 2025-04-07 12:27:41 UTC
Test mailing to domm@plix.at and perldomm@gmail.com (as it's broken for domm@plix.at ATM)
Comment 276 Thomas Klausner 2025-04-07 12:28:56 UTC
Test mailing to domm@plix.at and perldomm@gmail.com (as it's broken for domm@plix.at ATM) (again as mail is not set to account adding the comment)
Comment 277 John Vinke 2025-05-08 15:51:44 UTC
Created attachment 182093 [details]
Bug 20424: Add new zebra indexes for the last IFLA updates

https://bugs.koha-community.org/show_bug.cgi?id=6473
This is a test by: John Vinke <jvinke@austinseminary.edu>
Comment 278 Chris Cormack 2025-05-19 14:26:45 UTC
test
Comment 279 Chris Cormack 2025-06-09 00:17:29 UTC
Testing mail
Comment 280 Chris Cormack 2025-06-09 00:24:45 UTC
Testing mail
Comment 281 Chris Cormack 2025-06-09 00:28:21 UTC
Testing mail
Comment 282 Chris Cormack 2025-06-09 00:29:34 UTC
Testing mail
Comment 283 Chris Cormack 2025-06-09 00:31:23 UTC
Testing mail
Comment 284 Chris Cormack 2025-06-09 00:31:52 UTC
Testing mail
Comment 285 Chris Cormack 2025-06-09 00:35:10 UTC
Testing mail
Comment 286 Chris Cormack 2025-06-09 00:36:56 UTC
Testing mail
Comment 287 Chris Cormack 2025-06-09 19:40:22 UTC
and testing -T fix
Comment 288 Chris Cormack 2025-06-09 19:44:52 UTC
and testing -T fix
Comment 289 Katrin Fischer 2025-06-09 20:42:09 UTC
Created attachment 183107 [details] [review]
Bug 6473: Test git-bz after bugzilla update
Comment 290 Chris Cormack 2025-06-11 20:44:18 UTC
Created attachment 183177 [details] [review]
Bug 6473: Test git-bz after bugzilla update
Comment 291 Chris Cormack 2025-06-11 21:23:41 UTC
Created attachment 183178 [details] [review]
Bug 6473: Test git-bz after bugzilla update
Comment 292 Chris Cormack 2025-06-11 21:28:08 UTC
Created attachment 183179 [details] [review]
Bug 6473: Test git-bz after bugzilla update
Comment 293 Chris Cormack 2025-06-11 21:28:48 UTC
Created attachment 183180 [details] [review]
Bug 6473: Test git-bz after bugzilla update
Comment 294 Martin Renvoize (ashimema) 2025-06-12 05:38:36 UTC
Testing for David
Comment 295 Martin Renvoize (ashimema) 2025-06-12 06:20:18 UTC
and again
Comment 296 Chris Cormack 2025-06-12 06:29:13 UTC
Created attachment 183182 [details] [review]
Bug 6473: Test git-bz after bugzilla update
Comment 297 Chris Cormack 2025-06-12 06:39:54 UTC
Created attachment 183183 [details] [review]
Bug 6473: Test git-bz after bugzilla update

https://bugs.koha-community.org/show_bug.cgi?id=6743
Comment 298 Roman Dolny 2025-06-16 14:28:42 UTC
Created attachment 183285 [details] [review]
Bug 6473: Test git-bz after bugzilla update

https://bugs.koha-community.org/show_bug.cgi?id=6743
Comment 299 Wojciech 2025-06-16 14:33:04 UTC
Created attachment 183286 [details] [review]
Bug 6473: Test git-bz after bugzilla update

https://bugs.koha-community.org/show_bug.cgi?id=6743
Signed-off-by: John Doe <you@example.com>
Comment 300 Philip Orr 2025-10-01 15:40:19 UTC
Created attachment 187209 [details] [review]
Bug 6473: Test git-bz after bugzilla update

https://bugs.koha-community.org/show_bug.cgi?id=6743
Signed-off-by: John Doe <you@example.com>
Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 301 Tomás Cohen Arazi (tcohen) 2025-10-02 20:27:59 UTC Comment hidden (obsolete)
Comment 302 Tomás Cohen Arazi (tcohen) 2025-10-02 20:28:01 UTC Comment hidden (obsolete)
Comment 303 Tomás Cohen Arazi (tcohen) 2025-10-02 20:28:04 UTC Comment hidden (obsolete)
Comment 304 Tomás Cohen Arazi (tcohen) 2025-10-02 20:28:06 UTC Comment hidden (obsolete)
Comment 305 Tomás Cohen Arazi (tcohen) 2025-10-02 20:28:08 UTC Comment hidden (obsolete)
Comment 306 Tomás Cohen Arazi (tcohen) 2025-10-02 20:28:10 UTC Comment hidden (obsolete)
Comment 307 Tomás Cohen Arazi (tcohen) 2025-10-02 20:28:13 UTC Comment hidden (obsolete)
Comment 308 Tomás Cohen Arazi (tcohen) 2025-10-02 20:54:35 UTC Comment hidden (obsolete)
Comment 309 Tomás Cohen Arazi (tcohen) 2025-10-02 20:54:37 UTC Comment hidden (obsolete)
Comment 310 Tomás Cohen Arazi (tcohen) 2025-10-02 20:54:40 UTC Comment hidden (obsolete)
Comment 311 Tomás Cohen Arazi (tcohen) 2025-10-02 20:54:42 UTC
Created attachment 187331 [details] [review]
Bug 38201: Avoid parseFloat when value is an empty string

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 312 Tomás Cohen Arazi (tcohen) 2025-10-02 21:04:00 UTC
Created attachment 187332 [details] [review]
Bug 38201: Fix Dataproviders_spec.ts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Status: Needs Signoff
Patch-complexity: String patch
Comment 313 Tomás Cohen Arazi (tcohen) 2025-10-02 21:04:03 UTC
Created attachment 187333 [details] [review]
Bug 38201: Remove DT warnings from Cypress tests

(cherry picked from commit b2a779e12f3ae23e10cba6177f248e12263306f8)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 314 Tomás Cohen Arazi (tcohen) 2025-10-02 21:04:05 UTC
Created attachment 187334 [details] [review]
Bug 38201: Remove discarded params error from DataProviders

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 315 Tomás Cohen Arazi (tcohen) 2025-10-02 21:04:07 UTC
Created attachment 187335 [details] [review]
Bug 38201: Avoid parseFloat when value is an empty string

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 316 Tomás Cohen Arazi (tcohen) 2025-10-02 21:05:09 UTC
Created attachment 187336 [details] [review]
Bug 38201: Fix Dataproviders_spec.ts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 317 Tomás Cohen Arazi (tcohen) 2025-10-02 21:05:12 UTC
Created attachment 187337 [details] [review]
Bug 38201: Remove DT warnings from Cypress tests

(cherry picked from commit b2a779e12f3ae23e10cba6177f248e12263306f8)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 318 Tomás Cohen Arazi (tcohen) 2025-10-02 21:05:14 UTC
Created attachment 187338 [details] [review]
Bug 38201: Remove discarded params error from DataProviders

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 319 Tomás Cohen Arazi (tcohen) 2025-10-02 21:06:38 UTC
Created attachment 187339 [details] [review]
Use GET for the login endpoint

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 320 Tomás Cohen Arazi (tcohen) 2025-10-02 21:07:15 UTC
Created attachment 187340 [details] [review]
Bug 38201: Fix Dataproviders_spec.ts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 321 Tomás Cohen Arazi (tcohen) 2025-10-02 21:07:18 UTC
Created attachment 187341 [details] [review]
Bug 38201: Remove DT warnings from Cypress tests

(cherry picked from commit b2a779e12f3ae23e10cba6177f248e12263306f8)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 322 Tomás Cohen Arazi (tcohen) 2025-10-02 21:07:20 UTC
Created attachment 187342 [details] [review]
Bug 38201: Remove discarded params error from DataProviders

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 323 Tomás Cohen Arazi (tcohen) 2025-10-02 21:10:24 UTC
Created attachment 187343 [details] [review]
Bug 38201: Fix Dataproviders_spec.ts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Status: Needs Signoff
Patch-complexity: Medium patch
Comment 324 Tomás Cohen Arazi (tcohen) 2025-10-02 21:10:26 UTC
Created attachment 187344 [details] [review]
Bug 38201: Remove DT warnings from Cypress tests

(cherry picked from commit b2a779e12f3ae23e10cba6177f248e12263306f8)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 325 Tomás Cohen Arazi (tcohen) 2025-10-02 21:10:28 UTC
Created attachment 187345 [details] [review]
Bug 38201: Remove discarded params error from DataProviders

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 326 Tomás Cohen Arazi (tcohen) 2025-10-02 21:12:03 UTC
Created attachment 187346 [details] [review]
Bug 38201: Fix Dataproviders_spec.ts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 327 Tomás Cohen Arazi (tcohen) 2025-10-02 21:12:06 UTC
Created attachment 187347 [details] [review]
Bug 38201: Remove DT warnings from Cypress tests

(cherry picked from commit b2a779e12f3ae23e10cba6177f248e12263306f8)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 328 Tomás Cohen Arazi (tcohen) 2025-10-02 21:12:08 UTC
Created attachment 187348 [details] [review]
Bug 38201: Remove discarded params error from DataProviders

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 329 Tomás Cohen Arazi (tcohen) 2025-10-03 02:07:32 UTC
Created attachment 187349 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Status: Needs Signoff
Patch-complexity: ---
Comment 330 Tomás Cohen Arazi (tcohen) 2025-10-03 02:13:06 UTC
Created attachment 187350 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 331 Tomás Cohen Arazi (tcohen) 2025-10-03 02:13:08 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 332 Tomás Cohen Arazi (tcohen) 2025-10-03 02:14:37 UTC
Created attachment 187351 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 333 Tomás Cohen Arazi (tcohen) 2025-10-03 02:15:53 UTC
Created attachment 187352 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 334 Tomás Cohen Arazi (tcohen) 2025-10-03 02:15:55 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 335 Tomás Cohen Arazi (tcohen) 2025-10-03 02:17:17 UTC
Created attachment 187353 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 336 Tomás Cohen Arazi (tcohen) 2025-10-03 02:17:20 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 337 Tomás Cohen Arazi (tcohen) 2025-10-03 02:18:05 UTC
Created attachment 187354 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 338 Tomás Cohen Arazi (tcohen) 2025-10-03 02:18:07 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 339 Tomás Cohen Arazi (tcohen) 2025-10-03 02:21:23 UTC
Created attachment 187355 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 340 Tomás Cohen Arazi (tcohen) 2025-10-03 02:21:25 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 341 Tomás Cohen Arazi (tcohen) 2025-10-03 02:25:36 UTC
Created attachment 187356 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 342 Tomás Cohen Arazi (tcohen) 2025-10-03 02:25:38 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 343 Tomás Cohen Arazi (tcohen) 2025-10-03 02:30:08 UTC
Created attachment 187357 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 344 Tomás Cohen Arazi (tcohen) 2025-10-03 02:32:06 UTC
Created attachment 187358 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 345 Tomás Cohen Arazi (tcohen) 2025-10-03 02:32:08 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 346 Tomás Cohen Arazi (tcohen) 2025-10-03 02:33:58 UTC
Created attachment 187359 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 347 Tomás Cohen Arazi (tcohen) 2025-10-03 02:34:00 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 348 Tomás Cohen Arazi (tcohen) 2025-10-03 02:55:07 UTC
Created attachment 187360 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 349 Tomás Cohen Arazi (tcohen) 2025-10-03 02:55:10 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 350 Tomás Cohen Arazi (tcohen) 2025-10-03 02:57:03 UTC
Created attachment 187361 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 351 Tomás Cohen Arazi (tcohen) 2025-10-03 03:00:15 UTC
Created attachment 187362 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 352 Tomás Cohen Arazi (tcohen) 2025-10-03 03:00:17 UTC
Created attachment 187363 [details] [review]
Improve feature coverage

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 353 Tomás Cohen Arazi (tcohen) 2025-10-03 03:02:06 UTC
Created attachment 187364 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 354 Tomás Cohen Arazi (tcohen) 2025-10-03 03:02:08 UTC
Created attachment 187365 [details] [review]
Improve feature coverage

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 355 Tomás Cohen Arazi (tcohen) 2025-10-03 03:11:14 UTC
Created attachment 187366 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 356 Tomás Cohen Arazi (tcohen) 2025-10-03 03:15:38 UTC
Created attachment 187367 [details] [review]
GitBz::Bug introduced

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 357 Tomás Cohen Arazi (tcohen) 2025-10-03 03:15:40 UTC
Created attachment 187368 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 358 Tomás Cohen Arazi (tcohen) 2025-10-03 03:17:45 UTC
Created attachment 187369 [details] [review]
GitBz::Bug introduced

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 359 Tomás Cohen Arazi (tcohen) 2025-10-03 03:17:47 UTC
Created attachment 187370 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 360 Tomás Cohen Arazi (tcohen) 2025-10-03 03:17:50 UTC
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 361 Tomás Cohen Arazi (tcohen) 2025-10-03 03:20:38 UTC
Created attachment 187371 [details] [review]
GitBz::Bug introduced

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 362 Tomás Cohen Arazi (tcohen) 2025-10-03 03:20:40 UTC
Created attachment 187372 [details] [review]
Fix case when range is HEAD

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 363 Tomás Cohen Arazi (tcohen) 2025-10-07 19:07:00 UTC
Created attachment 187545 [details] [review]
[#1] Fix attachment upload order

Attachments were being uploaded in reverse chronological order (newest first),
which breaks sequential patch application. Added --reverse flag to git rev-list
to ensure commits are returned in chronological order (oldest first).
- GitBz::Git->rev_list(): Add --reverse flag for chronological ordering
- t/attach_order.t: Test demonstrating issue and expected behavior
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 364 Tomás Cohen Arazi (tcohen) 2025-10-07 19:07:02 UTC
Created attachment 187546 [details] [review]
Latest Perl is 5.42

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 365 Tomás Cohen Arazi (tcohen) 2025-10-07 19:07:05 UTC
Attachments were being uploaded in reverse chronological order (newest first),
which breaks sequential patch application. Added --reverse flag to git rev-list
to ensure commits are returned in chronological order (oldest first).
- GitBz::Git->rev_list(): Add --reverse flag for chronological ordering
- t/attach_order.t: Test demonstrating issue and expected behavior
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 366 Tomás Cohen Arazi (tcohen) 2025-10-29 20:43:31 UTC
Created attachment 188609 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers

This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 367 Tomás Cohen Arazi (tcohen) 2025-10-29 20:43:34 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 368 Tomás Cohen Arazi (tcohen) 2025-10-29 20:46:37 UTC
Created attachment 188610 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers
Comment 369 Tomás Cohen Arazi (tcohen) 2025-10-29 20:50:11 UTC
Created attachment 188611 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers
Comment 370 Tomás Cohen Arazi (tcohen) 2025-10-29 20:52:52 UTC
Created attachment 188612 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers

This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 371 Tomás Cohen Arazi (tcohen) 2025-10-29 20:52:54 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 372 Tomás Cohen Arazi (tcohen) 2025-10-29 20:55:07 UTC
Created attachment 188613 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers

This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 373 Tomás Cohen Arazi (tcohen) 2025-10-29 20:55:10 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 374 Tomás Cohen Arazi (tcohen) 2025-10-29 20:58:11 UTC
Created attachment 188614 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers

This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 375 Tomás Cohen Arazi (tcohen) 2025-10-29 20:58:13 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 376 Tomás Cohen Arazi (tcohen) 2025-10-30 11:27:58 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 377 Tomás Cohen Arazi (tcohen) 2025-10-30 11:30:24 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 378 Tomás Cohen Arazi (tcohen) 2025-10-30 11:32:03 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 379 Tomás Cohen Arazi (tcohen) 2025-10-30 11:33:27 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 380 Tomás Cohen Arazi (tcohen) 2025-10-30 11:40:06 UTC
Created attachment 188626 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers
Comment 381 Tomás Cohen Arazi (tcohen) 2025-10-30 11:41:55 UTC
Created attachment 188627 [details] [review]
Bug 40841: Add limits configuration UI
Comment 382 Tomás Cohen Arazi (tcohen) 2025-10-30 11:41:58 UTC
Created attachment 188628 [details] [review]
Bug 40841: Implement library limits on Z39.50 searches
Comment 383 Tomás Cohen Arazi (tcohen) 2025-10-30 11:48:56 UTC
Created attachment 188629 [details] [review]
Bug 40841: Add limits configuration UI
Comment 384 Tomás Cohen Arazi (tcohen) 2025-10-30 11:48:59 UTC
Created attachment 188630 [details] [review]
Bug 40841: Implement library limits on Z39.50 searches
Comment 385 Tomás Cohen Arazi (tcohen) 2025-10-30 11:49:02 UTC
This patch adds branch limits selection to the Z30.50/SRU configuration
page.
Comment 386 Tomás Cohen Arazi (tcohen) 2025-10-30 11:57:38 UTC
Created attachment 188631 [details] [review]
Bug 40841: Add limits configuration UI

This is a comment.
Comment 387 Tomás Cohen Arazi (tcohen) 2025-10-30 11:57:40 UTC
Created attachment 188632 [details] [review]
Bug 40841: Implement library limits on Z39.50 searches

This patchset implements Z39.50/SRU limits by branch in Koha.

Key implementation notes:
- Follows Koha's established pattern for library limits
- A new table linking to library limits is added
- The admin UI is adjusted so the form includes library limit selection
- Z39.50/SRU search controllers use the `search_with_library_limits`
  methods to correctly constraint the offered servers.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ updatedatabase
=> SUCCESS: Database upgrade goes well
3. Re-run:
  k$ updatedatabase
=> SUCCESS: No explosions, DB update idempotent
4. Restart everything:
  k$ restart_all
5. POint your browser to the admin page:
   http://kohadev-intra.localhost/cgi-bin/koha/admin/z3950servers.pl
=> SUCCESS: A new column is displayed for library limits brief
6. Edit `LIBRARY OF CONGRESS`
=> SUCCESS: The form includes the usual library limit selection UI
7. Choose some branches, excluding your current one (KTD's default is
   'Centerville').
8. Save
=> SUCCESS: It is saved correctly
=> SUCCESS: The table shows the edited library has the library limits
set
9. Edit again
=> SUCCESS: The selected limits are preserved when editing
10. Pick some authorities Z39.50 target, and exclude your current branch
    for testing purposes.
11. Go to Cataloguing, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
12. Go to Authorities, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
13. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 388 Tomás Cohen Arazi (tcohen) 2025-10-30 11:57:43 UTC
This is a comment.
Comment 389 Tomás Cohen Arazi (tcohen) 2025-10-30 12:04:21 UTC
Created attachment 188633 [details] [review]
Bug 40841: Add limits configuration UI

This patch adds branch limits selection to the Z30.50/SRU configuration
page.

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 390 Tomás Cohen Arazi (tcohen) 2025-10-30 12:04:23 UTC
Created attachment 188634 [details] [review]
Bug 40841: Implement library limits on Z39.50 searches

This patchset implements Z39.50/SRU limits by branch in Koha.

Key implementation notes:
- Follows Koha's established pattern for library limits
- A new table linking to library limits is added
- The admin UI is adjusted so the form includes library limit selection
- Z39.50/SRU search controllers use the `search_with_library_limits`
  methods to correctly constraint the offered servers.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ updatedatabase
=> SUCCESS: Database upgrade goes well
3. Re-run:
  k$ updatedatabase
=> SUCCESS: No explosions, DB update idempotent
4. Restart everything:
  k$ restart_all
5. POint your browser to the admin page:
   http://kohadev-intra.localhost/cgi-bin/koha/admin/z3950servers.pl
=> SUCCESS: A new column is displayed for library limits brief
6. Edit `LIBRARY OF CONGRESS`
=> SUCCESS: The form includes the usual library limit selection UI
7. Choose some branches, excluding your current one (KTD's default is
   'Centerville').
8. Save
=> SUCCESS: It is saved correctly
=> SUCCESS: The table shows the edited library has the library limits
set
9. Edit again
=> SUCCESS: The selected limits are preserved when editing
10. Pick some authorities Z39.50 target, and exclude your current branch
    for testing purposes.
11. Go to Cataloguing, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
12. Go to Authorities, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
13. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 391 Tomás Cohen Arazi (tcohen) 2025-10-30 12:04:25 UTC
This is another comment to be added.
Comment 392 Tomás Cohen Arazi (tcohen) 2025-10-30 13:23:06 UTC
Created attachment 188645 [details] [review]
Bug 40841: Implement library limits on Z39.50 searches

This patchset implements Z39.50/SRU limits by branch in Koha.

Key implementation notes:
- Follows Koha's established pattern for library limits
- A new table linking to library limits is added
- The admin UI is adjusted so the form includes library limit selection
- Z39.50/SRU search controllers use the `search_with_library_limits`
  methods to correctly constraint the offered servers.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ updatedatabase
=> SUCCESS: Database upgrade goes well
3. Re-run:
  k$ updatedatabase
=> SUCCESS: No explosions, DB update idempotent
4. Restart everything:
  k$ restart_all
5. POint your browser to the admin page:
   http://kohadev-intra.localhost/cgi-bin/koha/admin/z3950servers.pl
=> SUCCESS: A new column is displayed for library limits brief
6. Edit `LIBRARY OF CONGRESS`
=> SUCCESS: The form includes the usual library limit selection UI
7. Choose some branches, excluding your current one (KTD's default is
   'Centerville').
8. Save
=> SUCCESS: It is saved correctly
=> SUCCESS: The table shows the edited library has the library limits
set
9. Edit again
=> SUCCESS: The selected limits are preserved when editing
10. Pick some authorities Z39.50 target, and exclude your current branch
    for testing purposes.
11. Go to Cataloguing, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
12. Go to Authorities, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
13. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 393 Tomás Cohen Arazi (tcohen) 2025-10-30 13:33:31 UTC
Created attachment 188647 [details] [review]
Bug 40841: Implement library limits on Z39.50 searches

This patchset implements Z39.50/SRU limits by branch in Koha.

Key implementation notes:
- Follows Koha's established pattern for library limits
- A new table linking to library limits is added
- The admin UI is adjusted so the form includes library limit selection
- Z39.50/SRU search controllers use the `search_with_library_limits`
  methods to correctly constraint the offered servers.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ updatedatabase
=> SUCCESS: Database upgrade goes well
3. Re-run:
  k$ updatedatabase
=> SUCCESS: No explosions, DB update idempotent
4. Restart everything:
  k$ restart_all
5. POint your browser to the admin page:
   http://kohadev-intra.localhost/cgi-bin/koha/admin/z3950servers.pl
=> SUCCESS: A new column is displayed for library limits brief
6. Edit `LIBRARY OF CONGRESS`
=> SUCCESS: The form includes the usual library limit selection UI
7. Choose some branches, excluding your current one (KTD's default is
   'Centerville').
8. Save
=> SUCCESS: It is saved correctly
=> SUCCESS: The table shows the edited library has the library limits
set
9. Edit again
=> SUCCESS: The selected limits are preserved when editing
10. Pick some authorities Z39.50 target, and exclude your current branch
    for testing purposes.
11. Go to Cataloguing, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
12. Go to Authorities, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
13. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 394 Tomás Cohen Arazi (tcohen) 2025-10-30 17:49:57 UTC
Created attachment 188703 [details] [review]
Bug 40841: Implement library limits on Z39.50 searches

This patchset implements Z39.50/SRU limits by branch in Koha.

Key implementation notes:
- Follows Koha's established pattern for library limits
- A new table linking to library limits is added
- The admin UI is adjusted so the form includes library limit selection
- Z39.50/SRU search controllers use the `search_with_library_limits`
  methods to correctly constraint the offered servers.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ updatedatabase
=> SUCCESS: Database upgrade goes well
3. Re-run:
  k$ updatedatabase
=> SUCCESS: No explosions, DB update idempotent
4. Restart everything:
  k$ restart_all
5. POint your browser to the admin page:
   http://kohadev-intra.localhost/cgi-bin/koha/admin/z3950servers.pl
=> SUCCESS: A new column is displayed for library limits brief
6. Edit `LIBRARY OF CONGRESS`
=> SUCCESS: The form includes the usual library limit selection UI
7. Choose some branches, excluding your current one (KTD's default is
   'Centerville').
8. Save
=> SUCCESS: It is saved correctly
=> SUCCESS: The table shows the edited library has the library limits
set
9. Edit again
=> SUCCESS: The selected limits are preserved when editing
10. Pick some authorities Z39.50 target, and exclude your current branch
    for testing purposes.
11. Go to Cataloguing, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
12. Go to Authorities, and choose 'New from Z39.50/SRU'
=> SUCCESS: Limits are respected!
13. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 395 Jonathan Druart 2025-11-03 13:33:11 UTC
Created attachment 188929 [details] [review]
Bug 6473: test ✔ ❤ ★

Tomás Cohen Arazi <tomascohen@theke.io>
Comment 396 Tomás Cohen Arazi (tcohen) 2025-11-03 14:27:22 UTC
Created attachment 188937 [details] [review]
Bug 39320: Fix ERM breadcrumb causing page reload

The main ERM route was missing a 'name' property, causing the
navigation store to treat it as an external path (.pl extension).
This resulted in breadcrumb links using href instead of router-link,
causing unwanted page reloads.

To test:
1. Navigate to ERM module
2. Go to any sub-section (Agreements, Licenses, etc.)
3. Click on 'E-resource management' in the breadcrumb
=> FAIL: Notice the page reloads!
4. Apply the patch
5. Repeat steps 1-3
=> SUCCES: Verify the page doesn't reload and navigation works smoothly
6. Sign off :-D

ç

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 397 Tomás Cohen Arazi (tcohen) 2025-11-03 14:53:19 UTC
Created attachment 188975 [details] [review]
Bug 39320: Fix ERM breadcrumb causing page reload

The main ERM route was missing a 'name' property, causing the
navigation store to treat it as an external path (.pl extension).
This resulted in breadcrumb links using href instead of router-link,
causing unwanted page reloads.

To test:
1. Navigate to ERM module
2. Go to any sub-section (Agreements, Licenses, etc.)
3. Click on 'E-resource management' in the breadcrumb
=> FAIL: Notice the page reloads!
4. Apply the patch
5. Repeat steps 1-3
=> SUCCES: Verify the page doesn't reload and navigation works smoothly
6. Sign off :-D

ç

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 398 Tomás Cohen Arazi (tcohen) 2025-11-03 17:00:57 UTC
With a new line.
And then two lines at the end. And án UTF-8 char
Comment 399 Chris Cormack 2025-11-20 23:21:28 UTC
Test comment
Comment 400 Chris Cormack 2025-11-20 23:21:53 UTC
Automatic patch test results:

â ï¸ The patch applies with fuzzy option (ignoring whitespace).
This may indicate minor conflicts that need to be resolved.

Details: Patch applies with fuzzy option (ignoring whitespace)

This is an automated message from the patch testing system.
Comment 401 Chris Cormack 2025-11-21 20:48:20 UTC
Automatic patch test results:

â Good news! The patch applies cleanly to the current master branch.

Details: Patch applies cleanly

This is an automated message from the patch testing system.
Comment 402 Chris Cormack 2025-11-21 20:54:37 UTC
Automated patch testing results:

â **PATCH DOES NOT APPLY**

One or more patches do not apply cleanly to the current codebase.
Please rebase your patches and upload new versions.

**Patch Results:**

â **48caf81.patch** (ID: 188975)
   Status: FAILURE
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   â Patch does not apply
   Error: error: patch failed: koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Home.vue:18

â **Bug-6473-test---.patch** (ID: 188929)
   Status: SUCCESS
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   â Patch applies cleanly

â **cb04b93.patch** (ID: 188703)
   Status: FAILURE
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   â Patch does not apply
   Error: error: patch failed: cataloguing/editor.pl:78

â **cb0bbc8.patch** (ID: 188633)
   Status: SUCCESS
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   â Patch applies cleanly

**Dependencies:** 23456, 41098


---
This is an automated message from the patch testing system.
Tested against branch: main
Comment 403 Chris Cormack 2025-11-21 20:57:51 UTC
Automated patch testing results:

[FAIL] PATCH DOES NOT APPLY

One or more patches do not apply cleanly to the current codebase.
Please rebase your patches and upload new versions.

**Patch Results:**

[FAIL] 48caf81.patch (ID: 188975)
   Status: FAILURE
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   - Patch does not apply
   Error: error: patch failed: koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Home.vue:18

[PASS] Bug-6473-test---.patch (ID: 188929)
   Status: SUCCESS
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   + Patch applies cleanly

[FAIL] cb04b93.patch (ID: 188703)
   Status: FAILURE
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   - Patch does not apply
   Error: error: patch failed: cataloguing/editor.pl:78

[PASS] cb0bbc8.patch (ID: 188633)
   Status: SUCCESS
   Dependencies failed: 23456 (no patches), 41098 (no patches)
   + Patch applies cleanly

**Dependencies:** 23456, 41098


---
This is an automated message from the patch testing system.
Tested against branch: main
Comment 404 Tomás Cohen Arazi (tcohen) 2025-12-04 19:06:22 UTC
Created attachment 190164 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 405 Tomás Cohen Arazi (tcohen) 2025-12-04 19:14:39 UTC
Created attachment 190165 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 406 Tomás Cohen Arazi (tcohen) 2025-12-04 19:14:42 UTC
Created attachment 190166 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 407 Tomás Cohen Arazi (tcohen) 2025-12-04 19:25:58 UTC
Created attachment 190167 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 408 Tomás Cohen Arazi (tcohen) 2025-12-04 19:26:00 UTC
Created attachment 190168 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 409 Tomás Cohen Arazi (tcohen) 2025-12-04 19:27:52 UTC
Created attachment 190169 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 410 Tomás Cohen Arazi (tcohen) 2025-12-04 19:27:58 UTC
Created attachment 190170 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 411 Tomás Cohen Arazi (tcohen) 2025-12-04 19:31:48 UTC
This is a comment. It is indended to be really long so it overflows a table width. The longer the better. Really hope this doesn't fit in the column space :-D
Comment 412 Tomás Cohen Arazi (tcohen) 2025-12-04 19:31:56 UTC
Created attachment 190171 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 413 Tomás Cohen Arazi (tcohen) 2025-12-04 19:31:58 UTC
Created attachment 190172 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 414 Tomás Cohen Arazi (tcohen) 2025-12-04 19:35:09 UTC
This is really a comment
Comment 415 Tomás Cohen Arazi (tcohen) 2025-12-04 19:35:17 UTC
Created attachment 190173 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 416 Tomás Cohen Arazi (tcohen) 2025-12-04 19:35:20 UTC
Created attachment 190174 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 417 Tomás Cohen Arazi (tcohen) 2025-12-04 19:36:52 UTC
Created attachment 190175 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 418 Tomás Cohen Arazi (tcohen) 2025-12-04 19:36:54 UTC
Created attachment 190176 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 419 Tomás Cohen Arazi (tcohen) 2025-12-04 19:40:38 UTC
Created attachment 190177 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 420 Tomás Cohen Arazi (tcohen) 2025-12-04 19:40:40 UTC
Created attachment 190178 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 421 Tomás Cohen Arazi (tcohen) 2025-12-04 19:42:06 UTC
Created attachment 190179 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 422 Tomás Cohen Arazi (tcohen) 2025-12-04 19:42:09 UTC
Created attachment 190180 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 423 Tomás Cohen Arazi (tcohen) 2025-12-04 19:43:31 UTC
Created attachment 190181 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 424 Tomás Cohen Arazi (tcohen) 2025-12-04 19:43:33 UTC
Created attachment 190182 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 425 Tomás Cohen Arazi (tcohen) 2025-12-04 19:46:07 UTC
Created attachment 190183 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 426 Tomás Cohen Arazi (tcohen) 2025-12-04 19:46:09 UTC
Created attachment 190184 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 427 Tomás Cohen Arazi (tcohen) 2025-12-04 19:47:46 UTC
Created attachment 190185 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 428 Tomás Cohen Arazi (tcohen) 2025-12-04 19:47:48 UTC
Created attachment 190186 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 429 Tomás Cohen Arazi (tcohen) 2025-12-04 19:58:44 UTC
Created attachment 190187 [details] [review]
Bug 40446: Allow overriding Cypress DB settings

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 430 Tomás Cohen Arazi (tcohen) 2025-12-04 19:58:46 UTC
Created attachment 190188 [details] [review]
Bug 40989: Fix OAI-PMH tests for CGI.pm 4.68+

CGI.pm 4.68 (shipped with Debian 13/Trixie) changed the behavior of
self_url() to include a trailing slash when there's no path component.
This causes OAI-PMH tests to fail as they expect URLs without trailing
slashes.

This patch strips the trailing slash from both the requestURL field in
OAI responses and the baseURL field in Identify responses to maintain
compatibility across CGI.pm versions.

Test plan:
1. Start a 'trixie' KTD:
   $ KOHA_IMAGE=main-trixie ktd --proxy --name trixie up -d
   $ ktd --name trixie --wait-ready 120
2. Run the tests:
   $ ktd --name trixie --shell
  k$ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail!
3. Apply this patch
5. Repeat 2
6. Repeat 1-2 with a 'bookworm' image
=> SUCCESS: Tests pass too!
7. Sign off :-D
Comment 431 Tomás Cohen Arazi (tcohen) 2025-12-05 17:22:49 UTC
Created attachment 190240 [details] [review]
Bug 40524: Update print format to use built-in formatter

This change updates the print format to use the built-in formatter
for operations like trim, strip HTML, strip newlines, and not
decoding entities.

Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1
2. Click "add to basket"
3. Type "test" next to "From an existing record" and click "Submit"
4. On the "Gairm" row, click "Add order"
5. Fill in the required fields
6. In the "Internal note" put the following:
abc123
7. Click "Save"
8. In the Orders table, click "Export" and then "Print"
9. Note that the print page loads correctly, you can see the internal note,
and you cannot see lines for "Add internal note",
"Edit internal note", or "Add vendor note"

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 432 Tomás Cohen Arazi (tcohen) 2025-12-05 17:22:51 UTC
Created attachment 190241 [details] [review]
Bug 40041: (follow-up) Fix periods and add Robert Fox

We introduced some errant periods in the mailmap which cause parsing
issues.

I also fix the removal of the '=' author by replacing it with a mapping
to the original author of the patch from bug 6979, Robert Fox

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 433 Tomás Cohen Arazi (tcohen) 2025-12-05 17:24:27 UTC
Created attachment 190242 [details] [review]
Bug 40524: Update print format to use built-in formatter

This change updates the print format to use the built-in formatter
for operations like trim, strip HTML, strip newlines, and not
decoding entities.

Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1
2. Click "add to basket"
3. Type "test" next to "From an existing record" and click "Submit"
4. On the "Gairm" row, click "Add order"
5. Fill in the required fields
6. In the "Internal note" put the following:
abc123
7. Click "Save"
8. In the Orders table, click "Export" and then "Print"
9. Note that the print page loads correctly, you can see the internal note,
and you cannot see lines for "Add internal note",
"Edit internal note", or "Add vendor note"

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 434 Tomás Cohen Arazi (tcohen) 2025-12-05 17:24:30 UTC
Created attachment 190243 [details] [review]
Bug 40041: (follow-up) Fix periods and add Robert Fox

We introduced some errant periods in the mailmap which cause parsing
issues.

I also fix the removal of the '=' author by replacing it with a mapping
to the original author of the patch from bug 6979, Robert Fox

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 435 Tomás Cohen Arazi (tcohen) 2025-12-05 17:29:19 UTC
Created attachment 190244 [details] [review]
Bug 40524: Update print format to use built-in formatter

This change updates the print format to use the built-in formatter
for operations like trim, strip HTML, strip newlines, and not
decoding entities.

Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1
2. Click "add to basket"
3. Type "test" next to "From an existing record" and click "Submit"
4. On the "Gairm" row, click "Add order"
5. Fill in the required fields
6. In the "Internal note" put the following:
abc123
7. Click "Save"
8. In the Orders table, click "Export" and then "Print"
9. Note that the print page loads correctly, you can see the internal note,
and you cannot see lines for "Add internal note",
"Edit internal note", or "Add vendor note"

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 436 Tomás Cohen Arazi (tcohen) 2025-12-05 17:29:22 UTC
Created attachment 190245 [details] [review]
Bug 40041: (follow-up) Fix periods and add Robert Fox

We introduced some errant periods in the mailmap which cause parsing
issues.

I also fix the removal of the '=' author by replacing it with a mapping
to the original author of the patch from bug 6979, Robert Fox

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 437 Tomás Cohen Arazi (tcohen) 2025-12-05 17:44:16 UTC
Created attachment 190246 [details] [review]
Bug 40524: Update print format to use built-in formatter

This change updates the print format to use the built-in formatter
for operations like trim, strip HTML, strip newlines, and not
decoding entities.

Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1
2. Click "add to basket"
3. Type "test" next to "From an existing record" and click "Submit"
4. On the "Gairm" row, click "Add order"
5. Fill in the required fields
6. In the "Internal note" put the following:
abc123
7. Click "Save"
8. In the Orders table, click "Export" and then "Print"
9. Note that the print page loads correctly, you can see the internal note,
and you cannot see lines for "Add internal note",
"Edit internal note", or "Add vendor note"

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 438 Tomás Cohen Arazi (tcohen) 2025-12-05 17:44:19 UTC
Created attachment 190247 [details] [review]
Bug 40041: (follow-up) Fix periods and add Robert Fox

We introduced some errant periods in the mailmap which cause parsing
issues.

I also fix the removal of the '=' author by replacing it with a mapping
to the original author of the patch from bug 6979, Robert Fox

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 439 Tomás Cohen Arazi (tcohen) 2025-12-05 17:47:14 UTC
Created attachment 190248 [details] [review]
Bug 40524: Update print format to use built-in formatter

This change updates the print format to use the built-in formatter
for operations like trim, strip HTML, strip newlines, and not
decoding entities.

Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1
2. Click "add to basket"
3. Type "test" next to "From an existing record" and click "Submit"
4. On the "Gairm" row, click "Add order"
5. Fill in the required fields
6. In the "Internal note" put the following:
abc123
7. Click "Save"
8. In the Orders table, click "Export" and then "Print"
9. Note that the print page loads correctly, you can see the internal note,
and you cannot see lines for "Add internal note",
"Edit internal note", or "Add vendor note"

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 440 Tomás Cohen Arazi (tcohen) 2025-12-05 17:47:16 UTC
Created attachment 190249 [details] [review]
Bug 40041: (follow-up) Fix periods and add Robert Fox

We introduced some errant periods in the mailmap which cause parsing
issues.

I also fix the removal of the '=' author by replacing it with a mapping
to the original author of the patch from bug 6979, Robert Fox

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 441 Tomás Cohen Arazi (tcohen) 2025-12-05 17:49:29 UTC
Created attachment 190250 [details] [review]
Bug 40524: Update print format to use built-in formatter

This change updates the print format to use the built-in formatter
for operations like trim, strip HTML, strip newlines, and not
decoding entities.

Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1
2. Click "add to basket"
3. Type "test" next to "From an existing record" and click "Submit"
4. On the "Gairm" row, click "Add order"
5. Fill in the required fields
6. In the "Internal note" put the following:
abc123
7. Click "Save"
8. In the Orders table, click "Export" and then "Print"
9. Note that the print page loads correctly, you can see the internal note,
and you cannot see lines for "Add internal note",
"Edit internal note", or "Add vendor note"

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 442 Tomás Cohen Arazi (tcohen) 2025-12-05 17:49:31 UTC
Created attachment 190251 [details] [review]
Bug 40041: (follow-up) Fix periods and add Robert Fox

We introduced some errant periods in the mailmap which cause parsing
issues.

I also fix the removal of the '=' author by replacing it with a mapping
to the original author of the patch from bug 6979, Robert Fox

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 443 Tomás Cohen Arazi (tcohen) 2025-12-05 20:13:13 UTC
Created attachment 190252 [details] [review]
Bug 40524: Update print format to use built-in formatter

This change updates the print format to use the built-in formatter
for operations like trim, strip HTML, strip newlines, and not
decoding entities.

Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1
2. Click "add to basket"
3. Type "test" next to "From an existing record" and click "Submit"
4. On the "Gairm" row, click "Add order"
5. Fill in the required fields
6. In the "Internal note" put the following:
abc123
7. Click "Save"
8. In the Orders table, click "Export" and then "Print"
9. Note that the print page loads correctly, you can see the internal note,
and you cannot see lines for "Add internal note",
"Edit internal note", or "Add vendor note"

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 444 Tomás Cohen Arazi (tcohen) 2025-12-05 20:13:16 UTC
Created attachment 190253 [details] [review]
Bug 40041: (follow-up) Fix periods and add Robert Fox

We introduced some errant periods in the mailmap which cause parsing
issues.

I also fix the removal of the '=' author by replacing it with a mapping
to the original author of the patch from bug 6979, Robert Fox

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 445 Lisette Scheer 2025-12-05 20:59:22 UTC
Created attachment 190255 [details] [review]
Bug 41364: Fix error in preservation module breadcrumb

This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors:

- Breadcrumb element empty
- Error in the browser console

To test:
1. Enable the Preservation module
2. Go to Home > Preservation > Settings
3. Use the 'Add a new processing' button
=> FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >)
4. Click on 'Edit this processing'
=> FAIL: Same error, different context
5. Check the browser console
=> FAIL: You see something like this:

```
[Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1
```

6. Run the cypress tests for this module:
  k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts
=> FAIL: The breadcrumb navigation is broken
7. Apply this patch
8. Rebuild things:
   $ ktd --shell
  k$ yarn build
9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows)
10. Repeat 2-6
=> SUCCESS: The breadcrumb is no longer broken
=> SUCCESS: No errors/warnings about this in the browser console
=> SUCCESS: Tests pass!
11. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 446 Lisette Scheer 2025-12-05 20:59:24 UTC
Created attachment 190256 [details] [review]
Bug 41142: Update jQuery-validate plugin to 1.21.0

This patch updates the jQuery validation plugin in both the staff
interface and the OPAC to the latest version, 1.21.0.

To test, apply the patch and clear your browser cache if necessary.

Test various pages in the staff client to confirm that form validation
works as expected:

 - Patron password change form:
   - Password must conform to minPasswordLength
   - Password must not contain leading/trailing spaces
   - Passwords must match

 - Administration -> Add or edit budget:
   - Description, start date, and end date are required
   - Start date must be before end date

 - Administration -> Add or edit Z39.50/SRU server:
   - Server name, hostname, port, and database are required
   - Port, rank, and timeout must be a number

Perform the same check of the "Change password" form in the OPAC.

Sponsored-by: Athens County Public Libraries
Comment 447 Lisette Scheer 2025-12-05 20:59:27 UTC
Bug 6473: Testing attach -e with new perl-git-bz



Testing new perl-git-bz edit function
Comment 448 Tomás Cohen Arazi (tcohen) 2025-12-24 13:50:27 UTC
Created attachment 190711 [details] [review]
[#36] Add iterative error handling for invalid QA contacts

When a user enters an invalid QA contact email (e.g., a typo or
non-existent user), the bug update would fail with a 404 error and
the spinner would hang indefinitely. This commit adds comprehensive
error handling with user search and iterative retry logic.

Changes:
- Added search_users() method to RestClient.pm to query Bugzilla's
  user API endpoint with authentication token
- Added select_qa_contact() method to Edit.pm and Attach.pm that:
  * Extracts the local part of the invalid email (before @)
  * Searches for similar users whose emails begin with that pattern
  * Presents a numbered list of matching users for selection
  * Allows manual entry if no matches found
- Implemented iterative retry loop in both Edit and Attach commands:
  * On 404 error, searches for similar users
  * User can select from results or enter a different email
  * If manually entered email also fails, searches again
  * Continues until successful update or user cancels
  * Properly stops spinner on each error before continuing

Example flow:
1. User enters "martinrenvoize@theke.io" → 404
2. Searches for "martinrenvoize" → no results
3. User enters "martin.renvoize@theke.io" → 404
4. Searches for "martin.renvoize" → finds matches
5. User selects "martin.renvoize@openfifth.co.uk" → success

This provides a much better user experience than the previous behavior
of hanging indefinitely with no feedback.
Comment 449 Tomás Cohen Arazi (tcohen) 2025-12-24 14:01:30 UTC
Created attachment 190712 [details] [review]
Bug 41432: Prefetch items and borrowers for holds

To test:
1 - Add a bunch of holds to a record
    https://github.com/kidclamp/handy-koha-script/blob/main/randhold.pl
2 - Enable profiling:
    https://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf#NYTProf_with_Plack
3 - Browse to the record and load the holds table
4 - View the flame graph for the request like instructions in #2
5 - Note that Koha::Hold->borrower and Koha::Hold->item take a lot of time
6 - Apply patch, restart all
7 - Reload page
8 - Reload flame graph
9 - Note time for fetching borrowers and items is significantly reduced
10 - Sing off!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>