Bug 15992 - Renaming 'Operations' column heading to 'Actions'
Summary: Renaming 'Operations' column heading to 'Actions'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-06 22:34 UTC by Aleisha Amohia
Modified: 2017-06-14 22:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15992: Moving item search fields actions into a drop-down menu (2.70 KB, patch)
2016-03-06 22:36 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15992: Moving item search fields actions into a drop-down menu (2.76 KB, patch)
2016-03-08 20:51 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 15992: Renaming 'Operations' column heading to 'Actions' (1.28 KB, patch)
2016-03-10 02:04 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15992: Renaming 'Operations' column heading to 'Actions' (1.40 KB, patch)
2016-03-10 02:11 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15992: Renaming 'Operations' column heading to 'Actions' (1.46 KB, patch)
2016-03-11 07:34 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-06 22:34:58 UTC
Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991
Comment 1 Aleisha Amohia 2016-03-06 22:36:17 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-08 20:51:50 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-09 12:06:53 UTC
You are loosing the confirmation and highlight made on bug 15887.
Comment 4 Aleisha Amohia 2016-03-10 02:04:57 UTC Comment hidden (obsolete)
Comment 5 Mark Tompsett 2016-03-10 02:11:41 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-03-10 11:58:37 UTC
Aleisha,
  seems to be the common way to "named" the actions column:

% git grep '<th>&nbsp;</th>' **/*.tt|wc
    127     339   13098
% git grep '<th>Actions</th>' **/*.tt|wc
     15      33    1485
Comment 7 Aleisha Amohia 2016-03-10 21:13:05 UTC
(In reply to Jonathan Druart from comment #6)
> Aleisha,
> &nbsp; seems to be the common way to "named" the actions column:
> 
> % git grep '<th>&nbsp;</th>' **/*.tt|wc
>     127     339   13098
> % git grep '<th>Actions</th>' **/*.tt|wc
>      15      33    1485

I think it tends to be that when the actions have been moved into a drop down menu, the column gets named &nbsp; because each drop down has Actions on it. But when there is no drop down and it is just buttons like this, the column name should be Actions.
Comment 8 Jonathan Druart 2016-03-11 07:34:38 UTC
Created attachment 48989 [details] [review]
Bug 15992: Renaming 'Operations' column heading to 'Actions'

to be consistent with other Administration tables
These actions were already made into buttons so will just make this small string change

To test:

1) Go to Admin -> Item search fields
2) Confirm column heading now reads 'Actions'

Sponsored-by: Catalyst IT

NOTE: Trivial string change, screen refresh confirms change.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2016-03-11 07:35:18 UTC
(In reply to Aleisha Amohia from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > Aleisha,
> > &nbsp; seems to be the common way to "named" the actions column:
> > 
> > % git grep '<th>&nbsp;</th>' **/*.tt|wc
> >     127     339   13098
> > % git grep '<th>Actions</th>' **/*.tt|wc
> >      15      33    1485
> 
> I think it tends to be that when the actions have been moved into a drop
> down menu, the column gets named &nbsp; because each drop down has Actions
> on it. But when there is no drop down and it is just buttons like this, the
> column name should be Actions.

Indeed, it makes sense! Thanks for the clarification :)
Comment 10 Brendan Gallagher 2016-03-12 23:27:45 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!