Unit Test t/00-testcritic.t fails to pass Perl::Critic on Test 221.
Created attachment 64090 [details] [review] Bug 18753 - t/00-testcritic fails Perl::Critic Bug Description: When performing a unit test on t/00-testcritic.t with the command 'prove t/00-testcritic.t' test 221 fails Perl::Critic with not ok 221 - Test::Perl::Critic for "reserve/request.pl" Failed test 'Test::Perl::Critic for "reserve/request.pl"' at /usr/share/perl5/Test/Perl/Critic.pm line 110. Perl::Critic found these violations in "reserve/request.pl": "$itemnumbers_of_biblioitem" is declared but not used at line 314, column 5. Unused variables clutter code and make it harder to read (Severity: 3) Cause of bug: The variable $itemnumbers_of_biblioitem is declared but never used in reserve/request.pl which causes the Perl::Critic violation. Patch Description: This patch removes the variable $itemnumbers_of_biblioitem from reserve/request.pl in order to satisfy Perl::Critic. The variable $itemnumbers_of_biblioitem is never used anywhere in reserve/request.pl other than its declaration so it should not cause any undesired effects. Test Plan: 1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'. 2) Test 221 fails. 3) Apply the patch. 4) Re-run 'prove t/00-testcritic.t'. 5) All of the tests pass now. 6) Quit out of koha-shell.
I think this is the wrong solution. The problem is that variable is used as a hash elsewhere. I think the problem is % vs $ not the variable name. Providing counter-patch.
Created attachment 64092 [details] [review] Bug 18753: t/00-testcritic.t fails TEST PLAN --------- $ export TEST_QA=1 $ sudo apt-get install libtest-perl-critic-perl $ prove t/00-testcritic.t -- test 221 will fail apply patch $ prove t/00-testcritic.t -- all tests will pass NOTE: Obsoleted Lee's patch.
Comment on attachment 64090 [details] [review] Bug 18753 - t/00-testcritic fails Perl::Critic There actually is a hash declaration version earlier! DOH! This is correct.
Created attachment 64093 [details] [review] Bug 18753 - t/00-testcritic fails Perl::Critic Bug Description: When performing a unit test on t/00-testcritic.t with the command 'prove t/00-testcritic.t' test 221 fails Perl::Critic with not ok 221 - Test::Perl::Critic for "reserve/request.pl" Failed test 'Test::Perl::Critic for "reserve/request.pl"' at /usr/share/perl5/Test/Perl/Critic.pm line 110. Perl::Critic found these violations in "reserve/request.pl": "$itemnumbers_of_biblioitem" is declared but not used at line 314, column 5. Unused variables clutter code and make it harder to read (Severity: 3) Cause of bug: The variable $itemnumbers_of_biblioitem is declared but never used in reserve/request.pl which causes the Perl::Critic violation. Patch Description: This patch removes the variable $itemnumbers_of_biblioitem from reserve/request.pl in order to satisfy Perl::Critic. The variable $itemnumbers_of_biblioitem is never used anywhere in reserve/request.pl other than its declaration so it should not cause any undesired effects. Test Plan: 1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'. 2) Test 221 fails. 3) Apply the patch. 4) Re-run 'prove t/00-testcritic.t'. 5) All of the tests pass now. 6) Quit out of koha-shell. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Sorry, missed that one. I have fixed it with commit b5b046599b6604c6cfd681d8392c560b3df738d2 Bug 18296: Remove perlcritic error (request.pl) *** This bug has been marked as a duplicate of bug 18296 ***