Bug 21699 - Allow circulation messages to be editable
Summary: Allow circulation messages to be editable
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement with 11 votes (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
: 31980 (view as bug list)
Depends on:
Blocks: 35626
  Show dependency treegraph
 
Reported: 2018-10-26 20:06 UTC by Kelly McElligott
Modified: 2023-12-21 11:30 UTC (History)
15 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/693
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 21699: Allow circulation messages to be editable (11.05 KB, patch)
2022-11-16 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 21699: Allow circulation messages to be editable (11.12 KB, patch)
2022-11-16 16:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 21699: Allow circulation messages to be editable (11.87 KB, patch)
2022-11-16 17:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 21699: Allow circulation messages to be editable (11.19 KB, patch)
2022-11-16 17:11 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 21699: Allow circulation messages to be editable (11.25 KB, patch)
2023-02-07 12:26 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 21699: Allow circulation messages to be editable (11.35 KB, patch)
2023-04-14 07:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2018-10-26 20:06:31 UTC
During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page.  It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message.
Comment 1 paxed 2018-10-29 10:51:12 UTC
Brainstorming:

"From what branch" or "who wrote the message", this could be handled with variable substitutions. For example, the text ${BRANCH} in the circulation message would be automatically replaced with the branch where the message was added, and ${USER} with the user (usually staff) name who added the message.
Comment 2 Lisette Scheer 2018-10-30 19:22:35 UTC
We would find this very helpful as well.
Comment 3 Barbara Johnson 2020-10-16 14:34:16 UTC
Being able to edit the messages would be a real timesaver. Sometimes we need to add additional information regarding an issue but since we can't edit the original message we have to create a new one. We can then end up with multiple messages on a patron account.  If the particular patron has a lot of stuff going on we then might end up with messages on different topics interspersed throughout the record.  Or there might be a typo (like a barcode or phone number) in the message and instead of being able to quickly fix it we have to delete the original message and re-input the information.  We'd welcome this functionality.
Comment 4 Amy Muchmore 2021-03-11 15:28:27 UTC
This would be very helpful and a real time saver for circulation staff.
Comment 5 Katrin Fischer 2022-10-25 21:14:10 UTC
*** Bug 31980 has been marked as a duplicate of this bug. ***
Comment 6 Kyle M Hall 2022-11-16 16:51:12 UTC
Created attachment 143959 [details] [review]
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page.  It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled
Comment 7 Kyle M Hall 2022-11-16 16:56:01 UTC
Created attachment 143960 [details] [review]
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page.  It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled
Comment 8 Kyle M Hall 2022-11-16 17:03:55 UTC
Created attachment 143961 [details] [review]
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page.  It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled
Comment 9 ByWater Sandboxes 2022-11-16 17:11:30 UTC
Created attachment 143962 [details] [review]
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page.  It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 10 Barbara Johnson 2022-11-16 17:13:09 UTC
This is a wonderful addition - works great.
Comment 11 Anthony Morris 2022-11-23 00:55:24 UTC
This will be very helpful for our circulation team!
Comment 12 Suzanne 2022-12-01 18:17:09 UTC
Thank you so much for the quick help and work on this! Looking forward to it!
Comment 13 ByWater Sandboxes 2023-02-07 12:26:35 UTC
Created attachment 146316 [details] [review]
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page.  It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 14 myoon 2023-02-07 22:53:10 UTC
Works like a charm!
Comment 15 Marcel de Rooy 2023-04-14 07:27:58 UTC
QAing
Comment 16 Marcel de Rooy 2023-04-14 07:41:55 UTC
Created attachment 149644 [details] [review]
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page.  It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 17 Tomás Cohen Arazi 2023-05-05 13:14:44 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 18 Martin Renvoize 2023-05-12 14:54:03 UTC
This is a nice enhancement.. but an enhancement it is so no backport for 22.11.x