Bug 22399 - Improve responsive behavior of the basic marc editor
Summary: Improve responsive behavior of the basic marc editor
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 22582 (view as bug list)
Depends on: 22045 22768 23159 23183
Blocks: 22582
  Show dependency treegraph
 
Reported: 2019-02-22 17:25 UTC by Owen Leonard
Modified: 2019-06-21 14:10 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
RMNOTE Delete from 19.05 release notes, has been reverted!
Version(s) released in:


Attachments
Animated gif showing the proposed style update (373.58 KB, image/gif)
2019-02-22 17:25 UTC, Owen Leonard
Details
Bug 22399: Improve responsive behavior of the basic marc editor (9.12 KB, patch)
2019-02-22 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22399: Improve responsive behavior of the basic marc editor (9.37 KB, patch)
2019-02-22 18:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22399: Improve responsive behavior of the basic marc editor (9.44 KB, patch)
2019-02-25 14:00 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 22399: Improve responsive behavior of the basic marc editor (9.49 KB, patch)
2019-02-25 18:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-02-22 17:25:46 UTC
Created attachment 85569 [details]
Animated gif showing the proposed style update

I propose to make some markup and style changes to the MARC editor to improve its handling of smaller browser widths.
Comment 1 Owen Leonard 2019-02-22 17:36:43 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2019-02-22 18:55:21 UTC Comment hidden (obsolete)
Comment 3 Josef Moravec 2019-02-25 14:00:15 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2019-02-25 18:50:29 UTC
Created attachment 85666 [details] [review]
Bug 22399: Improve responsive behavior of the basic marc editor

This patch makes markup and style changes to the basic MARC editor in
order to improve the page's handling of smaller browser widths. It adds
Bootstrap grid markup to the form to help accomplish this.

To test, apply the patch and load a record for editing in the basic MARC
editor. Adjust your browser width and confirm that the form adjusts well
to various widths.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Nick Clemens 2019-03-15 20:02:00 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize 2019-03-19 11:00:26 UTC
Enhancement will not be backported to 18.11.x series.
Comment 7 Dobrica Pavlinusic 2019-03-27 14:21:22 UTC
It seems that this patch broke javascript functionality to move subfileds up (implemented in upSubfield inside js/cataloging.js).

Seems that <div id="row"> is special to this code, and this patch changes how it's used in semantic markup, this breaking editor.
Comment 8 Nick Clemens 2019-03-28 13:31:46 UTC
This had unintended consequences that broke other features.

Reverted from master a993bd3843fdfcf3a7f2df916299b32d4601b879
Comment 9 Nick Clemens 2019-03-28 13:32:16 UTC
*** Bug 22582 has been marked as a duplicate of this bug. ***
Comment 10 Martin Renvoize 2019-06-17 08:19:41 UTC
One to bring back to life for this new cycle Owen?