Dobrica's comment from Bug 22045: This bug broke keyboard shortcuts because of following change: --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -31,7 +31,7 @@ $.fn.tabIndex = function () { return $(this).parent().children('div').index(this); }; $.fn.selectTabByID = function (tabID) { - $(this).tabs("option", "active", $(tabID).tabIndex()); + $(this).tabs("option", "active", $( "#" + tabID ).tabIndex()); }; $(document).ready(function() { without modification to calling which also prefix tabID with #, thus creating invalid ##tabID
Created attachment 90810 [details] [review] Bug 22768: Global search form keyboard navigation broken Bug 22045 made changes to the global staff client JavaScript which broken keyboard navigation for the most common forms in the resident search form("Check out, Check in, Renew, Search). This patch reimplements the tab selection code on the basic MARC editor page so that the keyboard shortcut behavior can be restored. To test, apply the patch go to Cataloging. - Search for an existing record and edit it in the basic MARC editor. - Test that the numbered tabs (0-9) at the top work correctly. - Select a tab other than 0 and choose Save -> Save and continue editing. When the page reloads you should be returned to the tab you were on when you saved. - Go to the Circulation home page. Test the keyboard shortcuts for switching tabs in header area: - Alt-u (Check out) - Alt-r (Check in) - Alt-w (Renew) - Alt-q (Search)
*** Bug 23169 has been marked as a duplicate of this bug. ***
Created attachment 91486 [details] [review] Bug 22768: Global search form keyboard navigation broken Bug 22045 made changes to the global staff client JavaScript which broken keyboard navigation for the most common forms in the resident search form("Check out, Check in, Renew, Search). This patch reimplements the tab selection code on the basic MARC editor page so that the keyboard shortcut behavior can be restored. To test, apply the patch go to Cataloging. - Search for an existing record and edit it in the basic MARC editor. - Test that the numbered tabs (0-9) at the top work correctly. - Select a tab other than 0 and choose Save -> Save and continue editing. When the page reloads you should be returned to the tab you were on when you saved. - Go to the Circulation home page. Test the keyboard shortcuts for switching tabs in header area: - Alt-u (Check out) - Alt-r (Check in) - Alt-w (Renew) - Alt-q (Search)
Created attachment 91487 [details] [review] Bug 22768: Global search form keyboard navigation broken Bug 22045 made changes to the global staff client JavaScript which broken keyboard navigation for the most common forms in the resident search form("Check out, Check in, Renew, Search). This patch reimplements the tab selection code on the basic MARC editor page so that the keyboard shortcut behavior can be restored. To test, apply the patch go to Cataloging. - Search for an existing record and edit it in the basic MARC editor. - Test that the numbered tabs (0-9) at the top work correctly. - Select a tab other than 0 and choose Save -> Save and continue editing. When the page reloads you should be returned to the tab you were on when you saved. - Go to the Circulation home page. Test the keyboard shortcuts for switching tabs in header area: - Alt-u (Check out) - Alt-r (Check in) - Alt-w (Renew) - Alt-q (Search) Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 91502 [details] [review] Bug 22768: Global search form keyboard navigation broken Bug 22045 made changes to the global staff client JavaScript which broken keyboard navigation for the most common forms in the resident search form("Check out, Check in, Renew, Search). This patch reimplements the tab selection code on the basic MARC editor page so that the keyboard shortcut behavior can be restored. To test, apply the patch go to Cataloging. - Search for an existing record and edit it in the basic MARC editor. - Test that the numbered tabs (0-9) at the top work correctly. - Select a tab other than 0 and choose Save -> Save and continue editing. When the page reloads you should be returned to the tab you were on when you saved. - Go to the Circulation home page. Test the keyboard shortcuts for switching tabs in header area: - Alt-u (Check out) - Alt-r (Check in) - Alt-w (Renew) - Alt-q (Search) Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Created attachment 91518 [details] [review] Bug 22768: Global search form keyboard navigation broken Bug 22045 made changes to the global staff client JavaScript which broken keyboard navigation for the most common forms in the resident search form("Check out, Check in, Renew, Search). This patch reimplements the tab selection code on the basic MARC editor page so that the keyboard shortcut behavior can be restored. To test, apply the patch go to Cataloging. - Search for an existing record and edit it in the basic MARC editor. - Test that the numbered tabs (0-9) at the top work correctly. - Select a tab other than 0 and choose Save -> Save and continue editing. When the page reloads you should be returned to the tab you were on when you saved. - Go to the Circulation home page. Test the keyboard shortcuts for switching tabs in header area: - Alt-u (Check out) - Alt-r (Check in) - Alt-w (Renew) - Alt-q (Search) Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
missing dependencies, wont backport to 18.11.x