Mana KB should have its own permission setting
Created attachment 84356 [details] [review] Bug 22198: Add granular permission setting for Mana KB This patch adds a separate permission for managing Mana KB. To test, apply the patch and update the database. - Open the permissions page for a patron with staff client privileges - Confirm that there is a "Manage Mana KB content sharing (manage_mana)" permission. - Leaving this new permission unchecked, log into the staff client with as that patron and go to the Administration home page. - The "Using Mana-KB" link should not appear. - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You should get a "permission denied" message. - Modify the patron's permissions to grant them access to Mana KB. - Confirm that the link now appears on the Administration home page and that the user can access the page.
Created attachment 84358 [details] [review] Bug 22198: Add granular permission setting for Mana KB This patch adds a separate permission for managing Mana KB. To test, apply the patch and update the database. - Open the permissions page for a patron with staff client privileges - Confirm that there is a "Manage Mana KB content sharing (manage_mana)" permission. - Leaving this new permission unchecked, log into the staff client with as that patron and go to the Administration home page. - The "Using Mana-KB" link should not appear. - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You should get a "permission denied" message. - Modify the patron's permissions to grant them access to Mana KB. - Confirm that the link now appears on the Administration home page and that the user can access the page.
Created attachment 84431 [details] [review] Bug 22198: Add granular permission setting for Mana KB This patch adds a separate permission for managing Mana KB. To test, apply the patch and update the database. - Open the permissions page for a patron with staff client privileges - Confirm that there is a "Manage Mana KB content sharing (manage_mana)" permission. - Leaving this new permission unchecked, log into the staff client with as that patron and go to the Administration home page. - The "Using Mana-KB" link should not appear. - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You should get a "permission denied" message. - Modify the patron's permissions to grant them access to Mana KB. - Confirm that the link now appears on the Administration home page and that the user can access the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 84453 [details] [review] Bug 22198: Add granular permission setting for Mana KB This patch adds a separate permission for managing Mana KB. To test, apply the patch and update the database. - Open the permissions page for a patron with staff client privileges - Confirm that there is a "Manage Mana KB content sharing (manage_mana)" permission. - Leaving this new permission unchecked, log into the staff client with as that patron and go to the Administration home page. - The "Using Mana-KB" link should not appear. - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You should get a "permission denied" message. - Modify the patron's permissions to grant them access to Mana KB. - Confirm that the link now appears on the Administration home page and that the user can access the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Passing QA on this patch, but there is an issue: the listed dependency wasn't signed off initially. The dependency is only a line in the admin-home template, so I think even if pushed out of order this could probably be fixed easily.
Awesome work all! Pushed to master for 19.05
An enhancement to a new feature for 19.05.