Bug 23433 - Make consistent use of patron-title.inc in hold confirmation dialogs
Summary: Make consistent use of patron-title.inc in hold confirmation dialogs
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 23434
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-05 18:06 UTC by Owen Leonard
Modified: 2019-12-05 21:34 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs (4.52 KB, patch)
2019-08-06 16:12 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-08-05 18:06:49 UTC
We have inconsistent use of patron-title.inc in returns.tt. Sometimes it is used and sometimes it isn't. Where it was added it seems to have reversed the display of patron surname and first name: Previously last, first; now first last.

All uses of patron-title.inc in this situation should be consistent.
Comment 1 Owen Leonard 2019-08-06 16:12:46 UTC
Created attachment 92032 [details] [review]
Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs

Use of patron-title.inc on the checkin page is inconsistent, resulting
in patron names being displayed differently under different
circumstances. This patch makes it more consistent.

To test, apply the patch and check in items with the following statuses:

 - On hold for a patron at your library
 - On hold for a patron not at your library
 - On hold and already marked 'Waiting'
 - On hold while HoldsAutoFill preference is enabled
Comment 2 Lucas Gass 2019-12-05 21:34:06 UTC
Owen, I can no longer cleanly apply this patch to master. If you can rebase it, I will attempt to sign off