Bug 27301 - Harmonize methods for providing biblionumbers to opac-reserve.pl
Summary: Harmonize methods for providing biblionumbers to opac-reserve.pl
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2020-12-23 01:47 UTC by David Cook
Modified: 2023-07-01 15:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27301: Pass biblionumbers to opac-reserve.pl in one style only (9.86 KB, patch)
2020-12-23 06:42 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2020-12-23 01:47:05 UTC
At the moment, you can send biblionumbers to opac-reserve.pl either as multiple "biblionumbers" arguments or as a single compacted string like "1/2/3".

It seems silly to me to have all this code for handling these different scenarios. We should just harmonize the callers.
Comment 1 David Cook 2020-12-23 05:57:30 UTC Comment hidden (obsolete)
Comment 2 David Cook 2020-12-23 05:58:34 UTC Comment hidden (obsolete)
Comment 3 David Cook 2020-12-23 06:42:09 UTC
Created attachment 114661 [details] [review]
Bug 27301: Pass biblionumbers to opac-reserve.pl in one style only

This patch forces biblionumbers to be passed to opac-reserve.pl as
individual "biblionumber" parameters instead of sending a concatenated
string as a "biblionumbers" parameter.

Test plan:

_Search Results_
1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Checkbox # 1 and # 2
3. Click "Place hold"
4. Click "Confirm hold"
5. Note that holds are made
6. Cancel holds to prepare for next test...

_Cart_
1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Checkbox # 1 and # 2
3. Add to cart
4. Click on "Cart"
5. Click "Select all"
6. Click "Place hold"
7. Click "Confirm hold"
8. Note that holds are made
9. Cancel holds to prepare for next test...

_List_
1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Checkbox # 1 and # 2
3. Add to new list
4. Click on list
5. Click "Select all"
6. Click "Place hold"
7. Click "Confirm hold"
8. Note that holds are made
9. Cancel holds to prepare for next test...

_Detail page_
1. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29
2. Click "Place hold"
3. Click "Confirm hold"
4. Note that holds are made
5. Cancel hold (because you may as well at this point)
Comment 4 Mazen Khallaf 2021-01-19 03:21:06 UTC
Received error "Sorry, you cannot place holds. ERROR: No record id specified." as I tried to place a hold through the cart (Step 6 of _Cart_)